--- Log opened Tue Jan 28 00:00:22 2020
00:03 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Ping timeout: 248 seconds]
00:16 -!- real_or_random [~smuxi@HSI-KBW-091-089-171-009.hsi2.kabel-badenwuerttemberg.de] has joined #rust-bitcoin
01:32 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 268 seconds]
02:05 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin
02:39 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
03:04 -!- Margie7Williamso [~Margie7Wi@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
03:37 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Ping timeout: 260 seconds]
03:38 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin
03:46 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 240 seconds]
03:47 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin
03:59 -!- orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin
04:00 -!- real_or_random [~smuxi@HSI-KBW-091-089-171-009.hsi2.kabel-badenwuerttemberg.de] has quit [Read error: Connection reset by peer]
04:00 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 272 seconds]
04:36 -!- jamesob [sid180710@gateway/web/irccloud.com/x-aggzqrsxjxduhabj] has quit []
04:36 -!- jamesob [sid180710@gateway/web/irccloud.com/x-nezxkhuukhlgorqy] has joined #rust-bitcoin
04:37 -!- Margie7Williamso [~Margie7Wi@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 246 seconds]
05:12 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-tacmetkgabxadxdg] has quit []
05:13 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-pnjcioaooqszugjy] has joined #rust-bitcoin
05:49 -!- orlovsky [~dr-orlovs@194.230.147.90] has quit [Read error: Connection reset by peer]
05:50 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin
05:51 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Read error: Connection reset by peer]
05:52 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin
06:12 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has joined #rust-bitcoin
06:21 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Read error: Connection reset by peer]
06:22 -!- orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin
06:55 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has quit [Quit: tyler]
07:07 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has joined #rust-bitcoin
07:12 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has quit [Client Quit]
07:31 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has joined #rust-bitcoin
08:03 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin
08:22 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Quit: notmandatory]
08:30 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has quit [Quit: tyler]
08:41 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has joined #rust-bitcoin
08:46 -!- moneyball [sid299869@gateway/web/irccloud.com/x-ovnazfnmowvbxxke] has quit []
08:46 -!- moneyball [sid299869@gateway/web/irccloud.com/x-nygdhnfgbmhpblqo] has joined #rust-bitcoin
09:02 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin
09:05 -!- orlovsky [~dr-orlovs@194.230.147.90] has quit [Ping timeout: 268 seconds]
09:14 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
09:17 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin
09:23 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin
09:26 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Ping timeout: 265 seconds]
11:07 < dpc> When I do `{:?}` on a `Transaction`, the Script stuff gets printed as hex, but witness is `[[], [1, 2,3] ... ]`. Expected? Good/bad?
11:17 < dpc> Looks like it is expected, even if slightly less convenient.
11:36 < dpc> It's probably a lame question, but why is `witness : `Vec<Vec<u8>>` and not just `Vec<u8>`. It seems to me it would be easier to decode the witness into `Script` if it was just one array?
11:45 -!- Aleru [sid403553@gateway/web/irccloud.com/x-iexvkfgqngxluxfn] has quit []
11:45 -!- Aleru [sid403553@gateway/web/irccloud.com/x-tlwgvhiokqgjxpuh] has joined #rust-bitcoin
12:00 < stevenroose> dpc: yeah that's expected, but sucks
12:00 < stevenroose> a witness is a series of pushes
12:01 < stevenroose> I also saw that debug message several times and hated it
12:01 < stevenroose> the onyl solution is to have a type Witness(Vec<Vec<u8>>) wrapping it, but that doesn't seem to be worth it
12:01 < dpc> One could wrap `Vec<Vec<u8>>` in a newtype, just to make the outputs of `Debug` and `Display` different.
12:02 < dpc> So what's the best way to convert `Vec<Vec<u8>>` into `Script`?
12:03 < dpc> Maybe there should be `Transaction::deserialize_witness(&self) -> Result<Script>` or something like that.
12:30 < dpc> I'm confused. I am witting some code that verifies signatures on a signed tx. I used `Transaction::signature_hash` + `secp.verify` for a normal P2SH input, and that worked OK. But it seems to fail for signature that I took out of a `witness` in a P2SHP2WSH input. So I'm googling around and it seems that segwit might be using a different hash (kind of makes sense? that's how segwit fixed malleability?). But when I look at
12:30 < dpc> `signature_hash` it doesn't seem to be doing anything special when `witness` is there? So what should I use instead? And there are `ScriptHash` and `WScriptHash` types, which might be what I want? But I can't seem to find a way to use them?
12:42 < dpc> Ooohh... https://docs.rs/bitcoin/0.23.0/bitcoin/util/bip143/struct.SighashComponents.html#method.sighash_all
12:44 < elichai2> dpc: yep. You need the bip143 module
12:44 <@andytoshi> yeah, not a bad idea to newtype witnesses
12:45 <@andytoshi> dpc: a witness stack is not a script
12:45 <@andytoshi> there is no conversion
12:48 <@andytoshi> segwit uses a different sighash, this is bip143. it is not about malleability
12:48 <@andytoshi> but about efficiency
12:53 < dpc> And hardware wallets, since it signs over `value`. :)
13:39 -!- tyler [~tyler@rrcs-76-79-47-154.west.biz.rr.com] has quit [Quit: tyler]
14:06 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin
14:06 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Remote host closed the connection]
14:06 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin
15:17 -!- real_or_random [~smuxi@p5DEAAED5.dip0.t-ipconnect.de] has joined #rust-bitcoin
16:30 -!- real_or_random [~smuxi@p5DEAAED5.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
17:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
20:28 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Quit: ZNC 1.7.5 - https://znc.in]
20:29 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
21:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
--- Log closed Wed Jan 29 00:00:23 2020