--- Log opened Tue Mar 17 00:00:24 2020
04:03 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:90fa:bd9f:718c:866b] has joined #rust-bitcoin
04:04 -!- Angel39Hermann [~Angel39He@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
04:23 < elichai2> anything I should look at/implement/review?
04:31 -!- Angel39Hermann [~Angel39He@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 246 seconds]
04:35 < elichai2> regarding https://github.com/rust-bitcoin/rust-bitcoin/issues/409 I'm thinking of either copying std::io::Read/Write implementations or implementing our variant (just extending WriteExt and ReadExt enough for it to work and implementing it on all the needed primitives)
04:35 < elichai2> andytoshi
05:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
05:05 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
05:05 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Remote host closed the connection]
05:05 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
05:10 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Client Quit]
05:10 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
05:21 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Ping timeout: 246 seconds]
05:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
05:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
05:31 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Quit: ZNC 1.7.5 - https://znc.in]
05:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
05:34 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
06:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
06:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
06:21 < andytoshi> i think there's almost zero value in copying std::io::Read/Write
06:21 < andytoshi> the point of those traits is that they're used throughout the ecosystem
06:22 < andytoshi> this is a really frustrating problem and i don't have a good answer. for bitcoin_hashes we copied the byteorder approach of just crippling the library in no_std mode
06:23 < andytoshi> does that seem like an option? i don't want to disable psbt entirely because stepan needs it, but maybe we could expose a much more limited API that didn't use read/write?
06:23 < andytoshi> (as a first step we actually could just disable PSBT btw. better to have something than nothing)
06:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
06:25 -!- jonatack [~jon@37.173.205.173] has joined #rust-bitcoin
06:27 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
06:44 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has joined #rust-bitcoin
06:59 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has quit [Quit: varioust]
07:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
07:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
08:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
08:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
08:31 -!- jonatack [~jon@37.173.205.173] has quit [Quit: jonatack]
08:37 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
08:58 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:90fa:bd9f:718c:866b] has quit []
09:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
09:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
09:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
09:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
10:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
10:35 < BlueMatt> elichai2: if you're bored, there's *always* things to do on rust-lightning :p
10:40 < elichai2> andytoshi: the problem is more about the internals, all the encoding traits are built on top of Read/Write.
10:41 < elichai2> BlueMatt: hehe, I might give it a try if there's a list of problems/bugs/something else, but I really don't know enough about lightning's low level infra
10:42 < BlueMatt> elichai2: ehh, there's lots of barely-lightning-related stuff, or you can start learning. either way :)
10:43 < BlueMatt> elichai2: also, whats the story on mutagen. I get the upstream stance of "failing tests due to missing mutations is dumb", but also its not like any code coverage tools are gonna care about mutagen output for a long time.
10:43 < BlueMatt> if ever
10:43 < BlueMatt> so personally I like the idea of moving forward with the "fail on missing mutations" strategy, though we should do the same across our crates (maybe put a fork in rust-bitcoin?)
10:43 < BlueMatt> also andytoshi
10:50 < elichai2> the problem with "fail on missing mutation tests" is when mutagen adds new kinds of mutations which will fail currently working code
10:51 < BlueMatt> well we'd be maintaining a fork anyway
10:51 < elichai2> why?
10:51 < BlueMatt> to support failing?
10:51 < BlueMatt> but, true, it'd make it hard to take new updates from upstream
10:51 < BlueMatt> but without that, we'd ignore the mutagen results 99.9% of the time
10:51 < BlueMatt> which is equally useless
10:53 < elichai2> if we could just make the CI post it as a comment or something. I do like being notified when there are missing tests so I can impl more, but failing CIs on unrelated contributions because of it suck
10:54 < elichai2> maybe first stage would be to add the cfg attr with mutagen everywhere so everyone can at first run them locally
10:54 < elichai2> then we could PR mutagen with a non-zero exit code, and see what do we want from there (ie we can make it an optional travis failure, so it will be obvious it failed but won't stop us from merging)
10:58 < BlueMatt> yea, I think a comment that just posts the output of mutagen would probably be good
10:58 < BlueMatt> is there any reasonable way to hook that up?
11:51 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
11:52 < andytoshi> BlueMatt: what's the question?
11:52 < andytoshi> i think we should definitely fail on missing mutations
11:53 < andytoshi> yeah, sucks that this will break CI frequently without warning ... but like, these failures will represent missing test coverage
11:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:57 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
12:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
12:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
12:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
12:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
12:43 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e899:b041:3610:2bad] has joined #rust-bitcoin
12:58 < elichai2> BlueMatt: idk how draftbot but I guess something along these lines, who operates it? Hehe
13:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
13:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
13:36 < BlueMatt> elichai2: drahtbot is marcofalke, but github bots are pretty easy - they have a reasonable API to post things like comments
13:36 < BlueMatt> the most annoying bit is getting some hardware somewhere to run the thing on
14:05 -!- fiatjaf [~fiatjaf@2804:7f2:2980:90fa:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 240 seconds]
14:09 -!- fiatjaf [~fiatjaf@177.206.42.162.dynamic.adsl.gvt.net.br] has joined #rust-bitcoin
15:36 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:40 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
15:42 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
16:44 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e899:b041:3610:2bad] has quit []
16:47 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
16:49 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
16:57 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
17:06 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
17:16 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
17:25 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Quit: varioust]
17:26 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
19:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
19:52 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Ping timeout: 264 seconds]
19:55 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
20:08 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Quit: varioust]
22:51 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 265 seconds]
22:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
22:51 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
22:54 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #rust-bitcoin
23:43 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
23:44 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
--- Log closed Wed Mar 18 00:00:25 2020