--- Log opened Sat Mar 21 00:00:29 2020 00:18 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Read error: Connection reset by peer] 00:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer] 00:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 00:19 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 01:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:44 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 01:55 -!- Kiminuo [~mix@141.98.103.134] has quit [Ping timeout: 264 seconds] 02:00 -!- Kiminuo [~mix@141.98.103.134] has joined #rust-bitcoin 04:06 -!- Mara77Kuvalis [~Mara77Kuv@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 04:44 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8f6:feac:725:f1] has joined #rust-bitcoin 05:17 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Quit: ZNC 1.7.4+deb7 - https://znc.in] 05:18 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #rust-bitcoin 06:59 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 07:03 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 07:39 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 07:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 09:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 09:31 -!- Mara77Kuvalis [~Mara77Kuv@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 250 seconds] 11:34 < ariard> BlueMatt: #555 is hot with your suggestion :) 13:05 < BlueMatt> ariard: 555 now has a struct with one member.......... 13:05 < BlueMatt> otherwise LGTM 14:05 < ariard> BlueMatt: right that's dumb, updated 15:08 < BlueMatt> ariard: why are you renaming "key_storage" to onchain_detection? Its not really used in onchain_detection, its really the storage of keys, almost entirely. 15:09 < BlueMatt> ariard: also, it is gonna get removed soon hopefully anyway, so renaming it is just useless diff 15:12 < BlueMatt> ah, I see that you removed the duplicate keys in the next commit 15:12 < BlueMatt> still, maybe just flatten it? 15:12 < BlueMatt> I dont think "OnchainDetection makes sense for the struct that holds keys. 15:12 < BlueMatt> I'll merge it as is to make progress, but we should flatten it soon. 15:29 < ariard> BlueMatt: yeah I know, I'm working on flattening, merging detection stuff in OnchainDetection right now 15:29 < BlueMatt> already have a commit :p 15:45 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 15:46 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 16:20 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 16:22 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 17:10 < ariard> BlueMatt: I'm meeeeeh on #558, likely to throw me in rebase hell 17:10 < ariard> will try to take commits on top of my branch if it's sitll make sense 17:11 < ariard> almost there, will open a PR tmrw, and then stop OnchainTxHandler/ChannelMonitor refactoring for now 17:27 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:42 < BlueMatt> ariard: Ill rebase it on your stuff, np 17:42 < BlueMatt> ariard: 558 can wait 12 months for all i care 19:19 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8f6:feac:725:f1] has quit [] 19:54 < ariard> BlueMatt: lol, I thought we were over with 12-months old PR :p --- Log closed Sun Mar 22 00:00:30 2020