--- Log opened Tue Mar 24 00:00:31 2020
02:22 -!- Kiminuo [~mix@141.98.103.116] has joined #rust-bitcoin
04:06 -!- Pinkie38Hoeger [~Pinkie38H@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
04:23 -!- fiatjaf1 is now known as fiatjaf
04:38 -!- willcl_ark__ [~quassel@95.211.225.220] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
05:47 -!- Blackwolfsa4 [~Blackwolf@195.159.29.126] has joined #rust-bitcoin
05:49 -!- Pinkie38Hoeger [~Pinkie38H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]
05:56 < elichai2> So some of the benchmarks on rust-secp are broken :/ we didn't test with rand+recovery features
05:57 < elichai2> I'm thinking of migrating to criterion, that way we get stable and we get easier htmls to plot changes
06:03 < elichai2> thoughts?, I want to start writing a lot of benchmarks in rust-bitcoin so we can know if changes are actually improving or decreasing performance
06:16 < elichai2> "Dev-dependencies are not allowed to be optional" damn it. so criterion will basically break MSRV for the tests :(
06:44 < andytoshi> do we test benchmarks at all?
06:45 < andytoshi> iirc we'd already broken MSRV for benchmarks
06:45 < andytoshi> at one point they were nightly-only even
07:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
07:47 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
07:52 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
07:54 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
07:59 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:03 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:07 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:10 < BlueMatt> ariard: re: safe api: I'm less concerned with having an API in ChannelSigner which is safe. only that the API makes sense. the transaction format that you're passing to CHannelKeys makes no sense (signaures and flags randomly stuffed into the witness)
08:11 < BlueMatt> ariard: re: safe API: what I *do* want a safer API to, is the concept of signing a local transaction *within* OnchainTx
08:12 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:13 < BlueMatt> right now it stores partially signed, in this strange format, transactions locally with a) no safe wrapper to make sure they're signed before use (eg LocalCommitmentTransaction), and b) no safe wrapper around prev+cur to make sure that you only ever get cur (or prev's HTLCs, as long as it wasnt revoked) signed, and once you do so you cannot update the monitor at all or it panic!()s
08:13 < BlueMatt> re: 560: awesome!!! I likely wont take much of a look until we land 559, but great work!
08:16 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:19 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:24 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:29 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:34 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:35 -!- Kiminuo [~mix@141.98.103.116] has quit [Ping timeout: 256 seconds]
08:38 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:43 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:45 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:47 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:51 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
08:53 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
08:58 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:03 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:07 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:13 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:18 -!- Kiminuo [~mix@141.98.103.94] has joined #rust-bitcoin
09:18 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:20 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:25 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:29 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:33 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:35 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:40 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:42 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:47 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
09:49 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
09:54 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:00 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
10:05 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:07 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
10:12 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:18 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
10:23 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:25 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
10:30 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:34 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
10:39 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:40 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
10:44 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds]
10:45 -!- Netsplit *.net <-> *.split quits: real_or_random, kanzure
10:45 -!- Netsplit over, joins: kanzure
10:46 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #rust-bitcoin
10:48 -!- shesek [~shesek@185.3.145.94] has joined #rust-bitcoin
11:13 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e9f4:57b2:ae91:a2c1] has joined #rust-bitcoin
11:58 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e9f4:57b2:ae91:a2c1] has quit []
12:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:13 -!- shesek [~shesek@185.3.145.94] has quit [Changing host]
12:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
12:22 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e9f4:57b2:ae91:a2c1] has joined #rust-bitcoin
12:32 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e9f4:57b2:ae91:a2c1] has quit []
12:34 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e9f4:57b2:ae91:a2c1] has joined #rust-bitcoin
12:57 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e9f4:57b2:ae91:a2c1] has quit []
14:11 < ariard> BlueMatt: okay see 561+562, I think it removes all private key from ChannelMonitor memory, including spendable output descrptors ones :)
14:11 < ariard> sorry was too tempting to do, now I can implement back your suggestions back in 559 with being sure of what we need to cache
14:12 < ariard> the only SecretKey left is per_commitment_key for detection, which doesn't matter because a) it already transits through on-the-wire messages b) you can't spend anything with this one only
15:16 < BlueMatt> ariard: hah! nah, all good, sounds gret! I may not jump in to reviewing a stack of 30 commits, but I get it, and happy you did it :)
16:59 < ariard> BlueMatt Yeah I don't expect to review a stack of 30commits, I integrated back LocalCommitment in ChanSigner, now just have to extend it to pair htlcs to cur/prev
16:59 < ariard> will review mpp tmrw for sure
17:11 < BlueMatt> ariard: would be nicer for me if we got 559 over the line
17:11 < BlueMatt> ariard: its kinda annoying to go do anchor outputs while monitor stuff is all in-flux
17:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
23:51 -!- Kiminuo [~mix@141.98.103.94] has quit [Ping timeout: 240 seconds]
--- Log closed Wed Mar 25 00:00:28 2020