--- Log opened Sat Apr 04 00:00:42 2020
02:03 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
03:04 -!- Christian54Hahn [~Christian@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
03:33 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:33 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
06:21 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
06:35 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
06:36 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
06:39 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
07:31 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:12 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin
08:29 -!- titanbiscuit [~tbisk@23.105.160.136] has quit [Ping timeout: 265 seconds]
09:19 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:51 < BlueMatt> ariard: I think Jeff is in progress, so not gonna squash just yet, but feel free to review the squashed versions!
10:51 < BlueMatt> it should be getting close-ish, but may be better to foccus on 559
10:51 < BlueMatt> given the tree of PRs built on top
11:22 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin
11:29 -!- titanbiscuit [~tbisk@titan.pathogen.is] has joined #rust-bitcoin
11:30 -!- titanbiscuit [~tbisk@titan.pathogen.is] has quit [Read error: Connection reset by peer]
11:31 -!- titanbiscuit [~tbisk@23.105.160.143] has joined #rust-bitcoin
11:47 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit []
13:36 -!- titanbiscuit [~tbisk@23.105.160.143] has quit [Ping timeout: 256 seconds]
13:53 -!- titanbiscuit [~tbisk@144.48.38.184] has joined #rust-bitcoin
14:10 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
14:16 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin
15:59 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
16:00 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
16:26 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:27 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
16:56 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:03 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
20:19 < ariard> BlueMatt: addressed your comment on 559 except https://github.com/rust-bitcoin/rust-lightning/pull/559#discussion_r401284278
20:19 < ariard> I'm not sure your proposed API design suits well with
20:20 < ariard> a) when ChannelMonitor receives a block which triggers a local commitment transaction broadcast but client is sending a new local commitment transaction in-the-flight
20:21 < ariard> in this scenario ChannelMonitor being a watchtower and likely being forward on block processing
20:21 -!- fiatjaf1 [~fiatjaf@2804:7f2:2a81:4a17:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
20:22 < ariard> b) when channel state is unknown due to storage failure, you may want access to the local commitment transaction, so you can't return an Err
20:22 -!- Christian54Hahn [~Christian@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]
20:24 < BlueMatt> ariard: a) is a money-loss issue!
20:24 < BlueMatt> we *should* panic
20:24 -!- fiatjaf [~fiatjaf@177.97.204.42] has quit [Ping timeout: 256 seconds]
20:25 < BlueMatt> for b) hmmm...not sure what you mean here? if the storage is broken you cannot deserialize it to get at the object anyway?
20:27 < ariard> BlueMatt: a) is fine, you may have two valid commitment transactions
20:28 < ariard> Client receives commitment_signed, client sends commitment_signed to watchtower, watchtower sees a block and closes channel, watchtower receives commitment_signed
20:28 < ariard> is this flow working?
20:28 < BlueMatt> ariard: as long as you didnt revoke the previous one?
20:28 < ariard> I agree we should panic on the ChannelManager asking to force-close channel and then asking to update local, that would be a programming error
20:29 < BlueMatt> huh? its def a money-loss issue
20:29 < ariard> yes, I assume this
20:29 < BlueMatt> its only not a money-loss issue if what was broadcast was a remote tx?
20:29 < BlueMatt> but, as I pointed out there, we should have a one-block headroom
20:29 < BlueMatt> or 2
20:29 < ariard> hmmmm, not sure I want to go this way...
20:30 < ariard> like one day we will have a shitty client being far behind on block processing
20:30 < ariard> no broadcast may be due to a HTLC to timeout and being triggered by a block increasing height
20:31 < ariard> prev local commitment is broadcast to timeout HTLC, then actual local commitment update is received from client
20:31 < ariard> counterparty can't claim with justice prev local commiemnt because client should release revocation secret without state-invalidation ACK from monitor
20:31 < ariard> *shouldn't, sorry
20:33 < ariard> ->bbl
20:33 < BlueMatt> ah, you're saying that the thing that prevents should be the update-ack, not a race
20:33 < BlueMatt> hmmmm
20:33 < BlueMatt> let me think on that
22:42 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:45 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
--- Log closed Sun Apr 05 00:00:43 2020