--- Log opened Sun Apr 05 00:00:43 2020 00:15 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 00:16 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 00:39 -!- fiatjaf1 [~fiatjaf@2804:7f2:2a81:4a17:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 265 seconds] 00:52 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin 00:55 < elichai2> stevenroose: any chance for a review so we can get this PR over with? :D https://github.com/rust-bitcoin/rust-bitcoin/pull/308 01:24 -!- fiatjaf1 [~fiatjaf@177.17.67.203] has joined #rust-bitcoin 01:31 -!- fiatjaf1 [~fiatjaf@177.17.67.203] has quit [Ping timeout: 256 seconds] 02:17 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:06 -!- Stacey24Fay [~Stacey24F@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 04:53 -!- fiatjaf [~fiatjaf@2804:7f2:2a81:4a17:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin 04:57 -!- Stacey24Fay [~Stacey24F@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 06:24 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:24 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 07:14 < elichai2> Sorry for the mess in #356 09:04 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 09:13 < stevenroose> elichai2: acked 09:13 < stevenroose> just one nit 09:16 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 09:26 < andytoshi> oh, sorry, i merged it because you acked 09:26 < andytoshi> but did you want elichai2 to address the Entry nit? 09:37 < elichai2> I responded. will see what stevenroose says 10:01 < stevenroose> it's was a nit.. in that I would have addressed it but I'm not going to make it a problem if it's not addressed :p 10:09 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Remote host closed the connection] 10:09 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 10:15 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Ping timeout: 265 seconds] 10:31 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 10:38 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Remote host closed the connection] 10:38 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 10:45 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 10:46 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 11:44 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Remote host closed the connection] 11:48 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 11:54 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Ping timeout: 265 seconds] 12:02 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 12:08 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Ping timeout: 272 seconds] 12:25 < BlueMatt> ariard: I think I agree with you - can you make that change? so a) getting latest local transactions should be infallible and result in us "force-closing the channel", and b) the update_monitor stuff should return an Err after we've force-closed the channel (I think this will need to be piped through ManyChannelMonitor, which may expect all updates to succeed) 12:35 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 12:52 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Remote host closed the connection] 12:52 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has joined #rust-bitcoin 12:56 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:147b:bb49:5c9b:67f5] has quit [Client Quit] 14:25 < stevenroose> elichai2: all good, made sense 14:57 -!- real_or_random [~real_or_r@173.249.7.254] has quit [Quit: ZNC 1.7.5 - https://znc.in] 14:58 -!- real_or_random [~real_or_r@173.249.7.254] has joined #rust-bitcoin 18:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 19:55 -!- kevingislason [49777ce7@c-73-119-124-231.hsd1.ma.comcast.net] has joined #rust-bitcoin 20:38 -!- rjected_ [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #rust-bitcoin 20:38 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 264 seconds] 21:01 -!- kevingislason [49777ce7@c-73-119-124-231.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 22:38 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 22:38 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 22:39 -!- guest534543 [~mix@141.98.103.84] has quit [Ping timeout: 260 seconds] 22:47 -!- Kiminuo [~mix@141.98.103.142] has joined #rust-bitcoin --- Log closed Mon Apr 06 00:00:45 2020