--- Log opened Mon Apr 06 00:00:45 2020 00:19 < ariard> BlueMatt: noted, and panic if we receive the sequence ChannelForceClosed, LatestLocalCommitmentTXInfo, this one would clearly be a bug from Channel 00:41 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 00:42 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 00:44 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 01:25 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 01:26 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 02:21 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin 03:06 -!- Terrance75Kutch [~Terrance7@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 03:27 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds] 03:35 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin 03:47 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds] 03:51 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin 04:28 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:48 -!- Terrance75Kutch [~Terrance7@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 07:38 -!- Kiminuo [~mix@141.98.103.142] has quit [Ping timeout: 240 seconds] 07:57 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin 08:44 -!- Fredy30Borer [~Fredy30Bo@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 09:27 < BlueMatt> ariard: yep! 09:27 < BlueMatt> ariard: cool, glad we found agreement here :) 09:34 -!- Kiminuo [~mix@141.98.103.142] has joined #rust-bitcoin 11:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 11:05 -!- wumpus2 [~ircclient@pdpc/supporter/professional/wumpus] has joined #rust-bitcoin 11:07 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 11:08 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Read error: Connection reset by peer] 11:08 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 246 seconds] 11:08 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds] 11:08 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #rust-bitcoin 11:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 11:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 11:29 -!- Fredy30Borer [~Fredy30Bo@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 12:04 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:07 -!- wumpus2 is now known as wumpus 12:46 -!- rjected_ [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Quit: ZNC 1.7.4+deb0+disco0 - https://znc.in] 12:47 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #rust-bitcoin 13:41 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:54f6:d7e8:72cd:f296] has joined #rust-bitcoin 13:59 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin 14:14 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:54f6:d7e8:72cd:f296] has quit [] 14:21 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:01 < ariard> BlueMatt: updated, note get_fully_signed_local_tx isn't infaillibe yet, as it would need some Channel modifs (for outbound channel, init ChannelMonitor at Channel::funding_signed only) 16:02 < ariard> reason is more layout in a big TODO, I want to avoid introducing a Channel diff in this already-too-large-scoped PR 16:14 < BlueMatt> ariard: awesome! yea, thats fair, sucks, but is fair. I want to do a followup and clean up the channelmonitor initialization anyway so I can handle that 16:17 < BlueMatt> ariard: but, I think, with mpp + 559 + https://github.com/rust-bitcoin/rust-lightning/issues/567 we should push 0.0.11 16:17 < BlueMatt> its longggggggg overdue 16:18 < BlueMatt> hopefully with an 0.0.12 quickly thereafter with just cleanups and finishing your work. 16:18 < ariard> yeah, it just two big chunks but they are pretty mature 16:19 < ariard> rest of ChannelMonitor refactoring is quite easy to compare (#560-562) 16:22 < BlueMatt> right 16:22 < BlueMatt> and a bunch of cleanup to do afterwards anyway 16:24 < ariard> BlueMatt: reading your comment here https://github.com/lightningnetwork/lightning-rfc/pull/688#discussion_r401802808, I think you're right 16:25 < ariard> but not for the same attack that you're mentionning, I'm thinking more about remote party leveraring SIGHASH_SINGLE to add an output to your HTLC-timeout 16:25 < ariard> and stuck the whole package in the mempool 16:26 < ariard> spec is modified to use SIGHASH_SINGLE on 2nd-stage txn (HTLC-success, HTLC-timeout) is this secure ? 16:27 < BlueMatt> hmm. I'd never thought about adding SIGHASH_SINGLE - why would you want that? 16:28 < BlueMatt> is that for RBF of the HTLC txn? 16:28 < ariard> to aggregate txn and BYOF-them 16:28 < ariard> like adding a bumping input 16:29 < BlueMatt> right...I guess its worth considering? 16:31 < ariard> hmmm, let's say I'm connected to your full-node, you broadcast the HTLC-timeout, I catch it on-fly, add dumb input-output branch to decrease feerate 16:31 < ariard> and then directly TX all miners mempool because I'm connected through Fiber 16:31 < ariard> is this a realistic scenario? 16:31 < ariard> *Fibre, sorry 16:32 < BlueMatt> yea, essentially. 16:34 < ariard> and I'm almost sure to win the p2p race, unless we recommend people to connect also to Fiber.. 16:34 < ariard> okay will comment scenario attack on the PR 16:34 < BlueMatt> fibre isnt really gonna broadcast any transactions faster 16:34 < BlueMatt> but you could just connect to every node on the network 16:34 < BlueMatt> bitcoin core very deliberately isnt super, super quick to relay transactions 16:34 < BlueMatt> so its easy to beat the p2p network 16:35 < ariard> right, what you want is hitting the most-mempool faster, and specially miners ones 16:35 < ariard> not enforcing tx-relay protocol is easy to do so as you say 18:38 -!- kevin_gislason [49777ce7@c-73-119-124-231.hsd1.ma.comcast.net] has joined #rust-bitcoin 20:14 -!- kevin_gislason [49777ce7@c-73-119-124-231.hsd1.ma.comcast.net] has quit [Remote host closed the connection] --- Log closed Tue Apr 07 00:00:45 2020