--- Log opened Tue Apr 14 00:00:51 2020
00:05 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ad0e:52f7:2635:5829] has joined #rust-bitcoin
00:10 -!- Kiminuo [~mix@141.98.103.108] has joined #rust-bitcoin
00:10 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ad0e:52f7:2635:5829] has quit [Ping timeout: 265 seconds]
00:32 -!- jonatack [~jon@109.202.107.147] has quit [Ping timeout: 250 seconds]
00:34 -!- jonatack [~jon@37.170.60.192] has joined #rust-bitcoin
01:39 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-hwtfxdqfnnsfqelt] has quit [Quit: killed]
01:39 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-miqludmpdyyuroup] has quit [Quit: killed]
01:50 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-yvbbyccotzemsbcj] has joined #rust-bitcoin
02:20 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-odacgarsbbtcwjvf] has joined #rust-bitcoin
02:43 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ad0e:52f7:2635:5829] has joined #rust-bitcoin
03:04 -!- Alejandrin78Emar [~Alejandri@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
03:19 -!- jonatack [~jon@37.170.60.192] has quit [Read error: Connection reset by peer]
03:19 -!- jonatack_ [~jon@37.170.60.192] has joined #rust-bitcoin
05:03 -!- jonatack_ [~jon@37.170.60.192] has quit [Quit: jonatack_]
05:04 -!- jonatack [~jon@213.152.161.101] has joined #rust-bitcoin
06:01 -!- michaelfolkson [~textual@host86-177-146-79.range86-177.btcentralplus.com] has joined #rust-bitcoin
06:01 -!- michaelfolkson [~textual@host86-177-146-79.range86-177.btcentralplus.com] has quit [Client Quit]
07:33 -!- Kiminuo [~mix@141.98.103.108] has quit [Ping timeout: 260 seconds]
08:47 -!- warren_ is now known as warren
10:24 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:b865:43b9:34cd:d980] has joined #rust-bitcoin
10:57 -!- Kiminuo [~mix@141.98.103.238] has joined #rust-bitcoin
12:32 -!- jonatack [~jon@213.152.161.101] has quit [Ping timeout: 256 seconds]
12:34 -!- jonatack [~jon@37.170.227.51] has joined #rust-bitcoin
13:33 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
13:34 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
14:34 < ariard> BlueMatt: replied, loosely concern about a tower returning a ChannelMonitorUpdateErr on last fragment of updates to not-pay full MPP
14:35 < ariard> but maybe that's too much far ahead, let's open an issue referring to comments, and make it part of ChannelMonitor documentation latter?
14:38 -!- Alejandrin78Emar [~Alejandri@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds]
14:48 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:b865:43b9:34cd:d980] has quit [Quit: Sleep mode]
15:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:34 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
15:42 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:48 < ariard> BlueMatt: module some new comments to be improved, mpp is good for me
16:43 < BlueMatt> ariard: wait, are you sure this preimage thing isnt wrong? What about the case where we see an inbound htlc with the same payment_hash as an outbound htlc on the same channel?
16:43 < BlueMatt> ariard: in that case we may include a preimage in the call when we dont, in fact, have one?
16:44 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ad0e:52f7:2635:5829] has quit [Remote host closed the connection]
16:53 < BlueMatt> ariard: any update on https://github.com/rust-bitcoin/rust-lightning/pull/559#discussion_r408501551 ?
17:26 < ariard> BlueMatt: seen for 559, okay we want just a copy-paste for now, will update
17:28 < ariard> BlueMatt: okay a) is about you update all HTLC shards, but one of ChannelMonitor is failing, and not claiming inbound HTLC on chain
17:28 < ariard> but as you reveal preimage on other channels, a node *may* use it to pull downstream channel for which upstream ChannelMonitor is failing
17:31 < BlueMatt> ariard: there should be no case where one ChannelMonitor never claims on-chain if it "fails"
17:31 < BlueMatt> as that would *also* screw us for forwarded payments
17:32 < ariard> BlueMatt: okay that what you refer in having a local copy that must never fail to update
17:35 < ariard> If so I think we're arguing for nothing, a monitor failure returned from a MPP claim_funds means you should access your copy of ChannelMonitor
17:35 < ariard> and update this one
17:36 < ariard> if yes we should document better claim_funds to make this clear what user should do in case of failure
17:36 < BlueMatt> there is no failure for claim_funds?
17:37 < BlueMatt> we already have that requirement
17:37 < BlueMatt> cause if we forwarded a payment, we may fail to update the monitor for the claim-backwards
17:38 < BlueMatt> see https://github.com/rust-bitcoin/rust-lightning/blob/master/lightning/src/ln/channelmonitor.rs#L158
17:39 < ariard> Yeah I think it's all fine, that what you should have pointed to me at first comment: https://github.com/rust-bitcoin/rust-lightning/pull/441#discussion_r407107192
17:40 < ariard> rest of comments we were just confusing ourselves :p
17:47 < BlueMatt> ah, ok
17:47 < BlueMatt> yea, I mean clearly talkng past each other
21:48 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:49 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
23:05 -!- Kiminuo [~mix@141.98.103.238] has quit [Ping timeout: 265 seconds]
23:15 -!- Kiminuo [~mix@141.98.103.148] has joined #rust-bitcoin
23:59 -!- jonatack [~jon@37.170.227.51] has quit [Remote host closed the connection]
--- Log closed Wed Apr 15 00:00:02 2020