--- Log opened Sat Apr 25 00:00:05 2020 00:44 < ariard> BlueMatt: okay done, rebasing my trio of PRs on top of 598 00:55 < ariard> okay I hijack 606 a bit, but being better on interface discussion would be a time win :p 03:06 -!- Lizzie85Champlin [~Lizzie85C@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 03:57 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has joined #rust-bitcoin 04:02 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has quit [Remote host closed the connection] 04:04 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has joined #rust-bitcoin 05:04 -!- jonatack [~jon@37.165.157.247] has quit [Ping timeout: 250 seconds] 05:05 -!- jonatack [~jon@134.19.179.139] has joined #rust-bitcoin 05:31 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 05:32 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 05:46 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 05:47 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 05:50 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:199d:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 265 seconds] 05:51 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:199d:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin 06:14 -!- jonatack [~jon@134.19.179.139] has quit [Ping timeout: 240 seconds] 06:16 -!- jonatack [~jon@37.172.233.157] has joined #rust-bitcoin 08:00 -!- Netsplit *.net <-> *.split quits: Ed0 08:01 -!- Ed0 [~edouard@2001:41d0:401:3100::4897] has joined #rust-bitcoin 08:06 -!- Netsplit *.net <-> *.split quits: wallet42, justinmoon, windsok 08:06 -!- Netsplit over, joins: justinmoon 08:06 -!- windsok [~windsok@rarepepe.cash] has joined #rust-bitcoin 08:06 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host] 08:06 -!- windsok [~windsok@unaffiliated/windsok] has joined #rust-bitcoin 08:06 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-zqrngmgryykgjjte] has joined #rust-bitcoin 08:07 -!- Kiminuo [~mix@141.98.103.190] has quit [Read error: Connection reset by peer] 08:07 -!- Kiminuo [~mix@141.98.103.190] has joined #rust-bitcoin 08:09 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 08:11 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 08:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 08:47 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 09:01 -!- Lizzie85Champlin [~Lizzie85C@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 09:22 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.7.5 - https://znc.in] 09:23 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #rust-bitcoin 09:33 -!- jonatack [~jon@37.172.233.157] has quit [Ping timeout: 250 seconds] 09:35 -!- jonatack [~jon@134.19.179.147] has joined #rust-bitcoin 09:44 < BlueMatt> ariard: let me know what labels to create 09:44 < BlueMatt> github doesn't seem to have sufficiently granular permissions 09:52 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 09:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 10:27 -!- jonatack [~jon@134.19.179.147] has quit [Quit: jonatack] 10:42 -!- jonatack [~jon@109.232.227.133] has joined #rust-bitcoin 10:55 -!- AmyWilleron [79ed9456@gateway/web/cgi-irc/kiwiirc.com/ip.121.237.148.86] has joined #rust-bitcoin 10:57 -!- AmyWilleron [79ed9456@gateway/web/cgi-irc/kiwiirc.com/ip.121.237.148.86] has quit [Client Quit] 12:37 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:37 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 12:51 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 14:40 -!- ChantalZale [02f90ced@gateway/web/cgi-irc/kiwiirc.com/ip.2.249.12.237] has joined #rust-bitcoin 14:43 -!- ChantalZale [02f90ced@gateway/web/cgi-irc/kiwiirc.com/ip.2.249.12.237] has quit [Client Quit] 15:57 < BlueMatt> ariard: see https://github.com/rust-bitcoin/rust-lightning/pull/560#issuecomment-619451428 - I still want to drop the local_commitment field in OnchainTxHandler and I think the direction we're going with remote txn is the wrong direction. 16:08 -!- Kiminuo [~mix@141.98.103.190] has quit [Read error: Connection reset by peer] 16:30 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has quit [Remote host closed the connection] 16:32 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has joined #rust-bitcoin 16:54 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has quit [Remote host closed the connection] 16:54 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has joined #rust-bitcoin 17:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 17:05 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has quit [Remote host closed the connection] 18:14 -!- jonatack [~jon@109.232.227.133] has quit [Ping timeout: 240 seconds] 18:17 -!- jonatack [~jon@37.172.109.60] has joined #rust-bitcoin 18:51 < ariard> I agree we should get back LocalOnchainCommitment/RemoteCommitment in ChannelMonitor, have you seen this https://github.com/rust-bitcoin/rust-lightning/issues/606? 18:52 < ariard> BlueMatt: labels, Easy-to-review,Medium-to-review,Advenced-to-review + Hot-review 18:52 < ariard> I can ask a commit on top of 562 to get back everything in ChannelMonitor, at least Prs are doing the encapsulation work 20:12 < BlueMatt> ariard: ok, labels created 20:22 < BlueMatt> ariard: holy shit, I had not seen your ascii art :) 20:31 < BlueMatt> ariard: yea, I mean if its gonna happen at the end thats ok with me. as with all the previous PRs I'm happy to merge stuff that is a step forward, even if it needs cleanup later 20:32 < BlueMatt> just as long as we agree with where its going :) 20:36 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] --- Log closed Sun Apr 26 00:00:04 2020