--- Log opened Wed Jul 22 00:00:27 2020 00:08 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin 01:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 01:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 01:35 < elichai2> Why can 01:35 < elichai2> *Why can't I merge this? https://github.com/rust-bitcoin/rust-bitcoin/pull/435 01:35 < elichai2> it gots 3 approves, but for some reason it really wants stevenroose's review 01:38 < stevenroose> ah because I had a "request changes" before 01:39 < stevenroose> elichai2: merged 01:39 < elichai2> I'd assume it will allow me to override this, weird 01:39 < elichai2> thx\ 01:40 < sgeisler> I thought the same, now it's probably the PR with the highest approval rating xD 01:41 < stevenroose> BlueMatt: he says it takes 120 GB to do a bootstrap. I have a Core i7 laptop and a spare 200GB SSD. You think it's feasible to do a bootstrap overnight? I don't know the process, do you have to manually trigger each version or can it just run for hours while I'm out of the house? 01:42 < stevenroose> sgeisler, elichai2 yeah I thikn github's policy is that 2 contributors need to ack it but if one nacks, others can't merge it. I thikn that might make sense in many scenarios. But yeah I just asked for a whitespace nit :) 01:42 < stevenroose> Maybe I should use `Comment` for that instead of `Request Changes`. 01:44 < elichai2> stevenroose: I think it's feasible to bootstrap over night (I've compiled rustc+mrustc in the past already, each compilation on a good CPU is ~40m from nothing) 01:48 < elichai2> BlueMatt: I see we're supporting honggfuzz and not libfuzzer, is there any real difference? both are developed by google lol 01:50 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #rust-bitcoin 01:56 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 256 seconds] 02:29 < cloudhead> are we going to cut a new release at some point? it's been on 0.23 since a while now 02:30 < stevenroose> cloudhead: any changes you're especially waiting for? 02:37 < cloudhead> stevenroose: nothing urgent tbh, but would allow me to remove some code from my light client 02:37 < cloudhead> just wondering 02:39 < stevenroose> cloudhead: I think we generally wait until we feel some need of urgency either because someone really wants a feature released or because we're about to make some big breaking changes so then we release a non-breaking bump first. I'm actually not sure if current master has breaking changes against 0.23, I'd have to check. If not, I'm ok with bumping the minor version. 02:40 < cloudhead> ok gotcha 02:44 < elichai2> stevenroose: there must be some lib that can test this for us in the CI hmmm 02:46 < stevenroose> 81c061a68c62f31fedd35fa68243b5952ef42f86 is breaking, but arguably a fix; ab6e20c87ea1244b278af0deba0f8835fbac8ef6 fixes an overflow error in SignedAmount; 8e52b8ce4d8bcb7d2900a08101ea5e62c88b268a removed the BitcoinHash trait 02:46 < stevenroose> so yeah that last one is at least breaking 02:46 < stevenroose> elichai2: I would welcome that :) 02:46 < stevenroose> Ok yeah those are the 3 significant changes I could find since v0.23 02:50 < elichai2> This is what I remembered! https://github.com/rust-dev-tools/rust-semverver 03:03 -!- Jaida71Hettinger [~Jaida71He@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 03:26 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 03:53 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 03:57 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 04:03 -!- reallll is now known as belcher 05:30 -!- drolmer_ is now known as drolmer 05:41 < stevenroose> Just release the bip39 crate v1.0.0-rc1. Please try to use it and report any inconveniences. Probably will be rc1 for a while while waiting for feedback. I'm gonna try to replace the rust-wallet bip39 implementation with that one as well. 05:42 < stevenroose> andytoshi, BlueMatt, whomever else has permissions to do that, would it be possible to move the repo under the rust-bitcoin org then? I think there's at least two more people in here that have looked at the implemetnation that could help review changes from now on. 05:43 < stevenroose> (It's v1.0.0-rc1 because it used to be a crate by Stephen Oliver but he abandoned the project since but there might be people using the 0.X releases still.) 05:44 < stevenroose> elichai2: that semverer looks amazing! I wonder if it takes MSRV into account :) 05:48 < elichai2> yeah it's pretty awesome, but it has a big bug :/ https://github.com/rust-dev-tools/rust-semverver/issues/41 10:07 < BlueMatt> stevenroose: wait, which repo? 10:07 < BlueMatt> stevenroose: re: bootstrap: do you mean core? You dont need anywhere near 120GB, but you will download way more 10:07 < BlueMatt> you want the -prune=X MB option 10:08 < BlueMatt> elichai2: last i heard libfuzzer needed nightly rust cause it relies on llvm integration stuff, but honggfuzz does not. honggfuzz seems fine, mostly its wayyyy friendlier to work with (native multithreading, run and shows you a nice gui, it Just Works, unlike libfuzzer, etc). but libfuzzer has eg the failure-case-minimization tool, which can be really useful. 10:59 -!- shesek [~shesek@5.22.128.126] has quit [Read error: Connection reset by peer] 12:20 -!- Jaida71Hettinger [~Jaida71He@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 23:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 23:31 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 258 seconds] 23:33 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin --- Log closed Thu Jul 23 00:00:27 2020