--- Log opened Thu Sep 10 00:00:14 2020
00:28 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds]
00:28 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
00:32 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
01:31 -!- reallll is now known as belcher
01:56 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #rust-bitcoin
02:58 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 258 seconds]
03:18 -!- Darron55Mitchell [~Darron55M@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
05:09 < dr-orlovsky> adytoshi, elichai2, sgeisler, shesek, sanket1729: fyi, over last days I've opened a number of PSBT-related PRs, and summarized the current state of all opened PSBT-related PRs in this issue: https://github.com/rust-bitcoin/rust-bitcoin/issues/473
05:10 < dr-orlovsky> andytoshi: ^^^ (sorry, misspelled your nick originally)
05:13 -!- Darron55Mitchell [~Darron55M@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 258 seconds]
05:20 < andytoshi> great thanks
05:42 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
06:03 < andytoshi> elichai2: could you take a look at https://github.com/rust-bitcoin/rust-bitcoin/pull/387
06:03 < andytoshi> also btw what timezone are you in? utc+3?
06:06 < elichai2> andytoshi: yeah
06:06 < andytoshi> lol i wish our history was a bit more linear, since 0.23.0 at one point we had 6 parallel branches which eventually got merged together
06:07 < andytoshi> looks like after #399 got merged everybody sorta built off of that
06:11 < elichai2> andytoshi: anything specific happening that you looked at the commit history / linearity?
06:29 < andytoshi> no, i'm just trying to make a changelog
06:35 < andytoshi> ok. i'm having some travis trouble now, emailed support because i still can't restart PRs
06:35 < andytoshi> this is fucking stupid though, we shuold just drop travis. we've done this in rust-simplicity and it's fine
06:36 < andytoshi> err rust-minsicript
06:36 < andytoshi> https://github.com/rust-bitcoin/rust-miniscript/pull/125
06:37 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
06:49 < andytoshi> ok i'm back into travis
06:54 < dr-orlovsky> I'm using GitHub CI with my other rust projects and it works well
06:54 < dr-orlovsky> travis is pain
06:59 < andytoshi> lol jeez we literally went 8 months without a release
07:01 < andytoshi> stuff like sighashcache is from january .. oh man
07:02 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
07:11 < andytoshi> lol where is PR #439
07:15 < elichai2> andytoshi: I'd support moving to github CI, but I don't know how to read their yml files yet
07:15 < andytoshi> looks like it was subsumed into #429 ... but i don't see 429 in my git history
07:17 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/429/commits was merged but those commits are not ancestors of origin/master :/
07:19 < elichai2> wat
07:23 < andytoshi> the merge-base for #429's commits and master is 8a40c7b (which is the merge commit for #432)
07:23 < andytoshi> everything up to, and including, #432, looks sane
07:24 < andytoshi> but then on top of 432 I see 9cb5d2e which git tells me is the same as upstream-pull/439/head *and* upstream-pull/438/head ... but github shows 404s for both #438 and #439
07:25 < andytoshi> this commit 9cb5d2e seems to be the same as d572326 "Link type in rustdoc" from https://github.com/rust-bitcoin/rust-bitcoin/pull/429 except that it has a different id
07:27 < andytoshi> ok this looks like github is just broken
07:28 < andytoshi> in https://github.com/rust-bitcoin/rust-bitcoin/pull/429 the merge commit is clearly  9cb5d2e  (see the " sgeisler merged commit " message near the bottom), which is true
07:28 < andytoshi> but this commit, and master, is not actually connected to either of the commits in the "Commits" tab
07:53 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
07:53 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
08:12 -!- fiatjaf [~fiatjaf@2804:7f2:2a83:c857:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 272 seconds]
08:14 -!- fiatjaf [~fiatjaf@2804:7f2:2985:8437:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
09:12 -!- fiatjaf [~fiatjaf@2804:7f2:2985:8437:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
09:14 -!- fiatjaf [~fiatjaf@2804:7f2:2a85:a36c:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
09:23 < andytoshi> elichai2: could you ack https://github.com/rust-bitcoin/rust-bitcoin/pull/464
09:25 < elichai2> andytoshi: I don't think I understand it
09:25 < elichai2> why do we need to deviate from core?
09:29 < BlueMatt> elichai2: the value in core isn't really the minimum - its compared to new difficulties, but then if we use it as minimum its converted to compact encoding and back for the "real minimum"
09:29 < BlueMatt> so the value is confusing - in core it isn't a public api so who cares, but cloudhead was confused on irc here because they were trying to use it as a "real value"
09:30 < BlueMatt> its definitely....a nontrivial review, tho
09:31 < elichai2> oh I got it. I think they should really understand that difficulty should *always* go through compact bits before really used...
09:32 < elichai2> so that they won't also calculate the difficulty on the fly and use that directly too
09:32 < elichai2> (why the hell does bitcoin even have compact bits?)
09:34 < andytoshi> lol
09:34 < andytoshi> it comes from openssl
09:37 < elichai2> but why, why is it even in the block header, does it even serve any purpose?
09:40 < elichai2> andytoshi: anyway I verified and approved if you want to merge, but idk how I feel about this
09:42 < andytoshi> yeah i'm a little conflicted too. we've gone ahead and changed `u64`s to `i64`s in a bunch of places to match Core
09:42 < andytoshi> in places that were similarly consesnus-invisible, and which had the effect of making our library worse
09:42 < andytoshi> and this feels like doing the opposite
09:43 < andytoshi> but also .. this is a pretty obscure constant
09:43 < elichai2> yep. I'm also afraid that someone that fails here will also fail in verifying future blocks by calculating the difficulty on the fly and not losing bits to precision
09:43 < andytoshi> well you'll notice that immediately
09:43 < BlueMatt> right, well it *did* manage to confuse a user (who, iirc was trying to validate the genesis block)
09:44 < BlueMatt> so it at minimum needs a good docs cleanup
09:44 < BlueMatt> whether we want to change the constant....I definitely aggree its more than a little awkward and unclear what the "right" answer is.
09:44 < andytoshi> i'm gonna go ahead and merge it for now
09:44 < andytoshi> and we can revisit
09:47 < andytoshi> i'm also not gonna put this in the changelog
09:48 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/475 ← version bump
09:48 < andytoshi> BlueMatt: stevenroose: elichai2:
09:50 < BlueMatt> kool.
09:50 < andytoshi> lol, two acts within 2 minutes
09:50 < andytoshi> may be a record
09:50 < BlueMatt> hah
09:53 < andytoshi> i dunno why i'm waiting for travis, we know it's gonna fail and i'm just gonna merge anyway..
09:53 < andytoshi> process
09:56 < elichai2> hehe, fwiw it should be fixed tomorrow
09:56 < BlueMatt> why are we blowing up on nightly?
09:56 < BlueMatt> also, is there an option for travis to say "this job is allowed to fail"?
09:56 < elichai2> https://github.com/rust-lang/rust/issues/76520
09:57 < elichai2> which was hopefully fixed here a few hours ago: https://github.com/rust-lang/rust/commit/193503eb62aba269b505b99dc1c143645a115e31
09:57 < andytoshi> i've been fuzzing manually with a working nightly for all the PRs i've reviewed
09:58 < andytoshi> lol https://travis-ci.org/github/rust-bitcoin/rust-bitcoin/builds/726002273 is not even running
10:34 < elichai2> BlueMatt: and yeah, there's something like `allow_failure: true`
10:38 < sanket1729> If breaking nightly is an issue, how about temporarily freezing it to a older version in travis? Or is that too bad.
10:42 < andytoshi> eh, we'll see if it persists
10:42 < andytoshi> we think it'll be fine in a day or so
10:47 < andytoshi> lol fucking cc broke on 1.22
10:49 < andytoshi> i'm a little confused as to what we're seeing here https://travis-ci.org/github/rust-bitcoin/rust-bitcoin/jobs/726002277
10:50 < andytoshi> ohh right we removed the cc pin in rust-secp
10:50 < andytoshi> and told users they had to figure their own shit out
10:55 < andytoshi> ok added https://github.com/rust-bitcoin/rust-bitcoin/pull/475/commits/0eef6d6eee56cdcf1df914fa034c63db1c6aaa0e to fix
10:55 -!- Marion84Fritsch [~Marion84F@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
11:54 < andytoshi> ugh i hate this PR so much
11:54 < andytoshi> why is travis so finicky and slow
11:54 < BlueMatt> github ci seems to be marginally better
11:54 < BlueMatt> i mean not great
11:54 < BlueMatt> but...
12:02 < andytoshi> ok it passed
12:02 < andytoshi> squashed/updated PR
12:02 < andytoshi> will need new acks i think
12:02 < andytoshi> BlueMatt: elichai2: stevenroose:
12:27 < BlueMatt> andytoshi: done :)
12:56 < BlueMatt> (and only serde failed on travis, so good to go andytoshi)
12:58 < andytoshi> lol dope
12:58 < andytoshi> merging now
12:58 < andytoshi> publishing ... then will psuh tag .. then we have another one to do
12:58 < andytoshi> where we bump the msrv
12:58 < BlueMatt> :100:
13:06 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/476
13:15 < andytoshi> may have to wait for tomorrow to publish
13:15 < andytoshi> i don't know if anyone else in the us has approval rights
13:16 < BlueMatt> heh, oh well. I'll just bump RL to 0.24, not like it matters.
13:16 < andytoshi> and even here it's getting a bit late
13:25 < BlueMatt> lol latest rustc warns you that you have unused mut's......that old rustc refuses to compile without
13:26 < andytoshi> lol jeez
13:26 < andytoshi> in rust-bitcoin?
13:26 < BlueMatt> in rust-lightning
13:26 < andytoshi> kk
13:27 < BlueMatt> its cause old rustc is too stupid to realize the calling a macro in another file that calls RefCell::borrow_mut() doesn't, in fact, require mut.
13:29 -!- Marion84Fritsch [~Marion84F@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection]
13:31 -!- Margaret5Waelchi [~Margaret5@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
13:37 < sanket1729> github CI is ~2x faster than travis.
13:41 < sanket1729> Our test times for rust-miniscript went from 22min to 8mins. A pretty big gain IMO.
13:42 < sanket1729> rust-lang/rust also shifted to github actions for performance reasons.
14:44 -!- Margaret5Waelchi [~Margaret5@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 258 seconds]
14:58 < sgeisler> andytoshi: not in the US but I approved #476 :P
15:13 < elichai2> I hate signal
15:14 < elichai2> andytoshi: acked
15:15 < elichai2> I wiped my phone, and signal was on my us number
15:15  * elichai2 sigh 
15:33 < midnight> elichai2: It's possible to migrate signal history now, but not port it to a new number.
18:04 < ariard> BlueMatt: feel free to merge C/C++ bindings, I'm so far behind on this. I'll have a look post-merge I guess :p
18:30 < BlueMatt> ariard: heh, well its also a slow-burn kinda thing - its not intended to be used directly (really), and it'll get more testing and possibly tweaking as we build out bindings for various languages
19:07 < BlueMatt> ariard: lol sorry its gonna require a trivial rebase against 633
23:03 < sanket1729> I think the build is fixed in the latest nightly.
--- Log closed Fri Sep 11 00:00:15 2020