--- Log opened Thu Oct 01 00:00:34 2020 00:25 -!- cloudhead [~cloudhead@li1811-8.members.linode.com] has quit [Quit: WeeChat 2.8] 00:25 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has joined #rust-bitcoin 00:45 -!- jonatack [~jon@37.164.132.126] has joined #rust-bitcoin 01:00 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #rust-bitcoin 01:07 -!- Aleru [sid403553@gateway/web/irccloud.com/x-yujxdzfveoxjwazt] has joined #rust-bitcoin 01:07 -!- felixweis [sid154231@gateway/web/irccloud.com/x-krefugjevbfmhthz] has joined #rust-bitcoin 01:07 -!- fjahr [sid374480@gateway/web/irccloud.com/x-rbbwbtbigjvdlmkh] has joined #rust-bitcoin 01:24 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has quit [Quit: WeeChat 2.8] 01:24 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has joined #rust-bitcoin 01:25 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has quit [Client Quit] 01:26 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has joined #rust-bitcoin 01:32 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 01:34 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 01:52 -!- Netsplit *.net <-> *.split quits: fjahr, Aleru, felixweis 02:10 -!- Netsplit over, joins: Aleru, felixweis, fjahr 03:15 -!- jonatack [~jon@37.164.132.126] has quit [Ping timeout: 260 seconds] 03:20 -!- Pasquale30Robel [~Pasquale3@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 04:34 < andytoshi> hi tibo, sure, let me look into this 04:36 < andytoshi> so, as a first annoying comment, i'd like you to replace schnorr everywhere with bip340 :P 04:38 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 04:41 < tibo> Haha ok no problem that's not too difficult :). I'll do that tomorrow. 04:44 -!- Pasquale30Robel [~Pasquale3@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 04:58 < andytoshi> tibo: also +1 to having a separate privkey type 04:58 < andytoshi> other than that this looks great :) 05:00 < tibo> Awesome thanks a lot for the review! 05:02 -!- tibo [~tibo@2400:4050:2a83:7000:4821:e7a:d939:17b8] has quit [Remote host closed the connection] 05:02 -!- tibo [~tibo@2400:4050:2a83:7000:4821:e7a:d939:17b8] has joined #rust-bitcoin 05:03 -!- tibo [~tibo@2400:4050:2a83:7000:4821:e7a:d939:17b8] has quit [Client Quit] 05:14 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has quit [Quit: WeeChat 2.8] 05:15 -!- cloudhead [cloudhead@2a01:7e01::f03c:91ff:fe19:352c] has joined #rust-bitcoin 05:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 09:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 09:15 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 10:07 < BlueMatt> ariard: thoughts on 649? 10:07 < BlueMatt> you happy with it? 10:13 < ariard> BlueMatt: I'm on it, Jeff just squashed 10:13 < BlueMatt> k, cool 10:13 < BlueMatt> thanks 10:31 < BlueMatt> ariard and/or valwal_: if you get a chance to review #716, that'd be nice too :p 10:33 < ariard> BlueMatt: finishing 649, then 681, then 716 :) 10:33 < BlueMatt> hah, ok :) 10:34 < ariard> you may have a look on #723 in the meanwhile 10:35 < BlueMatt> yea, i need to, its next on the list after val's pr 11:01 -!- Netsplit *.net <-> *.split quits: fjahr, Aleru, felixweis 11:07 < ariard> BlueMatt: I'm good with #649, there is still room for improvements w.r.t to TemporaryFailure. But I feel it's enough bikeshidding for now 11:08 < BlueMatt> right, i think we have some agreement to replace Result<(), temporaryfailure/permanentfailure> with just enum { updated, updateinprogress, updatefailed } 11:08 < BlueMatt> but in a followup :) 11:47 -!- Netsplit over, joins: Aleru, felixweis, fjahr 15:03 < stevenroose> I redid justinmoon's PR to make our RPC crate work with 0.20.0 and 0.20.1. Had to make a single API change: something with getaddressinfo labels 15:03 < stevenroose> https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/139 15:03 < stevenroose> (s/redid/built upon/) 15:03 < stevenroose> sgeisler: review would be welcome :) 16:55 -!- Netsplit *.net <-> *.split quits: fjahr, Aleru, felixweis 17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:01 -!- tibo [~tibo@2400:4050:2a83:7000:9aa:b5ef:ed04:e7d3] has joined #rust-bitcoin 17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 17:05 -!- Netsplit over, joins: Aleru, felixweis, fjahr 17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 19:33 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin 19:33 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 19:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 20:21 -!- Netsplit *.net <-> *.split quits: fjahr, Aleru, felixweis 20:49 -!- Netsplit over, joins: Aleru, felixweis, fjahr 21:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 22:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 22:19 < tibo> andytoshi: I think I addressed your comments, and summarized the changes here: https://github.com/rust-bitcoin/rust-secp256k1/pull/237#issuecomment-702530022 Let me know if you see some issues. --- Log closed Fri Oct 02 00:00:35 2020