--- Log opened Fri Oct 02 00:00:35 2020
01:13 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
01:35 -!- Ed0 [~edouard@2001:41d0:401:3100::4897] has joined #rust-bitcoin
01:51 -!- jonatack [~jon@37.170.2.30] has joined #rust-bitcoin
03:16 -!- jonatack [~jon@37.170.2.30] has quit [Ping timeout: 256 seconds]
03:18 -!- Cydney5Kris [~Cydney5Kr@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
04:03 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-qpjljywbagpaubig] has quit [Quit: Connection closed for inactivity]
04:32 < andytoshi> cool, thanks!
04:33 < andytoshi> couple minor things -- i suggest you share the secretkey code by using `include!` rather than `macro_rules!` and since you've got this hex-serde macro anyway, it would be good to use it on `bip340::Signature` as well as public key
04:37 -!- Cydney5Kris [~Cydney5Kr@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 258 seconds]
04:37 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
04:42 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 258 seconds]
04:43 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
05:16 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 260 seconds]
05:30 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin
06:08 < tibo> Done! See comments here: https://github.com/rust-bitcoin/rust-secp256k1/pull/237#issuecomment-702723272 The `include!` trick is really nice :)
06:09 < andytoshi> ~thanks :)
06:10 -!- tibo [~tibo@2400:4050:2a83:7000:9aa:b5ef:ed04:e7d3] has quit [Remote host closed the connection]
06:15 < andytoshi> kicked travis, the nightly run passed this time
07:27 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-eysniablynhxahzf] has quit [Ping timeout: 244 seconds]
07:29 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-ozfnzneohxmctmcx] has joined #rust-bitcoin
07:32 -!- sgeisler [sid356034@gateway/web/irccloud.com/x-yqohwunudjlllidy] has quit [Ping timeout: 244 seconds]
07:34 -!- sgeisler [sid356034@gateway/web/irccloud.com/x-bdqmskrugramvupb] has joined #rust-bitcoin
07:40 -!- Netsplit *.net <-> *.split quits: fjahr, Aleru, felixweis
07:41 -!- Netsplit over, joins: Aleru, felixweis, fjahr
07:46 -!- fjahr [sid374480@gateway/web/irccloud.com/x-rbbwbtbigjvdlmkh] has quit [Ping timeout: 244 seconds]
07:47 -!- Aleru [sid403553@gateway/web/irccloud.com/x-yujxdzfveoxjwazt] has quit [Ping timeout: 244 seconds]
07:49 -!- fjahr [sid374480@gateway/web/irccloud.com/x-aziopllegdxggubc] has joined #rust-bitcoin
07:50 -!- Aleru [sid403553@gateway/web/irccloud.com/x-keznkmdiyphtgnhl] has joined #rust-bitcoin
07:50 -!- felixweis [sid154231@gateway/web/irccloud.com/x-krefugjevbfmhthz] has quit [Ping timeout: 244 seconds]
07:53 -!- felixweis [sid154231@gateway/web/irccloud.com/x-obqpsjwlqqjjaomn] has joined #rust-bitcoin
09:21 -!- vindard [~vindard@190.83.165.233] has quit [Remote host closed the connection]
09:24 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin
09:28 -!- vindard [~vindard@190.83.165.233] has quit [Read error: Connection reset by peer]
09:29 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin
11:36 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has quit [Quit: leaving]
12:01 -!- vindard [~vindard@190.83.165.233] has quit [Quit: No Ping reply in 180 seconds.]
12:05 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:00 < ariard> BlueMatt: around? I'm looking on #716 how do you come up with 253 ?
17:01 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:01 < ariard> I know this is the value used by other implems but looking directly on Core code it looks like 250 should work
17:03 < ariard> BlueMatt: both formulas which matters are GetVirtualTransactionSize() defined by (nWeight + WITNESS_SCALE_FACTOR - 1) / WITNESS_SCALE_FACTOR
17:04 < ariard> BlueMatt: and CFeeRate::GetFee defined by nFee = nSatoshiPerK * nSize / 1000
17:05 < ariard> so let's your transaction weight is 1000, your size will be (1000 + 4 - 1) / 4
17:06 < ariard> using a *feerate_per_kw* of 250 you have a fee of 250 sat
17:07 < ariard> and a minimalRelayFee as-computed-by-Core of 1000 * 250 / 1000, which gives you also 250 ?
17:08 < ariard> and in CheckFeeRate the check is strictly inferior := package_fee < ::minRelayTxFee.GetFee(package_size)
17:08 < ariard> BlueMatt: am I missing something here ?
18:26 < ariard> BlueMatt: I'll address #575/#653 hopefully this we, #681 sounds pretty mature
20:14 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds]
22:16 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
22:17 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #rust-bitcoin
--- Log closed Sat Oct 03 00:00:36 2020