--- Log opened Fri Oct 09 00:00:41 2020
00:30 -!- jonatack [~jon@37.171.174.75] has joined #rust-bitcoin
00:34 -!- jonatack [~jon@37.171.174.75] has quit [Ping timeout: 256 seconds]
00:35 -!- jonatack [~jon@213.152.162.99] has joined #rust-bitcoin
01:54 -!- fiatjaf [~fiatjaf@179.180.231.131] has quit [Ping timeout: 256 seconds]
02:00 -!- ulrichard [~richi@pub082136099022.dh-hfc.datazug.ch] has quit [Read error: Connection reset by peer]
02:15 -!- ulrichard [~richi@pub082136099022.dh-hfc.datazug.ch] has joined #rust-bitcoin
03:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
03:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
03:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
04:02 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-vplinyxrydvtbhrg] has quit [Quit: killed]
04:09 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-oeomhefeyifncioi] has joined #rust-bitcoin
04:26 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-ogkmcpitqoumbxfo] has joined #rust-bitcoin
04:30 -!- jonatack [~jon@213.152.162.99] has quit [Ping timeout: 258 seconds]
04:34 -!- Netsplit *.net <-> *.split quits: jeremyrubin, sgeisler, ulrichard
04:34 -!- sgeisler [sid356034@gateway/web/irccloud.com/x-hufxcxkokofqrotu] has joined #rust-bitcoin
04:40 -!- ulrichard [~richi@pub082136099022.dh-hfc.datazug.ch] has joined #rust-bitcoin
04:40 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin
05:18 -!- Madyson62Mitchel [~Madyson62@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
05:31 < andytoshi> jeremyrubin: yeah, sure
05:31 < andytoshi> i have a few nits but i don't mind adding this, it's an optional dp and pretty lightweight
05:32 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
06:14 -!- tibo_ [~tibo@2400:4050:2a83:7000:b5bc:8479:32f7:3221] has quit [Remote host closed the connection]
06:15 < andytoshi> stevenroose: can you review/ack https://github.com/rust-bitcoin/rust-bitcoin/pull/485 ? we can get this into a minor rev
06:17 < andytoshi> ariard: we could also get https://github.com/rust-bitcoin/rust-bitcoin/pull/420 in .. it looks like there are some open comments from steven?
06:18 < sanket1729> I think https://github.com/rust-bitcoin/rust-bitcoin/pull/478 is ready for another review. But that would be breaking change..
06:19 -!- tibo [~tibo@2400:4050:2a83:7000:650a:54cd:b48e:a30f] has joined #rust-bitcoin
06:23 < sgeisler> andytoshi: Reviewed and ACKed #485
06:24 < andytoshi> yeah sanket1729  we have to do a major rev of rust-bitcoin at some point soon
06:24 < andytoshi> sgeisler: thanks!!
06:25 < andytoshi> sanket1729: so i realize we fucked up the secp-sys linking situation
06:25 < andytoshi> both secp-sys 0.2.0 and 0.3.0 have "link = "rust_secp256k1_0_2_0"" in them
06:25 < andytoshi> which means that cargo won't build both simultaneous
06:26 -!- tibo [~tibo@2400:4050:2a83:7000:650a:54cd:b48e:a30f] has quit [Remote host closed the connection]
06:28 < andytoshi> gonna try to get tibo to fix this as part of https://github.com/rust-bitcoin/rust-secp256k1/pull/237 then i'll do a quick release of secp-sys 0.3.1 which should fix it
06:31 < andytoshi> updated https://github.com/rust-bitcoin/rust-bitcoin/pull/491 (0.25.1 for rust-bitcoin) ... imo this is good to go and we should try to get it in today. but i need two reviewers
07:00 < dr-orlovsky> andytoshi: FYI it's not a minor release anymore: API got broken b/c SigHash serializaiton after #485 now returns `Result`
07:02 < dr-orlovsky> also, master does not compule on rust 1.22 anymore https://github.com/rust-bitcoin/rust-miniscript/pull/153/checks?check_run_id=1231676278
07:03 < dr-orlovsky> while 0.25 was compiling w/o problems: https://github.com/rust-bitcoin/rust-miniscript/pull/152/checks?check_run_id=1231410602
07:05 -!- Madyson62Mitchel [~Madyson62@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
07:14 < stevenroose> andytoshi: so someone did a 0.3.0 release without using the symbol script :| I thought that was quite well specified in some readme or contributing document, no?
07:15 < andytoshi> dr-orlovsky: it does not
07:16 < andytoshi> there is a new function which returns a Result
07:16 < andytoshi> the old one unwraps internally
07:17 < andytoshi> dr-orlovsky: bitcoin 0.25 doesn't compile on 1.22 ... not sure why miniscript is depending on bitcoin 0.25
07:18 < dr-orlovsky> it's not. But when you do a version upgrade you will see that it compiles on 0.25 with 1.22 and does not with "0.25.1". I just gave those logs as a proof of that, it has nothing to do with miniscript, just an example
07:19 < dr-orlovsky> > there is a new function which returns a Result
07:19 < andytoshi> ??
07:19 < dr-orlovsky> old function also changed its return type
07:19 < andytoshi> oh jeez
07:19 < andytoshi> thanks dr-orlovsky
07:20 < andytoshi> will do a followup PR
07:20 < dr-orlovsky> no probs, happy to find it before the release was made
07:20 < andytoshi> dr-orlovsky: but i still don't understand what your comment about 0.25 vs 0.25.1 is ... the MSRV for both is 1.29
07:20 < andytoshi> are you just saying that in practice, 0.25.0 compiles with 1.22?
07:21 < dr-orlovsky> yes, as far as I see from miniscript GitHub actions
07:22 < stevenroose> andytoshi: https://github.com/rust-bitcoin/rust-bitcoin/pull/493 for reverting the sighash signatures
07:23 < andytoshi> lol stevenroose you beat me
07:23 < andytoshi> dr-orlovsky: i'm confused as to why github actions are ever trying to compile bitcoin 0.25.0 with 1.22
07:23 < dr-orlovsky> stevenroose: commented there
07:24 < dr-orlovsky> andytoshi: because I changed bitcoin version in my branch (https://github.com/rust-bitcoin/rust-miniscript/pull/152) but have not updated GitHub actions...
07:24 < andytoshi> oh lol ok
07:25 < andytoshi> everything makes sense now :)
07:25 < dr-orlovsky> sorry I am completelly lost with this diversity across MSRV between recent/new releases of whole set of rust-bitcoin crates
07:25 < stevenroose> andytoshi: I've been thinking about if consensus_encode should return Result<T, io::Error> instead of Result<T, encode::Error>
07:26 < andytoshi> dr-orlovsky: the latest major rev of rus-bitcoin and rust-secp has MSRV 1.29
07:26 < stevenroose> I really don't think encoders should be allowed to produce errors
07:26 < stevenroose> Let me check if that ever happens
07:26 < andytoshi> the previous major rev has MSRV 1.22
07:26 < andytoshi> stevenroose: i think there are a couple places where we return non-io errors on encoding
07:26 < andytoshi> maybe not?
07:26 < dr-orlovsky> but I thought miniscript v2.0.0 already upgraded...
07:27 < andytoshi> dr-orlovsky: no, the Cargo.toml has bitcoin 0.24
07:27 < dr-orlovsky> stevenroose: I think the reason for custom error type is that decoders can produce non-IO errors, so encoders just use the same error type as decoders for consistency (but it's not required of course)
07:30 < dr-orlovsky> but for the most time encoders encode into arrays, and it's really wired that they can error. For instance, `consensus::encode::serialize()` should probably just panic and never error: the only reason for it to fail is the lack of memory, meaning that the app will terminate/panic anyway. This will remove the need for plenty of expect/unwraps and replace them with just a single one in the fn itself
07:32 < stevenroose> dr-orlovsky: encode::serialize() doesn't return an error.
07:33 < stevenroose> precisely because it serialized to a Vec<u8>
07:34 < andytoshi> lol
07:34 < andytoshi> in that case it seems we've assumed pretty heavily that the only kind of encoding errors are io::Errors
07:35 < andytoshi> and we've made this assumption for many years
07:35 < andytoshi> so probably you are right stevenroose we should change the method signature
07:47 < stevenroose> literally the only violation was `CommandString` being allowed to hold any string of any size. So I changed that to have an invariant and deprecated the From traits
07:47 < andytoshi> nice
07:47 < andytoshi> we should probably do this in a separate major rev from everything else
07:48 < andytoshi> because it's gonna be super tedious/annoying for people to change their method signatures everywhere :P
08:00 < andytoshi> stevenroose: re rust-secp ... it was my fault
08:01 < andytoshi> i updated secp-sys for the MSRV bump
08:01 < andytoshi> which had no code changes, so i forgot to change the link symbols
08:01 < stevenroose> andytoshi: https://github.com/rust-bitcoin/rust-bitcoin/pull/494
08:01 < andytoshi> nice :)
08:02 < andytoshi> so, an alternate strategy migth be to let the encoder choose the error type, like serde does
08:02 < andytoshi> oh no
08:02 < andytoshi> that would be suuper invasive, we'd have to bring back our Encoder traits etc
08:03 < andytoshi> rather than just using io::Write
08:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
08:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
09:36 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
09:36 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
09:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
10:00 -!- rloomba [~rloomba@2601:646:100:3410:cd39:8e01:a09d:399f] has joined #rust-bitcoin
11:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
11:04 -!- jonatack [~jon@213.152.162.15] has joined #rust-bitcoin
12:29 < jeremyrubin> interesting failure on the wasm build of bitcoin_hashes
12:29 < jeremyrubin> https://travis-ci.org/github/rust-bitcoin/bitcoin_hashes/jobs/734384741
12:29 < jeremyrubin> Error: failed to download from https://github.com/WebAssembly/binaryen/releases/download/version_90/binaryen-version_90-x86-linux.tar.gz
12:43 -!- rloomba [~rloomba@2601:646:100:3410:cd39:8e01:a09d:399f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:45 -!- ulrichard [~richi@pub082136099022.dh-hfc.datazug.ch] has quit [Remote host closed the connection]
12:46 -!- rloomba [~rloomba@2601:646:100:3410:cd39:8e01:a09d:399f] has joined #rust-bitcoin
14:47 -!- rloomba [~rloomba@2601:646:100:3410:cd39:8e01:a09d:399f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
14:48 -!- rloomba [~rloomba@2601:646:100:3410:cd39:8e01:a09d:399f] has joined #rust-bitcoin
16:13 -!- rloomba [~rloomba@2601:646:100:3410:cd39:8e01:a09d:399f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:11 < jeremyrubin> andytoshi:  I think this is a bug https://github.com/rust-bitcoin/rust-secp256k1/blob/4b740911c663edb2507f73e86dd92edce0f22935/src/macros.rs#L70
17:11 < jeremyrubin> Should it not be $t::from_str?
17:12 < jeremyrubin> Ah I guess we only use it on secret key.
23:48 -!- b10c_ [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Quit: leaving]
23:48 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #rust-bitcoin
23:49 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Client Quit]
--- Log closed Sat Oct 10 00:00:42 2020