--- Log opened Fri Oct 16 00:00:48 2020 01:04 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 258 seconds] 01:22 -!- jonatack [~jon@109.232.227.138] has quit [Ping timeout: 260 seconds] 01:50 -!- jonatack [~jon@37.173.108.144] has joined #rust-bitcoin 02:23 -!- jonatack [~jon@37.173.108.144] has quit [Read error: Connection reset by peer] 02:23 -!- jonatack_ [~jon@37.173.108.144] has joined #rust-bitcoin 03:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:27 -!- jonatack_ [~jon@37.173.108.144] has quit [Read error: Connection reset by peer] 04:18 -!- Cordell8Sauer [~Cordell8S@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 04:41 -!- Cordell8Sauer [~Cordell8S@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 05:15 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Ping timeout: 260 seconds] 05:54 -!- tibo [~tibo@2400:4050:2a83:7000:f9:dafb:a95c:d28a] has quit [Remote host closed the connection] 08:07 < andytoshi> stevenroose: good to go on https://github.com/rust-bitcoin/bitcoin_hashes/pull/96 ? 08:09 < stevenroose> it fails on no_std I think, why did you replace ::core::hash::Hasher with ::std::hash::Hasher? 08:09 < stevenroose> andytoshi: ^ 08:37 < andytoshi> oh oops, that was a rebase error 08:37 < andytoshi> one sec 08:45 -!- jonatack [~jon@213.152.162.99] has joined #rust-bitcoin 08:48 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin 09:33 < stevenroose> andytoshi: acked 09:36 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 256 seconds] 09:36 -!- vindard [~vindard@200.7.90.175] has joined #rust-bitcoin 10:09 < andytoshi> dope. merged. publishing.. 10:09 < andytoshi> ok done. let's see if we can't get rust-bitcoin out today too.. 10:24 < dr-orlovsky> any chances of getting another approval from anyone other than andytoshi on https://github.com/rust-bitcoin/rust-bitcoin/pull/498 ? stevenroose: had concerns about it, but I tried to address all of them in the comments 10:33 < dr-orlovsky> it seems we can close both of existing two milestones https://github.com/rust-bitcoin/rust-bitcoin/milestones 10:44 -!- vindard [~vindard@200.7.90.175] has quit [Ping timeout: 256 seconds] 10:44 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 11:10 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 12:06 < andytoshi> lol oops i deleted 0.19 instead of closing it 12:07 < andytoshi> i always forget that milestones are a thing.. would've been a bit cleaner than tagging everything "api break" with the intention of reevaluating for 0.16 12:19 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 12:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 12:42 -!- vindard [~vindard@190.83.165.233] has quit [Remote host closed the connection] 13:27 < andytoshi> trying to figure out what is going on with serde versioning in 501, in the hopes that we can get that into 0.25.1 13:27 < andytoshi> but other than that i think 0.25.1 is ready to go 13:32 < andytoshi> ok, so one issue is that our dev-dependencies require serde_json < 1.0.45 but schemars requires serde_json > 1.0.58 13:33 < andytoshi> and even though it seems that schemars is optional, cargo is pulling in that version of serde_json 13:36 < andytoshi> heh, also #501 introduces things that don't compile with 1.29 directly...clippy lints etc 13:41 < andytoshi> i can't reproduce jeremyrubin issue at all .. with 1.46 everything is fine, with 1.29 i get dependency conflicts unrelated to serde 0.9 when doing `cargo test`, and with `cargo build` the actual rust-bitcoin code doesn't compile 13:43 -!- belcher_ is now known as belcher 13:44 < andytoshi> lol dammit we broke bitcoin_hashes 13:44 < andytoshi> stevenroose: are you around? we can quickly fix and release 0.9.2 13:56 < andytoshi> https://github.com/rust-bitcoin/bitcoin_hashes/pull/100 somewhat urgent 13:56 < andytoshi> elichai2: if you're around you can also ack 14:26 < BlueMatt> andytoshi: ci failed? 14:29 < andytoshi> BlueMatt: which ci? rust-bitcoin? 14:30 < andytoshi> if you ack and merge the PR i just linked i will fix it :) 14:32 < BlueMatt> no, ci on your pr 14:43 < andytoshi> lol ugh, mising docs for functions.. one sec 14:43 < andytoshi> nothing is ever a trivial change :P 14:49 < andytoshi> ok pushed, should be good now 15:30 < jeremyrubin> hi 15:31 < jeremyrubin> andytoshi: sorry for not being more exact and causing trouble 15:59 < jeremyrubin> I posted an exact repro 16:08 < jeremyrubin> [10/16/20 13:32] ok, so one issue is that our dev-dependencies require serde_json < 1.0.45 but schemars requires serde_json > 1.0.58 16:08 < jeremyrubin> https://github.com/GREsau/schemars/blob/b8c548136a20669d3f4b2a7eed3ad199bb2adb2b/schemars/Cargo.toml#L18 16:08 < jeremyrubin> Is it via some other option? Looks like any 1.0 should work 17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Sat Oct 17 00:00:49 2020