--- Log opened Sun Oct 18 00:00:50 2020
00:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds]
01:09 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
01:18 -!- jonatack [~jon@37.171.227.80] has joined #rust-bitcoin
01:32 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
01:38 -!- jonatack [~jon@37.171.227.80] has quit [Ping timeout: 258 seconds]
01:38 -!- jonatack [~jon@213.152.162.74] has joined #rust-bitcoin
02:09 -!- jonatack [~jon@213.152.162.74] has quit [Ping timeout: 260 seconds]
02:14 -!- jonatack [~jon@213.152.161.244] has joined #rust-bitcoin
03:25 -!- jonatack [~jon@213.152.161.244] has quit [Ping timeout: 240 seconds]
03:28 -!- Jedediah8Smitham [~Jedediah8@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
05:04 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:12c:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
06:18 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
07:35 < andytoshi> jeremyrubin: it's through the json-pointer dep
07:35 < andytoshi> which does require 1.0.58
09:01 < andytoshi> https://github.com/rust-bitcoin/bitcoin_hashes/pull/102 more serde_macro fixes
09:02 < andytoshi> elichai2: can you take a look at this? i tested locally  that this allows rust-bitcoin to compile with 1.29
09:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
10:20 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection]
10:21 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin
10:36 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
11:27 -!- Jedediah8Smitham [~Jedediah8@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds]
13:14 < jeremyrubin> andytoshi: it's slightly suprising to me that this compiled before without these fixes from the macros
13:24 < jeremyrubin> andytoshi: I think it can be patched somewhat easily...
13:24 < jeremyrubin> https://crates.io/crates/json-pointer/0.3.2
13:24 < jeremyrubin> you just need to force the dep from jsonschema-valid to use 0.3.2
13:24 < jeremyrubin> and then use the [patch] feature of cargo to select that one
13:34 < jeremyrubin> Also I've pinged the json-pointer team to perhaps fix their release https://gitlab.com/jmap-rs/json-pointer/-/issues/1
13:44 < jeremyrubin> Also note that jsonschema-valid is just for testing
13:44 < jeremyrubin> So one (meh) solution would be to just remove the tests for now
13:45 < jeremyrubin> unfortunately because it's a dep we can't just cfg version it :/
13:51 < jeremyrubin> Also it's a heavier dep but can switch to https://crates.io/crates/jsonschema
14:06 < andytoshi> lol i'm sure they have a reason for the version requirement
14:06 < jeremyrubin> I actually don't think so
14:07 < jeremyrubin> I think it was just "update to latest version lol"
14:07 < andytoshi> i wouldn't mind if you removed the tests, in any case.. they don't provide a ton of value
14:07 < andytoshi> ?? why would they do that in their cargo.toml
14:07 < andytoshi> `cargo update` will update to the latest version
14:07 < jeremyrubin> here's the patch
14:07 < jeremyrubin> https://gitlab.com/jmap-rs/json-pointer/-/commit/0c0ab6c8ce0fde2cd0fda2229a0c33c78080dbca
14:09 < jeremyrubin> in any case an edition bump and dep bump should probably be a bigger semver bump
14:09 < andytoshi> yes lol but we're not winning that fight
14:10 < jeremyrubin> haha who knows. it seems like a simple mistake
14:10 < andytoshi> 1.0.57 was the version that serde increased all its own deps to 1.0 versions ... would not surprise me if they did that version bump to keep everything aligned. eg having multiple versions of lazy_static in play can be dangerous probably
14:10 < jeremyrubin> perhaps
14:10 < andytoshi> i don't understand why you think requiring this very specific version was a mistake. how could somebody choose and require that version by accident?
14:11 < jeremyrubin> I'm confused at the semver implications
14:13 < jeremyrubin> I don't think requiring this version is a mistake
14:13 < jeremyrubin> but I do think that there is a semver mistake somewhere
14:13 < jeremyrubin> perhaps it's originating with serde if 1.0.57 is incompatible in some big way?
14:15 < jeremyrubin> Ah also
14:16 < jeremyrubin> 1.0.57 happens to just be the latest version of serde_json available when they did they version bump
14:16 < jeremyrubin> so maybe they just wanted to 'bump min to latest'
14:16 < jeremyrubin> https://github.com/serde-rs/json/releases
14:31 < jeremyrubin> andytoshi: you can crates.io patch json-pointer to https://github.com/JeremyRubin/json-pointer and it only requires >=1.0.25
14:32 < andytoshi> you may be right
14:32 < andytoshi> it's just not very charitable to them :P
14:35 < jeremyrubin> well to be fair
14:36 < jeremyrubin> they did need to do some bump!
14:36 < jeremyrubin> they just bumped a lot further than needed
14:37 < jeremyrubin> There was some new macro that came out that they use
14:37 < jeremyrubin> (made repo public, my bad)
14:40 < andytoshi> ah i see, yeah, that makes sense then. it is pretty annoying to bisect and figure out the minimum version that you actually required
14:41 < jeremyrubin> ponders making a cargo bisect-minimum-that-passes-tests dependency tool
14:41 < jeremyrubin> but then people would have to be aware that's what they should use
15:05 < andytoshi> the rust community already culturally rejects caring about supporting old dependencies
15:43 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:12c:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
16:32 -!- tibo [~tibo@2400:4050:2a83:7000:ad01:29c9:a326:1a84] has joined #rust-bitcoin
16:32 -!- tibo [~tibo@2400:4050:2a83:7000:ad01:29c9:a326:1a84] has quit [Remote host closed the connection]
16:32 -!- tibo [~tibo@2400:4050:2a83:7000:ad01:29c9:a326:1a84] has joined #rust-bitcoin
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:40 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:12c:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
20:41 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:12c:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 272 seconds]
21:55 -!- Eulalia50Lehner [~Eulalia50@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
22:16 -!- Eulalia50Lehner [~Eulalia50@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection]
22:18 -!- Clint11Graham [~Clint11Gr@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
22:35 -!- Clint11Graham [~Clint11Gr@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds]
--- Log closed Mon Oct 19 00:00:51 2020