--- Log opened Sat Dec 05 00:00:36 2020
03:16 -!- th0th [~th0th@gateway/tor-sasl/th0th] has quit [Remote host closed the connection]
03:21 -!- Dario28Fahey [~Dario28Fa@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
03:57 -!- wallet42___ [sid154231@gateway/web/irccloud.com/x-nsfflmahewctnkwz] has joined #rust-bitcoin
03:57 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-qugxujcnhfaqwroa] has quit [Ping timeout: 272 seconds]
03:58 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds]
03:59 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin
04:11 -!- jonatack [~jon@134.19.179.187] has quit [Ping timeout: 264 seconds]
04:15 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
04:26 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
04:27 -!- jonatack [~jon@213.152.161.149] has joined #rust-bitcoin
05:02 -!- Dario28Fahey [~Dario28Fa@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds]
05:42 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
05:42 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
05:53 < dr-orlovsky> andytoshi: fixed global PSBT keys for 1.29. The fix required adding (otherwise) unnecessary clone operation because 1.29 borrow checker is really dumb :(
05:53 < dr-orlovsky> Fixed version: https://github.com/rust-bitcoin/rust-bitcoin/pull/499
05:54 < dr-orlovsky> Regarding others PRs which will be nice to have with the new version release:
05:55 < dr-orlovsky> 1) https://github.com/rust-bitcoin/rust-bitcoin/pull/498 - very simple, but needs second ACK (andytoshi has already ACKed). sanket1729_, darosior?
05:57 < dr-orlovsky> 2) https://github.com/rust-bitcoin/rust-bitcoin/pull/513/files - very simple, changes one key type name to match the BIP spec (the rest already match)
06:20 < dr-orlovsky> 3) https://github.com/rust-bitcoin/rust-bitcoin/pull/530 - replacing all PSBT key types with constants
06:26 < dr-orlovsky> 4) https://github.com/rust-bitcoin/rust-bitcoin/pull/471/files - introduction of proprietary key type according to the BIP standard
06:28 < andytoshi> you only use derivation2 to compute this length. so why can't do you `let (fingerprint2, len2, normal_len2) = { let (fingerprint2, derivation2) = entry.get(); let len2 = derivation2.len();
06:28 < andytoshi> let normal_len2 = derivation2.into_iter().rposition(ChildNumber::is_normal);
06:28 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
06:28 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
06:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
06:29 < andytoshi> (*fingerprent2, len2, normal_len2) };
07:02 < darosior> dr-orlovsky: Will checkout #498
07:06 < darosior> Hmm so what was the rationale for this change?
07:08 < darosior> Anyways i think you should rather be looking for an ACK from stevenroose since he expressed concerns..
07:54 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin
08:00 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin
08:02 < dr-orlovsky> darosior: Thanks for looking! What I've got from stevenroose is that he neither pro or against the PR and will let others to decide. The rationale is to be able to write `fn some(impl IntoDerivationPath)` which will be accepting different types of parameters
08:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
08:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:39 -!- yancylol [~yancylol@li1543-67.members.linode.com] has joined #rust-bitcoin
08:43 -!- yancylol [~yancylol@li1543-67.members.linode.com] has quit [Ping timeout: 240 seconds]
09:31 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
11:05 -!- prusnak [sid403625@gateway/web/irccloud.com/x-lfcyzjgfjcjtebkp] has quit [Read error: Connection reset by peer]
11:05 -!- prusnak [sid403625@gateway/web/irccloud.com/x-kpjuhwlaoukjuvhi] has joined #rust-bitcoin
11:46 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin
11:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Ping timeout: 256 seconds]
12:15 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
12:36 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-krvymnjpngwletgk] has quit [Ping timeout: 246 seconds]
13:04 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-kuzwqzbpfmsdlpxj] has joined #rust-bitcoin
14:57 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
15:10 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
15:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
15:54 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
16:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #rust-bitcoin
16:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Client Quit]
16:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #rust-bitcoin
16:40 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: Textual IRC Client: www.textualapp.com]
16:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin
17:45 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #rust-bitcoin
20:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:55 -!- jonatack [~jon@213.152.161.149] has quit [Ping timeout: 246 seconds]
20:56 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
22:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@ppp-223-24-171-28.revip6.asianet.co.th] has joined #rust-bitcoin
--- Log closed Sun Dec 06 00:00:38 2020