--- Log opened Mon Dec 07 00:00:38 2020 00:15 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 256 seconds] 00:20 -!- warren [~warren@fedora/wombat/warren] has joined #rust-bitcoin 00:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 00:28 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 01:00 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 01:00 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 01:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #rust-bitcoin 01:07 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 01:08 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Ping timeout: 246 seconds] 02:07 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 02:24 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 02:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #rust-bitcoin 03:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:17 -!- Alfred50Hilpert [~Alfred50H@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection] 03:18 -!- Carlee44Effertz [~Carlee44E@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 03:27 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #rust-bitcoin 03:34 < stevenroose> andytoshi: merged 513 03:34 < stevenroose> merged 259 (elichai acked) 03:37 < stevenroose> merged 401 03:37 < stevenroose> yay we got taproot hashes! 03:38 < stevenroose> Now we can support taproot addresses, right? :) 03:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #rust-bitcoin 04:48 -!- tibo [~tibo@2400:4050:2a83:7000:d50:475b:8d28:8f3e] has quit [Remote host closed the connection] 05:07 < elichai2> stevenroose: using which bech? ;) 05:30 < stevenroose> elichai2: wait do taproot addresses use different bech? Oh I read conversations about a problem with bech with padding or something that was being fixed. Is that a holdup for taproot addresses? 05:31 < elichai2> there was a new email today I think by sipa & gmaxwell 05:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:21 < andytoshi> stevenroose: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2020-December/018292.html 06:22 < andytoshi> there will be a new bech. we should probably tighten rust-bitcoin to refuse to parse non-v0 addresses actually 06:22 < andytoshi> the new bech will be super similar to the old one, just one constant will change 06:22 < andytoshi> sipa said he'd write a bip in the next couple days, we'll wait for that i guess 06:28 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/249 (compactblocks) could use a rebase and update to remove the impl Error{} contents 06:28 < andytoshi> though i dunno if it'll get in, there's not a lot of enthusiasm for some reason 06:28 < andytoshi> dpc: https://github.com/rust-bitcoin/rust-bitcoin/pull/404 is a doc-only change which needs to be updated 06:30 < andytoshi> need second review on https://github.com/rust-bitcoin/rust-bitcoin/pull/529 06:31 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/471 looks like it needs a rebase dr-orlovsky 06:31 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/530 also needs rebase dr-orlovsky 06:32 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/514 needs second review (steven's PR to add net::ToSocketAddrs to address messages) 06:32 < dr-orlovsky> ok, working on that! 06:34 -!- Carlee44Effertz [~Carlee44E@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 06:38 < dr-orlovsky> https://github.com/rust-bitcoin/rust-bitcoin/pull/530 is ready for the review (rebased) 06:39 < stevenroose> andytoshi, justinmoon, the u64 vs u32 nit: I feel like we usually use u64 to represent things that become varints in teh protocol. I could try to parse it into a u32, though if you insist. that would mean parsing into u64 and trying to reduce t ou32, though. 06:39 < stevenroose> while typing this I'm thinking if we should have a generic VarInt type that can hold a from u8/i8 -> u64/i64 (or are varints unsigned?) 06:39 < stevenroose> probably unsigned 06:43 < stevenroose> rebased and updated compactblocks pr 06:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #rust-bitcoin 06:52 < dr-orlovsky> andytoshi: https://github.com/rust-bitcoin/rust-bitcoin/pull/471 is rebased and ready for review 06:57 < elichai2> andytoshi: and this new bech won't have an error for a new size/version of scriptPubKey? 😅 06:58 < andytoshi> elichai2: lol, correct 06:59 < andytoshi> stevenroose: we do have a VarInt type, it's just super annoying to use :) 07:08 < andytoshi> also unrelatedly it would be nice if we could get https://github.com/apoelstra/rust-jsonrpc/pull/34 in and do a new rust-jsonrpc release 07:09 < andytoshi> i see there are a couple nits from dpc still. maybe i should deal with those and then just merge it.. 07:28 < stevenroose> andytoshi: yeah I know about the varint type, it's just that it's always an u64 underneath. if we're parting f.e. u16's then we're always using u64 and truncating into u16. I just gave it a quick try but it's not easy to make it generic 07:29 < stevenroose> f.e. there's no u32: PartialOrd etc so you'd end up either writing 4 different impls of all traits which kinda defeats the point of the generic or converting into u64 all over the place inside trait impls which also defeats the point 07:29 < stevenroose> so giving up :D 07:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:42 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin 07:57 < andytoshi> lol yeah 08:06 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 08:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 08:13 -!- belcher_ is now known as belcher 08:45 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 08:47 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 08:55 -!- belcher_ is now known as belcher 10:22 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 10:35 < ariard> BlueMatt: I can attend ln meeting today :) 10:36 < ariard> BlueMatt: also I had a look on #736/#752, planning to review them today 10:36 < ariard> and #742 doesn't seem far from landing 10:36 < BlueMatt> ariard: thanks. I'm mostly back working today - took the end of last week off and this weekend due to some health stuff, but it seems to be resolving somewhat now, so will be working again this week. 10:37 < BlueMatt> right, I think 742 is quite close, would like to merge it soon 10:39 < BlueMatt> but it definitely needs acks 10:39 < ariard> yeah I was traveling back in france last week but I'm back to regular bandwidth for the coming week :) 10:40 < ariard> okay I'll do 742 before 752 11:08 < dr-orlovsky> elichai2, stevenroose, need a second ACK on this PR https://github.com/rust-bitcoin/rust-bitcoin/pull/530 11:42 < dr-orlovsky> stevenroose: and https://github.com/rust-bitcoin/rust-bitcoin/pull/499 pls - your requests are fulfilled, needs repeated review 13:12 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 13:27 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 14:02 -!- Netsplit *.net <-> *.split quits: midnight 14:23 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin 15:36 -!- tibo [~tibo@2400:4050:2a83:7000:e122:9649:394c:4297] has joined #rust-bitcoin 16:03 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 16:15 -!- jonatack [~jon@213.152.161.170] has quit [Quit: jonatack] 16:25 -!- b42 [~mmilata@b42.cz] has quit [Quit: WeeChat 2.7.1] 16:27 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin 18:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has joined #rust-bitcoin 18:28 < andytoshi> elichai2: i think if you ack https://github.com/rust-bitcoin/rust-secp256k1/pull/253 we can do a new rust-secp release 18:28 < andytoshi> which we could pull into a new rust-bitcoin release. that'd be the first time we did a rust-secp bump without requiring an independent rust-bitcoin version bump :) 18:46 -!- tibo_ [~tibo@2400:4050:2a83:7000:341c:56db:3c06:7e29] has joined #rust-bitcoin 18:49 -!- tibo [~tibo@2400:4050:2a83:7000:e122:9649:394c:4297] has quit [Ping timeout: 260 seconds] 20:28 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 20:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 21:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has joined #rust-bitcoin 23:22 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 23:53 -!- th0th [~th0th@gateway/tor-sasl/th0th] has quit [Remote host closed the connection] 23:54 -!- th0th [~th0th@gateway/tor-sasl/th0th] has joined #rust-bitcoin --- Log closed Tue Dec 08 00:00:39 2020