--- Log opened Wed Dec 09 00:00:42 2020 00:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:12 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 02:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin 02:37 -!- belcher_ is now known as belcher 03:09 -!- darosior9 is now known as darosior 03:10 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:03 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 04:03 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 04:09 -!- tibo [~tibo@p6114095-ipngn29701marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 04:18 -!- tibo [~tibo@2400:4050:2a83:7000:edcd:af8e:130b:a46b] has joined #rust-bitcoin 04:24 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #rust-bitcoin 04:48 -!- tibo [~tibo@2400:4050:2a83:7000:edcd:af8e:130b:a46b] has quit [Remote host closed the connection] 05:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:22 -!- tibo [~tibo@2400:4050:2a83:7000:edcd:af8e:130b:a46b] has joined #rust-bitcoin 05:26 -!- tibo [~tibo@2400:4050:2a83:7000:edcd:af8e:130b:a46b] has quit [Ping timeout: 260 seconds] 05:44 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #rust-bitcoin 08:20 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin 08:43 < andytoshi> elichai2: on the BIP340 followup rust-secp PR you suggest i take the tweak as a 32-byte array to avoid length checking 08:43 < andytoshi> but i think this doesn't really improve the ergonomics at all, becaues we still need an error return in case the user passes an invalid tweak 08:44 < elichai2> oh tweaks bigger than the curve order are bad? 08:44 < elichai2> I forgot about that 08:44 < andytoshi> yes, and also i think if you pass the negative of the discrete log of the point 08:44 < andytoshi> you'll get a zero point, which we can't serialize 08:44 < andytoshi> so we reject that as well 08:45 < elichai2> wait, but that's a "check" function which returns 0/1 no-matter the reason 08:45 < elichai2> we don't check why its failed 08:45 < andytoshi> ah i see 08:45 < andytoshi> so you'd like a bool return 08:45 < andytoshi> yeah sure 08:46 < elichai2> yeah things with *_verify / *_check I think are much easier to use when they return bools 08:46 < andytoshi> in theory this'll also be faster, which is good because the _check function is supposed to be the fast/unergonomic one 08:46 < elichai2> but that would go against the rest of the APIs which all get slices 08:47 < andytoshi> that's fine, _check methods can be special 08:49 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 08:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 08:51 < andytoshi> ok pushed 12:31 < andytoshi> elichai2: merged BIP340 followups 12:31 < andytoshi> is there anything else we should do for a new release? 12:31 < andytoshi> i see you have a zillion PRs but they all have alternates 12:32 < andytoshi> so i haven't reviewed them 12:33 < andytoshi> the impression i got last i looked at all this was that we couldn't reasonably fix the alignment footguns in rust-secp with rust 1.29 12:41 < elichai2> Hmm I think we actually can? I'm on my phone and it's been some times since those PRs, but I think 1.29 gave us a few ways to handle the alignment, but even with 1.40 there's no clean cut "amazing" solution 12:41 < andytoshi> ok, lemme take a look then 12:42 < andytoshi> the oldest one is #141 but then you also have #233 open "succeeder of #141" which does not share any commits with it 12:42 < andytoshi> so should 141 be closed? 13:16 -!- belcher_ is now known as belcher 13:21 < elichai2> Lemme look 13:23 < elichai2> andytoshi: yeah, look at #233 which also gives some explanation and differentiates between the alternatives 13:23 < andytoshi> kk 13:26 < andytoshi> interesting 13:26 < andytoshi> so #233 does look like the best of these alternatives 13:26 < andytoshi> in that the user can just provide an unaligned blob and we'll fix it 13:27 < andytoshi> at the cost of wasting 16 bytes sometimes 13:28 < andytoshi> can you rebase it? concept ACK 13:36 < andytoshi> i'm actually kinda confused about what this is doing 13:36 < andytoshi> we call alloc::alloc to get a pointer....then we add ALIGN_TO to it? what does that accomplish? 13:36 < andytoshi> oh derp never mind 13:37 < andytoshi> you are writing the length to it 13:41 < elichai2> Yeah, and we add ALIGN_TO to keep it aligned 13:41 < andytoshi> yep 13:47 < andytoshi> i guess, one nite is that we should make sure all the *_size_gen() functions are documented as returning the number of AlignType words 13:48 < andytoshi> rather than the number of bytes 14:57 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer] 14:57 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #rust-bitcoin 15:30 -!- tibo [~tibo@2400:4050:2a83:7000:1078:3ce1:26d3:ee19] has joined #rust-bitcoin 16:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin 19:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds] 19:35 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 20:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 20:59 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 21:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin 21:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Client Quit] 21:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 22:10 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-ibaprrhpcssnfiuj] has quit [Read error: Connection reset by peer] 22:10 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-iecubrfqgzplxinh] has joined #rust-bitcoin 22:11 -!- junderw [sid43070@gateway/web/irccloud.com/x-dkjvstrcgzxgftli] has quit [Ping timeout: 268 seconds] 22:11 -!- moneyball [sid299869@gateway/web/irccloud.com/x-wjkdiocnrkijgqvm] has quit [Ping timeout: 268 seconds] 22:11 -!- Galvas [sid459296@gateway/web/irccloud.com/x-xysgxmoclwsvmqxp] has quit [Read error: Connection reset by peer] 22:11 -!- Galvas [sid459296@gateway/web/irccloud.com/x-bwbwszkdaytmfgex] has joined #rust-bitcoin 22:11 -!- moneyball [sid299869@gateway/web/irccloud.com/x-rochyfnjwpmypxlr] has joined #rust-bitcoin 22:11 -!- junderw [sid43070@gateway/web/irccloud.com/x-qnoodlvfldmuqnzb] has joined #rust-bitcoin 22:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #rust-bitcoin --- Log closed Thu Dec 10 00:00:44 2020