--- Log opened Tue Dec 15 00:00:48 2020
00:33 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
01:13 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
01:14 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:40 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
02:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #rust-bitcoin
03:21 -!- Onie34Rippin [~Onie34Rip@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
03:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Ping timeout: 256 seconds]
04:38 -!- tibo [~tibo@2400:4050:2a83:7000:e869:100a:bda1:9443] has quit [Remote host closed the connection]
05:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b] has joined #rust-bitcoin
05:41 < dr-orlovsky> andytoshi: can you pls let me know who has the approval permissions for rust-bitcoin? Github does not expose the info and I do not know whom to ask the review except you and stevenroose
05:44 -!- Onie34Rippin [~Onie34Rip@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds]
06:08 -!- Kiminuo [~mix@141.98.103.172] has joined #rust-bitcoin
06:09 < stevenroose> dr-orlovsky: hmm, it's not nice that the list is not public, we should probably have a maintainers.md or something. afaik there's BlueMatt sgeisler elichai2
06:15 < dr-orlovsky> stevenroose: thank you! May I ask you and elichai2 or sgeisler to pay attention to #530 and #499, which will be really nice to have in new release and quite simple for review. They already have one ACK from andytoshi and needs the second one
06:15 < stevenroose> re-reviewing 499 atm
06:16 < dr-orlovsky> Also, there is #498 with neutral review from stevenroose (neither pro or against) and ACK by apoelstra, so if elichai2 or sgeisler may look at it as well that would be great
06:16 < dr-orlovsky> stevenroose: thank you!
06:16 < sgeisler> what are your priorities when it comes to these 3 PRs?
06:19 < stevenroose> I didn't know that the antonym of a "hardened derivation" was a "normal derivation"
06:19 < stevenroose> I thought they were just called unhardened and hardened
06:19 < stevenroose> It's a bit confusing, is that a name we made up or is that per spec?
06:20 < stevenroose> > Each extended key has 231 normal child keys, and 231 hardened child keys.
06:20 < dr-orlovsky> #499 is the most important, #530 is the simpliest one and now external API changes, #498 is the lease important (and also simpiest)
06:20 < stevenroose> hmm seems to be per spec
06:21 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b] has quit [Ping timeout: 260 seconds]
06:21 < dr-orlovsky> sgeisler: since stevenroose already reviewing #499, will appreciate if you take a look at #530
06:21 < sgeisler> Will do, sorry for being so absent, but other things had to take priority for a while
06:22 < stevenroose> dr-orlovsky: well ideally we all review most of them :) but yeah 499 just adds stuff, it's not too critical
06:30 -!- Kiminuo [~mix@141.98.103.172] has quit [Read error: Connection reset by peer]
06:32 < stevenroose> Andrew utACK'ed an old commit in 499
06:32 < stevenroose> let's make sure he reviewed up to the latest tip before we merge
06:33 < stevenroose> oh also, dr-orlovsky, CI is failing on 499
06:34 < dr-orlovsky> which is really wired since it fails only on fuzztests, and there were no changes in 499 which can make it failing. I recall there was some issue with fuzztest in master and probably a rebase/merge will make PR passing; but then it will discard all ACKs/reviews
06:36 < sgeisler> 530 looks good. Since it has 2 ACKs now (andytoshi and mine) do you want to have a look too stevenroose or should I just go ahead and merge? Is there any bookkeeping to do other than merging?
06:36 -!- Kiminuo [~mix@141.98.103.108] has joined #rust-bitcoin
06:38 < dr-orlovsky> no bookkeeping and of course I will be happy if srevenroose looked at it as well, but don't want to occupy too much of his time
06:42 < stevenroose> dr-orlovsky: I left a bunch of nits on 499 since you need to fix CI anyway
06:42 < stevenroose> sgeisler: let me look at 530
06:43 < sgeisler> It's mostly introducing some constants, I cross-checked with the BIP and it seems to make sense.
06:46 < stevenroose> sgeisler: yeah and some tiny confusion reordering them as well :p but yeah acked and merged
06:47 < sgeisler> stevenroose: nice! yeah, the reordering confused me too at first, but makes sense given the order in the BIP
06:48 < stevenroose> sgeisler: https://github.com/rust-bitcoin/rust-bitcoin/pull/516 :)
06:49 < stevenroose> also sgeisler  https://github.com/rust-bitcoin/rust-bitcoin/pull/515
06:49 < stevenroose> also https://github.com/rust-bitcoin/rust-bitcoin/pull/514/
06:50 < stevenroose> andytoshi: are we preparing for a release with API break?
06:50 < stevenroose> I have a whole bunch of MRs pending labeled with API break
07:05 < dr-orlovsky> stevenroose: addressed all nits that I could (not of them are solvable, I explained in the comments)
07:07 -!- Kiminuo [~mix@141.98.103.108] has quit [Ping timeout: 256 seconds]
07:11 < stevenroose> dr-orlovsky: no worries
07:11 < stevenroose> dr-orlovsky: also feel free to take a look at some of those above. there's also https://github.com/rust-bitcoin/rust-bitcoin/pull/494 and https://github.com/rust-bitcoin/rust-bitcoin/pull/496/
07:12 < dr-orlovsky> thanks for the invitation, I will!
07:15 < sgeisler> stevenroose: did you consider the `impl Iterator` proposal (idk if it works) in 514? I'm fine with it either way. I don't think we'll want to change the iter type without changing a lot about the address message.
07:17 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b] has joined #rust-bitcoin
07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
08:07 < andytoshi> how do people feel about giving sanket1729 approve/merge access to rust-bitcoin
08:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:20 < stevenroose> andytoshi: haven't seem him review a lot in the wild, but I think ack
08:20 < stevenroose> at some point though I think we should up the minimum number of acks, even though we're already reaching people's limits when it comes to the amount of time thye seem able to spend on review
08:36 < elichai2> stevenroose: https://github.com/rust-lang/rust/issues/63063 :(
08:36 < elichai2> andytoshi: +1 for sanket
08:39 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin
08:53 < andytoshi> stevenroose: lol yes, the next release will break the API
08:53 < andytoshi> but not all of the "API break" PRs i want in this release. some are too extreme and will need another release
08:53 < andytoshi> stevenroose: maybe when we can get 2 ACKs in less than 2 months we can up the minimium number
08:57 < stevenroose> andytoshi: hmm, what's your motivation to break the version bump in 2? is there any indication of users that really need some of the pending features but would be unable to catch up with other pending changes?
08:57 < andytoshi> yes. me.
08:58 < andytoshi> i don't want to update basically every line of the functionary code in one commit with a bunch of mechanical changes, combined with nonmechanical changes we need for more meaningful API braeks
08:58 < andytoshi> so all the "move modules around" stuff and "change error return type" stuff sdhould go in its own release
09:00 < dr-orlovsky> otherwise ppl will really need to update a lot of code when they just need to get signet/schnorr sigs/xcoordonly/taproot support
09:02 < stevenroose> hmm, they'll have to od it for the next feature they'll want. also I didn't realize we have schnorr sigs and xcoordonly support now
09:03 < stevenroose> andytoshi: our code is on v0.23, we're going to need some updating anyway :p but sure. it just makes things quite a bit harder here. shall I create labels for 0.26 and 0.27 then so that we can start trying to assign MRs (and issues)?
09:08 -!- Kiminuo [~mix@141.98.103.108] has joined #rust-bitcoin
09:22 < andytoshi> stevenroose: sure, yeah, labels would be helpful
09:23 < andytoshi> and yes, well, we can go from 0.23 to 0.30 or whatever in reviewable stages
09:23 < andytoshi> rather than having one mega 5000-line commit that changes every call into rust-bitcoin
09:32 < dr-orlovsky> stevenroose: we will have schnorrs/xcoordonly if andytoshi will release rust-secp256k1 before rust-bitcoin as he had planned :)
09:33 < dr-orlovsky> > shall I create labels for 0.26 and 0.27 then so that we can start trying to assign MRs (and issues)?
09:33 < dr-orlovsky> stevenroose: maybe milestones will work better?
09:33 < stevenroose> ah yeah that makes sense
09:36 < andytoshi> dr-orlovsky: i think rust-secp is blocked on getting one of elichai2's alignment PRs in
09:36 < andytoshi> which needed a rebase last i checkd
09:40 < dr-orlovsky> this means we will not have xcoordonly before Bitcoin Core - it will take another major version bump in rust-bitcoin which usually takes two months or so...
09:41 < dr-orlovsky> (I mean next Bitcoin Core release)
09:41 < sgeisler> I second both giving sanket approval rights and using milestones to organize PRs, this will also help guide review a bit
09:41 < andytoshi> lol dr-orlovsky we'll see how long Core takes
09:42 < elichai2> andytoshi: really? Can you tell me which one you prefer and I'll rebase that one and close the others? Or should I rebase them all? (I think real_or_random also had an opinion on that)
09:42 < elichai2> Idk if anyone else here have/want to have opinions on alignment/low-level stuff and API (maybe BlueMatt?)
09:42 < andytoshi> elichai2: 233
09:43 < andytoshi> lemme see what real_or_random had to say on 235
09:45 < dr-orlovsky> https://github.com/bitcoin/bitcoin/issues/18947 says that the planned date for Core 0.21 is the 3rd of Dec, which is behind the schedule anyway, but it's more than two weeks since RC2 already and it seems all bugfixes are merged already
09:45 < andytoshi> yeah i think that's fine, it's 235-specific
09:45 < andytoshi> dr-orlovsky: have you been following #bitcoin-core-dev lately
09:45 < dr-orlovsky> nope, will check
09:45 -!- guest534543 [~mix@141.98.103.84] has joined #rust-bitcoin
09:45 < andytoshi> i mean, it's an ongoing thing, you can try to read the last 2 weeks of logs if you want but it's a slog
09:45 < andytoshi> i'm being a bit snarky suggesting that they'll take longer than us to get a release out
09:46 < andytoshi> but currently they're fighting macos' broken codesigning tool for rc3
09:46 < andytoshi> so rc3 is delayed for a few more days at least due to that (and it should've been out a few days ago)
09:46 < andytoshi> then we need a few days to test rc3 and see if there needs to be a rc4 or not (probably not, but we'll see)
09:48 < dr-orlovsky> I see, thanks for the update on the details. Being out of reading chats and messengers unless being directly tagged - otherwise amount of code I am able to produce becomes much smaller :)
09:48 < real_or_random> andytoshi elichai2: sorry what's the context?
09:48 -!- Kiminuo [~mix@141.98.103.108] has quit [Ping timeout: 260 seconds]
09:49 < andytoshi> real_or_random: do you have any thoughts about rust-secp #233
09:49 < andytoshi> which we are proposing to merge to address the alighnment requirements for context memory
09:50 -!- Kiminuo [~mix@141.98.103.124] has joined #rust-bitcoin
09:51 < andytoshi> btw is there a unix utility that will maintain a set of commits that i've acked? or maybe let me add notes or something to it
09:53 -!- guest534543 [~mix@141.98.103.84] has quit [Ping timeout: 240 seconds]
09:55 < real_or_random> I think when I looked at this, I found #235 somewhat nicer but I believe #233 will do the job
09:56 < andytoshi> oh does 235 get rid of AlignedTYpe entirely?
09:56 < andytoshi> doesn't look like it
09:56 < andytoshi> my thought was, given that we need AlignedType no matter what, 233 is the simplest thing
09:57 < real_or_random> ah yes, so my preference was 235 without AlignedType (which is possible, see the discussion there)
09:57 < real_or_random> at least that what I was thinking back then. and then 235 is very simply, that's why I like it
10:24 < sgeisler> 529 looks good, will it upset anyone if we merge it? Seems 496 and 494 are put on hold anyway.
10:32 < andytoshi> o for it
10:32 < andytoshi> go
10:33 -!- belcher_ is now known as belcher
11:17 -!- Kiminuo [~mix@141.98.103.124] has quit [Ping timeout: 256 seconds]
12:05 -!- Kiminuo [~mix@141.98.103.124] has joined #rust-bitcoin
13:47 -!- Kiminuo [~mix@141.98.103.124] has quit [Ping timeout: 256 seconds]
14:18 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds]
14:19 -!- jonatack [~jon@213.152.162.99] has joined #rust-bitcoin
14:46 < andytoshi> sanket1729: when you get a sec can you PR to bump the rust-elements version number
15:27 -!- tibo [~tibo@2400:4050:2a83:7000:184e:478d:12cd:b4b1] has joined #rust-bitcoin
16:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b] has joined #rust-bitcoin
16:59 -!- tibo [~tibo@2400:4050:2a83:7000:184e:478d:12cd:b4b1] has quit []
17:01 -!- tibo [~tibo@2400:4050:2a83:7000:e5f8:7d38:132b:df34] has joined #rust-bitcoin
17:23 < andytoshi> stevenroose: rust-jsonrpc version bump https://github.com/apoelstra/rust-jsonrpc/pull/37
18:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
18:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
18:47 < tibo> Hi all, I have a small question. I have a script in asm format as a hex string and I'm trying to parse it to get a Script struct. Is there an easy way to do that with rust-bitcoin? I've tried both methods from Script and Builder structs but it seems like they expect the hex format.
19:06 < shesek> tibo, Script doesn't implement FromHex, but you could do `Script::from(Vec::from_hex(hex_str)?)`
19:08 < shesek> (requires `use bitcoin::hashes::hex::FromHex`)
19:09 < shesek> looks like andytoshi filed an issue for implementing FromHex for Script at https://github.com/rust-bitcoin/rust-bitcoin/issues/523
19:35 < justinmoon> belcher: coinswap implementation looking good! https://github.com/bitcoin-teleport/teleport-transactions
19:42 < sanket1729> andytoshi: done.
19:44 < tibo> shesek: Thanks for the answer. I had tried that already but this seems to parse it in hex format, not asm. For example, I have this script: `002066a4e16d1ac28a73c08f0abccc6f523c5d8790ab24ea6cf011e00f51527dee43` which is in asm format, but using `Script::from` it gets interpreted as hex format (AFAIU)
22:05 -!- jonatack [~jon@213.152.162.99] has quit [Read error: Connection reset by peer]
22:11 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
23:10 -!- Kiminuo [~mix@141.98.103.124] has joined #rust-bitcoin
23:32 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
23:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
--- Log closed Wed Dec 16 00:00:48 2020