--- Log opened Fri Dec 18 00:00:52 2020 00:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has joined #rust-bitcoin 01:44 < stevenroose> sure 01:46 < stevenroose> I have a branch that makes a ton of changes as well, though, it makes the Transport kept in the client into a Box and thus changes the trait quite a lot 01:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:11 < stevenroose> andytoshi: darosior: https://github.com/apoelstra/rust-jsonrpc/pull/39 I incorporated your changes on top of the branch I had yesterday :) 02:11 < stevenroose> I'm gonna test this again against the rust-bitcoincore-rpc integration test 02:22 < stevenroose> K the integration test works locally for me, pushed it here: https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/154 02:37 < darosior> stevenroose: testing your branch now 02:49 < elichai2> I think we no longer run secp256k1-sys tests 02:49 < elichai2> (in the CI) 03:13 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has joined #rust-bitcoin 03:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:26 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 04:26 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 04:26 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 04:28 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 04:34 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 04:35 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 04:46 -!- tibo [~tibo@2400:4050:2a83:7000:d103:1899:4473:6de1] has quit [Remote host closed the connection] 04:59 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has joined #rust-bitcoin 05:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has joined #rust-bitcoin 05:52 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 05:59 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 06:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Write error: Broken pipe] 06:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 06:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has joined #rust-bitcoin 06:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has quit [Ping timeout: 240 seconds] 06:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has joined #rust-bitcoin 07:08 < andytoshi> elichai2: oh oops, i didn't realize we had any 07:09 < andytoshi> stevenroose: lol so should i not merge 38, and just re-verify your cherry picked version? 07:31 -!- jonatack [~jon@213.152.186.173] has quit [Ping timeout: 268 seconds] 07:33 < stevenroose> yeah I think that makes more sense 07:33 < stevenroose> the cherry picks are fairly small 07:34 < stevenroose> it's the Authorization change, some extra method to add a basic_auth cookie value, and the change to get the content length 07:34 < darosior> +1 07:34 < andytoshi> cool, i'll re-review in 10-15 mins 07:34 < darosior> We can still apply the rustfmt later 07:34 < andytoshi> heh yea 07:34 < andytoshi> this is cool, i'll get to learn how to use `git cherry` 07:34 < andytoshi> or `git range-diff` 07:35 < andytoshi> or i'll just re-review lol, it's not like darosior's changes were very big 07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 08:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds] 08:01 -!- belcher_ is now known as belcher 08:17 < andytoshi> stevenroose: so right off the bat f746bdcb28c48fcac4956bd1a60b30698a6d3c91 doesn't compile 08:18 < stevenroose> uughh, really? where is that from? 08:18 < andytoshi> that's the first commit in #39 .. says error[E0437]: type `Err` is not a member of trait `Transport` --> src/client.rs:162:9 08:18 < stevenroose> oh you go per commit? k I'll squash, 08:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:19 < andytoshi> lol 08:19 < andytoshi> ok, i guess i will be re-reviewing everything then 08:19 < stevenroose> I wanted to keep history of the fixes I added after darosior's review 08:20 < stevenroose> I squashed all except darosior's cherry-picks and pushed 08:23 < andytoshi> kk thanks 08:43 < andytoshi> ok stevenroose i have a couple nits but otherwise utack 09:09 -!- yancy [~yancy@li1543-67.members.linode.com] has quit [Remote host closed the connection] 09:10 -!- yancy [~yancy@li1543-67.members.linode.com] has joined #rust-bitcoin 10:15 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #rust-bitcoin 11:00 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin 11:02 -!- kiltzman [~k1ltzman@195.189.99.96] has joined #rust-bitcoin 11:08 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds] 11:10 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin 11:28 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 272 seconds] 11:29 -!- jonatack [~jon@213.152.162.154] has joined #rust-bitcoin 14:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 15:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 15:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 16:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has joined #rust-bitcoin 16:48 -!- tibo [~tibo@2400:4050:2a83:7000:ec76:feb3:2b19:cad0] has joined #rust-bitcoin 16:52 -!- tibo [~tibo@2400:4050:2a83:7000:ec76:feb3:2b19:cad0] has quit [Ping timeout: 260 seconds] 17:16 < andytoshi> stevenroose: so, we could just not make the json params be an array 17:17 < andytoshi> it could just be a generic serde::Serialize type 17:17 < andytoshi> but this would make Transport itself not be object-safe, so we couldn't then box it 17:36 < andytoshi> hmm, it also makes it hard to do mock implementations 17:36 < andytoshi> i think we should just go back to taking a slice of json values 18:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has quit [Quit: Textual IRC Client: www.textualapp.com] 18:27 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Ping timeout: 260 seconds] 18:27 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #rust-bitcoin 20:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 23:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 23:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 23:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Sat Dec 19 00:00:51 2020