--- Log opened Sun Dec 27 00:00:57 2020
00:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
00:43 -!- jeremyrubin [~jr@2601:645:c200:14:50ab:88b7:ba06:c28f] has quit [Ping timeout: 260 seconds]
03:23 -!- Colleen42Romague [~Colleen42@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
04:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
05:03 -!- fiatjaf2 [~fiatjaf@2804:7f2:2a8b:8a99:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
05:05 -!- fiatjaf1 [~fiatjaf@186.213.86.95] has quit [Ping timeout: 264 seconds]
05:49 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has joined #rust-bitcoin
07:55 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
08:24 < stevenroose> sgeisler: any more thoughts on the serde serialization of values?
08:48 < stevenroose> sgeisler, andytoshi: I copied the BTreeMap serde impl to have a Vec<u8>-values-specific one. However, I also noticed that we have BTreeMap<hashes::any::Hash, Vec<u8>>. They don't need the special serializer because the hashtypes are already strings. But in those cases, the value is also not serialized as hex. So I think I'm just gonna make another one for that.
08:52 -!- Colleen42Romague [~Colleen42@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
09:05 < stevenroose> Also, I just gave trying to generalize this for HashMap using a trait and I can't get it to work without "error[E0658]: generic associated types are unstable" because the trait needs a `type Iter<'a> = btree_map::Iter<'a, Self::Key, Self::Value>` which is generic over the lifetime :/
09:27 < andytoshi> :/
09:28 < andytoshi> it's incredibly frustrating how limiting Rust's rules for generic types are. makes you really sympathize with the C++ "allow anything that compiles after instantiation, try to add limits later" approach
09:29 < andytoshi> but sure, as long as these things are in their own module, i'm fine with just copy/pasting implementations
09:30 < andytoshi> if it's not already we shuold add "can do our own #derive macros" to the rust 2018 tracking issue
09:30 < andytoshi> lol yeah, it's in the tracking issue, it's one of the first things dr-orlovsky cited
09:33 -!- jeremyrubin [~jr@2607:fb90:80c9:4c5d:300e:3023:6b28:256b] has joined #rust-bitcoin
09:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
10:11 -!- belcher_ is now known as belcher
10:37 -!- jeremyrubin [~jr@2607:fb90:80c9:4c5d:300e:3023:6b28:256b] has quit [Ping timeout: 260 seconds]
11:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
13:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
13:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
13:52 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
13:52 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
13:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
14:43 -!- fiatjaf2 [~fiatjaf@2804:7f2:2a8b:8a99:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
14:43 -!- fiatjaf2 [~fiatjaf@2804:7f2:2a8b:8a99:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
14:43 -!- erasmospunk [~erasmospu@2a01:4f8:201:232f::2] has quit [Ping timeout: 260 seconds]
14:44 -!- erasmospunk [~erasmospu@2a01:4f8:201:232f::2] has joined #rust-bitcoin
14:55 < sgeisler> stevenroose: you mean #508? I don't think I have anything to add. If your copying approach works let's do it and open an issue to eventually refactor it so we don't loose track of this unwanted redundancy.  I didn't really find much time over the holidays to work on anything.
15:35 < stevenroose> dr-orlovsky, andytoshi: acked 498
15:35 < stevenroose> I tried to address all the pending PRs for the release as per the release ticket
15:42 < andytoshi> rereviewing 498
17:08 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has joined #rust-bitcoin
17:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
17:28 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
17:31 -!- jeremyrubin [~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b] has joined #rust-bitcoin
17:51 -!- jeremyrubin [~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b] has quit [Ping timeout: 264 seconds]
18:08 -!- jeremyrubin [~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b] has joined #rust-bitcoin
18:13 -!- jeremyrubin [~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b] has quit [Ping timeout: 264 seconds]
18:14 -!- jonatack [~jon@134.19.179.235] has quit [Ping timeout: 246 seconds]
20:56 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has joined #rust-bitcoin
21:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
21:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:12 -!- jeremyrubin [~jr@2607:fb90:460:fdaf:300e:3023:6b28:256b] has joined #rust-bitcoin
23:46 -!- jeremyrubin [~jr@2607:fb90:460:fdaf:300e:3023:6b28:256b] has quit [Ping timeout: 264 seconds]
23:46 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-ohjdexvtbvfupplm] has quit [Read error: Connection reset by peer]
23:46 -!- jeremyrubin [~jr@2607:fb90:46c:8e30:300e:3023:6b28:256b] has joined #rust-bitcoin
23:47 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-xxyfbhfpwravtvho] has joined #rust-bitcoin
23:48 -!- wallet42___ [sid154231@gateway/web/irccloud.com/x-nsfflmahewctnkwz] has quit [Ping timeout: 240 seconds]
23:49 -!- wallet42___ [sid154231@gateway/web/irccloud.com/x-rqajlfifxlipbvar] has joined #rust-bitcoin
--- Log closed Mon Dec 28 00:01:00 2020