--- Log opened Thu Jan 14 00:00:14 2021
01:24 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds]
01:26 -!- jonatack [~jon@185.206.225.51] has joined #rust-bitcoin
01:34 -!- jonatack [~jon@185.206.225.51] has quit [Quit: jonatack]
01:34 -!- jonatack [~jon@185.206.225.51] has joined #rust-bitcoin
01:57 -!- Kiminuo [~mix@141.98.103.228] has joined #rust-bitcoin
02:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.237.19] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.6.244.247] has joined #rust-bitcoin
02:43 -!- guest534543 [~mix@141.98.103.228] has joined #rust-bitcoin
02:46 -!- Kiminuo [~mix@141.98.103.228] has quit [Ping timeout: 240 seconds]
03:20 -!- Shanelle82Swania [~Shanelle8@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
03:21 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.6.244.247] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has joined #rust-bitcoin
03:59 -!- guest534543 [~mix@141.98.103.228] has quit [Quit: Leaving]
04:00 -!- Kiminuo [~mix@141.98.103.228] has joined #rust-bitcoin
04:17 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:37 -!- tibo [~tibo@2400:4050:2a83:7000:7118:a57:7c96:bcf8] has quit [Remote host closed the connection]
04:40 -!- jonatack [~jon@185.206.225.51] has quit [Quit: jonatack]
04:49 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
04:54 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has joined #rust-bitcoin
04:54 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
04:55 -!- jonatack [~jon@213.152.162.154] has joined #rust-bitcoin
05:38 < dr-orlovsky> elichai2: stevenroose: sanket1729: dongcarl: can you pls ACK 0.26 release PR so it can be published https://github.com/rust-bitcoin/rust-bitcoin/pull/533
05:42 < dr-orlovsky> also, andytoshi: and others, I'd like to ask you to consider adding me to the reviewers in rust-bitcoin - or indicate which requirements I have to meet in order to get there at some point. It seems I have already contributed a lot to the repo over the last 1.5 years (Github lists me as a #3 contributor https://github.com/rust-bitcoin/rust-bitcoin/graphs/contributors) and will really appreciate the chance of doing more work as a mainta
05:42 < dr-orlovsky> iner.
05:43 -!- Shanelle82Swania [~Shanelle8@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
05:51 -!- Kiminuo [~mix@141.98.103.228] has quit [Ping timeout: 265 seconds]
06:01 -!- jonatack [~jon@213.152.162.154] has quit [Ping timeout: 246 seconds]
06:05 -!- Kiminuo [~mix@141.98.103.228] has joined #rust-bitcoin
06:07 -!- Kiminuo [~mix@141.98.103.228] has quit [Client Quit]
06:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:14 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
06:17 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
06:22 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has joined #rust-bitcoin
06:26 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
06:31 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds]
06:40 -!- belcher_ is now known as belcher
07:02 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
07:07 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
07:08 -!- jonatack [~jon@79.142.69.160] has joined #rust-bitcoin
07:13 -!- jonatack [~jon@79.142.69.160] has quit [Ping timeout: 246 seconds]
07:16 -!- jonatack [~jon@37.172.240.245] has joined #rust-bitcoin
07:20 -!- jonatack [~jon@37.172.240.245] has quit [Read error: Connection reset by peer]
07:53 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
07:53 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
07:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
08:18 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:19 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
08:24 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has joined #rust-bitcoin
08:36 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
08:39 -!- belcher_ is now known as belcher
08:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:03 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
09:03 < andytoshi> dr-orlovsky: congrats on being #3 contributor :P i'm not too surprised. you've contributed a ton and i really appreciate it
09:04 < andytoshi> i'm a bit torn about making you a maintainer, because a few of your major PRs have had to go through many iterations
09:04 < andytoshi> which have had a lot of value, and i guess if you were able to directly ack things, i worry that we'd lose some such iterations :P
09:05 < andytoshi> but maybe this isn't really a concern, we do always require two acks after all. i'm not sure
09:06 < jeremyrubin> isn't self-acking discouraged anyways?
09:06 < jeremyrubin> (has no opinion on who should be maintainer)
09:06 < andytoshi> jeremyrubin: heh, github won't even acknowledge self acking
09:07 < andytoshi> my concern is about external contributions that might need the same sorts of iteration
09:07 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
09:08 < andytoshi> i think i'm probably being overly paranoid .. it's nice to say "nothing gets in until both stevenroose and sgeisler have had a chance to demand dramatic rearchitecturing" but in practice we really are bottlenecked on review because of this
09:09 -!- jonatack [~jon@213.152.162.74] has joined #rust-bitcoin
09:09 < andytoshi> (and also, despite that, sometimes things get in that i don't like. such is life, it's easy to fix after the fact.)
09:11 < andytoshi> btw. i'm gonna merge 0.26
09:13 < andytoshi> #551 can go in 0.26.1 dr-orlovsky, i'm just working today on improving my local CI stuff .. my python code is deadlocking and i think i need to port to a serious language
09:15 < sgeisler> andytoshi: yeah, I left the 0.26 merge to you since you'll need to publish anyway
09:15 < dr-orlovsky> andytoshi: yes, I understand your concern. I also do not treat myself as an experienced reviewer, and with the PRs I had I didn't liked the number of things that skipped my attention when I was submitting the code. So I understand your concern
09:17 < dr-orlovsky> Also we may think of increasing the number of ACKs to 3, since we have sanket1729 joined and potentially me - that will remove the bottleneck of increasing number of ACKs for merging
09:18 < dr-orlovsky> Re #551: I was thinking about putting it into 0.26.1 myself, so no rush with it
09:19 < andytoshi> yeah, if we increased the ACK count to 3 i'd definitely be in favor of bringing dr-orlovsky on
09:19 < andytoshi> if we left it at 2, i'm mildly in favor :P
09:20 < sgeisler> With 3 Acks that sounds good (I hope that works in practice though)
09:21 < dongcarl> I feel like I should be removed until I start reviewing or contributing more.
09:21 < andytoshi> dongcarl: that's reasonable. if you shoot me an email (just so i know you're not an IRC impostor :)) i'll do that
09:21 < dongcarl> andytoshi: Will do
09:23 < andytoshi> 0.26 published by the way
09:24 < dr-orlovsky> yeah, it was a loooong way to this release :)
09:24 < andytoshi> lol yeah, holy shit
09:24 < andytoshi> let's try to get 0.26.1 out reasonably fast .. but 0.27 might be another long haul because we're talking about dramatic module rearrangement
09:31 < dr-orlovsky> Would it make sense to create a specifal refactoring branch for these large-scale changes and PR all refactorings against it (and not master) backporting later all the master changes which will happen? This will allow to keep release cycle and avoid multiple rebases of existing PRs once module structure changes
09:33 < andytoshi> hehehe "keep release cycle"
09:33 < andytoshi> dr-orlovsky: well, either the refactorings have to keep getting rebased, or other changes need to keep getting rebased..
09:34 < andytoshi> or rather, everything else needs to get rebased when the refactorings get merged
09:34 < andytoshi> but i think actually there'll only be one or two which are super invasive
09:34 < andytoshi> maybe only the module rearrangement one
09:34 < andytoshi> the bitcoin-encoding one might actually be not so bad, since it'll be mostly renames
09:36 < dr-orlovsky> Let's consider the following: taproot will be a hot topic, and there still a lot has to be done regarding it. It will be pitty if we will stick in limbo for months with no release pending a lot of invasive refactoring PRs and not being able to do a stuff required for taproot...
09:40 < andytoshi> yeah, it may be worthwhile to have a separate branch for taproot
09:41 < andytoshi> fwiw i think a lot of work will happen in rust-elements and elements-miniscript before rust-bitcoin, so we have time to iterate
10:55 -!- Kiminuo [~mix@217.138.199.4] has joined #rust-bitcoin
11:27 -!- guest534543 [~mix@141.98.103.92] has joined #rust-bitcoin
11:28 -!- Kiminuo [~mix@217.138.199.4] has quit [Read error: Connection reset by peer]
11:28 -!- harding [~quassel@newmail.dtrt.org] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
11:29 -!- harding [~quassel@newmail.dtrt.org] has joined #rust-bitcoin
11:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
11:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:33 < jeremyrubin> BlueMatt: is there any good text resources on the state of rust_bitcoin/wasm stuff?
11:33 < jeremyrubin> was linking against secp ever working?
11:34 < andytoshi> yes, it should all work
11:34 < andytoshi> we test it in CI
11:34 < jeremyrubin> hmm
11:34 < andytoshi> hmm, actually rust-bitcoin maybe not. but rust-secp we do
11:35 < jeremyrubin> gotcha. Specifically I was trying to target wasm32-wasi and then run in wasmtime but I get
11:35 < jeremyrubin>     1: command export 'rustsecp256k1_v0_2_0_context_no_precomp' is not a function
11:35 < andytoshi> v0_2_0? heh i have no idea if that works or not
11:36 < BlueMatt> jeremyrubin: wasm linking across all rust-bitcoin crates *should* work fine, but its definitely under-tested
11:38 < jeremyrubin> hm maybe I should re-do my patch on a known-working version heh
11:53 < jeremyrubin> interesting, was able to get wasm32-unknown-unknown compiling but wasm32-wasi  has https://github.com/rust-bitcoin/rust-lightning/issues/584 issue
12:01 < BlueMatt> jeremyrubin: upgrade your libsecp?
12:01 < BlueMatt> jeremyrubin: that was fixed by https://github.com/rust-bitcoin/rust-secp256k1/pull/208
12:02 < BlueMatt> oh, sorry, https://github.com/rust-bitcoin/rust-secp256k1/pull/242
12:08 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
12:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
12:12 -!- guest534543 [~mix@141.98.103.92] has quit [Quit: Leaving]
12:12 -!- Kiminuo [~mix@141.98.103.92] has joined #rust-bitcoin
12:15 < jeremyrubin> BlueMatt: I thought I was? Will verify in a bit; thx
12:15 < BlueMatt> its possible that patch didnt work? dunno, but its def designed to hit the "no string file" import thinggy
12:22 < dr-orlovsky> sgeisler: can you pls help me with reviewing my PRs to make rust-lightning-invoice use 0.26?
12:23 < sgeisler> sure, but rather tomorrow :)
12:25 < dr-orlovsky> no probs, I will prepare the PR today
13:19 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
13:30 -!- felixweis [sid154231@gateway/web/irccloud.com/x-ammtqmswwvkhmxzx] has quit [Ping timeout: 260 seconds]
13:31 -!- felixweis [sid154231@gateway/web/irccloud.com/x-mdptrwlrtlphtxkd] has joined #rust-bitcoin
13:39 -!- Kiminuo [~mix@141.98.103.92] has quit [Quit: Leaving]
14:34 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:46 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:21 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
15:23 < jeremyrubin> BlueMatt:  that seems to be unreleased tho correct?
15:27 < jeremyrubin> weird; through a mysterious sequence my original build config works again..
15:27 < jeremyrubin> Ah right
15:28 < jeremyrubin> The *build* works, but running in wasmtime yields
15:28 < jeremyrubin> rustsecp256k1_v0_2_0_context_no_precomp
15:28 < jeremyrubin> err
15:28 < jeremyrubin>     1: command export 'rustsecp256k1_v0_2_0_context_no_precomp' is not a function
15:32 -!- tibo [~tibo@2400:4050:2a83:7000:b91d:37fc:17a0:9c27] has joined #rust-bitcoin
15:35 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:40 < BlueMatt> hmm, thats definitely strange - the libsecp CI pipeline tests in wasm.
15:40 < BlueMatt> but I admit I've never run it in wasm outside of that pipeline
15:41 < jeremyrubin> yeah I think I need to do some annoying work to test it now
15:41 < BlueMatt> does that function take a struct by value?
15:41 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:42 < jeremyrubin> Because I'm rebasing onto master my tweaks to rust secp (really just JSON support but then bumping rust-secp to master I also need to bump rust_bitcoin
15:42 < jeremyrubin> so will take me a lil bit to rebase everything now
15:43 < BlueMatt> if that function takes a struct by value then you may need rustc-git-master/rustc-next-release
15:46 < BlueMatt> it *may* also apply if it returns a struct, I'm not sure. would have to ask elichai2
15:46 < BlueMatt> and it may need to be a small struct
15:49 < elichai2> jeremyrubin: can you try depending on rust-secp master git?
15:49 < thomaseizinger> jeremyrubin: are you on MacOS?
15:49 < elichai2> I don't remember what was the state of things at the last release 😅
15:49 < BlueMatt> isnt latest release, like, a few days ago?
15:50 < thomaseizinger> We've run into problems recently trying to compile rust-secp to WASM on MacOS even though it works perfectly on linux
15:51 < elichai2> You're right. So it's just old versions? Our secp256k1-sys is version 0.4 not 0.2
16:02 < jeremyrubin> will try all soon...
16:03 < jeremyrubin> I need to rebase basically... every rust-bitcoin library
16:03 -!- Netsplit *.net <-> *.split quits: kallewoof, stevenroose, fiatjaf2, gribble, jonatack, schmidty, nickler, elichai2, felixweis, windsok
16:05 -!- Netsplit over, joins: felixweis, windsok, elichai2, schmidty, kallewoof, stevenroose, fiatjaf2
16:06 -!- Netsplit over, joins: jonatack, gribble, nickler
16:07 -!- thomaseizinger [thomaseizi@gateway/shell/matrix.org/x-kjdwehkpxcuxnxpm] has quit [Ping timeout: 244 seconds]
16:07 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-kmxptbegweexrioe] has quit [Ping timeout: 264 seconds]
16:09 -!- schmidty [sid297174@gateway/web/irccloud.com/x-pilbrnsjaokvmwfz] has quit [Ping timeout: 274 seconds]
16:10 -!- schmidty [sid297174@gateway/web/irccloud.com/x-bcmslhjuomznedcf] has joined #rust-bitcoin
16:10 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Excess Flood]
16:12 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lrklepokwofiibml] has joined #rust-bitcoin
16:22 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
16:42 -!- thomaseizinger [thomaseizi@gateway/shell/matrix.org/x-nxnmcmixsvsokojn] has joined #rust-bitcoin
16:52 -!- thomaseizinger [thomaseizi@gateway/shell/matrix.org/x-nxnmcmixsvsokojn] has quit [Ping timeout: 268 seconds]
16:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has joined #rust-bitcoin
17:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
17:03 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-qzpuxnlstllpnnbx] has joined #rust-bitcoin
17:04 < jeremyrubin> Ok All has been rebased!
17:04 < jeremyrubin>     1: command export 'rustsecp256k1_v0_4_0_context_no_precomp' is not a function
17:06 < jeremyrubin> The symbol is *indeed* not a function
17:09 < jeremyrubin> it doesn't seem to be used as one either
17:12 < jeremyrubin> elichai2: this is on ubuntu & using the latest git version
17:32 < jeremyrubin> Woop!
17:33 < jeremyrubin> It works -- it's an issue with Wasmtime but Wasmer handles it correctly
18:13 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8d15:34a2:c515:f802] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:64d3:d9bb:432e:acbc] has joined #rust-bitcoin
19:01 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 260 seconds]
19:39 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
20:43 < BlueMatt> andytoshi: alright, you can smack me later for not reviewing sooner, but the redoing fuzztarget diff looks like it may make some codepaths unreachable in fuzzing now - specifically going to a real private->public key derivation scheme means things like in lightning where we need to expose the private key for a public key we provided previously may be unreachable within reason.
20:43 < BlueMatt> andytoshi: is there some simple-ish thing we could drop in for the private->public derivation that would solve that? eg is private == public valid here, or maybe private ^ 1 = public?
20:52 < BlueMatt> ehh, I'll open an issue
21:29 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
21:29 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
22:19 -!- rich [~rich@shindig.notmandatory.org] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
22:19 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
22:21 -!- notmandatory [~notmandat@shindig.notmandatory.org] has joined #rust-bitcoin
22:22 -!- rich [~rich@shindig.notmandatory.org] has joined #rust-bitcoin
22:36 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
--- Log closed Fri Jan 15 00:00:15 2021