--- Log opened Fri Jan 15 00:00:15 2021
00:17 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:64d3:d9bb:432e:acbc] has quit [Ping timeout: 264 seconds]
00:19 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
00:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3a8e:d956:f43e:d9a3:9155] has joined #rust-bitcoin
00:59 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
00:59 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
00:59 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
01:24 < elichai2> Jeremyrubin good to hear :) maybe open an issue on wasmtime, they probably have some problems supporting extern statics (I wonder how are they different? Is that a different target? Are they using a custom linker?)
01:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3a8e:d956:f43e:d9a3:9155] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:48 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 260 seconds]
02:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3a8e:d956:f43e:d9a3:9155] has joined #rust-bitcoin
03:00 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Write error: Broken pipe]
03:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
03:21 -!- Richie68Beier [~Richie68B@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
03:40 -!- tibo [~tibo@2400:4050:2a83:7000:b91d:37fc:17a0:9c27] has quit [Remote host closed the connection]
03:43 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #rust-bitcoin
04:13 < dr-orlovsky> sgeisler: rust-lightning-invoice PRs for review:
04:13 < dr-orlovsky> https://github.com/rust-bitcoin/rust-lightning-invoice/pull/44 - upgrade to 0.26
04:14 < dr-orlovsky> https://github.com/rust-bitcoin/rust-lightning-invoice/pull/43 - fixes for error descriptors (based on #44, so mush be rebased after merge)
04:14 < dr-orlovsky> also, the lib panics on android platform b/c of SystemTimestamp not being 64 bits there. Any ideas how this can be fixed?
04:15 -!- Richie68Beier [~Richie68B@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds]
05:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3a8e:d956:f43e:d9a3:9155] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:20 < dr-orlovsky> those with ACKs permissions for lightning-invoice, can you pls review https://github.com/rust-bitcoin/rust-lightning-invoice/pull/45 which is a single PR summarized by sgeisler: modernizing the repo
05:21 < sgeisler> dr-orlovsky: I think that's basically matt and me and matt was never very active in that repo xD
05:22 < sgeisler> also: I mainly opened the PR not to get in your way and to debug travis in parallel
05:22 < sgeisler> if you can fix the CI I'd happily merge your version
05:23 < sgeisler> I'd also be happy to switch to GH actions, but I kinda have other things to do too, but maybe that would actually be faster?
05:24 < dr-orlovsky> ok, will see what I can do here
05:24 < sgeisler> Generally the repo needs some more love, I've not done much and there's an updated BOLT11, so feel free to PR, I'm always happy to review
05:29 < sgeisler> dr-orlovsky: I got travis running now
05:31 < sgeisler> if it runs through I'll merge and publish
05:32 < sgeisler> I'd also be happy to welcome you as a co-maintainer for that crate if you want to work more on it
05:32 < dr-orlovsky> I also gor travis running in my older PRs - introduced the same changes. So you can merge any PRs that you'd like
05:32 < dr-orlovsky> sgeisler: ok, I'm up to it. Let's see what I can do in order to improve it and then discuss this matter once again
05:41 < sgeisler> travis seems to have a super slow day, we should really move away from there :(
06:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has joined #rust-bitcoin
06:08 < dr-orlovsky> yes, will do a PR updating to GitHub actions a bit later
06:13 < sgeisler> dr-orlovsky: I just released v0.4.0
06:14 < dr-orlovsky> thank you!
06:18 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 256 seconds]
06:23 < sgeisler> dr-orlovsky: regarding the failure to build on 32bit android, see https://github.com/rust-bitcoin/rust-lightning-invoice/blob/master/src/lib.rs#L52 and https://github.com/rust-lang/rust/pull/55527
06:24 < sgeisler> I had to work around time arithmetic limitations in the stdlib _somehow_. Once MSRV is bumped to >= 1.34 this hack isn't needed anymore https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_add
06:25 < sgeisler> Feel free to propose something else that allows you use case (either a feature-flagged migration to checked_add or another, compatible hack)
06:35 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has quit [Ping timeout: 272 seconds]
06:47 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
06:59 < andytoshi> BlueMatt: thanks, i'll comment on the issue
07:02 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #rust-bitcoin
07:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
07:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
07:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
07:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
08:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:13 -!- jonatack [~jon@213.152.162.74] has quit [Ping timeout: 264 seconds]
08:15 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin
08:17 < andytoshi> does anyone have PRs that they'd like to see in 0.26.1?
08:18 < andytoshi> otherwise i think i'd like to start pushing forward on big invasive stuff
08:19 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
08:47 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds]
08:47 -!- jonatack [~jon@213.152.162.10] has joined #rust-bitcoin
09:29 < BlueMatt> andytoshi: basically I'd think we'll need to reimplement half the library again either way.
09:30 < BlueMatt> just in a more considered way.
09:30 < BlueMatt> unless you can get the order-17 group working....what was the issue with that again? just that the almost-every-32-byte-string-is-valid property blows up in your face?
09:32 < andytoshi> yeah, basically you get 0 pubkeys a lot
09:32 < andytoshi> which have no encoding
09:33 < andytoshi> so maaybe i can hack things to give 0 pubkeys an encoding, or maybe i can hack the tweak add/mull functionality to never hit 0
09:33 < BlueMatt> hmm, right, mapping up one doesnt solve it, either :/
09:33 < andytoshi> yeah, then you don't have a group anymore
09:34 < BlueMatt> right lol
09:35 < andytoshi> frustratingly it's not just about adding a 0 encoding either ... internally we do a lot of 'is this point 0' checks during computations
09:47 < BlueMatt> right...
09:51 < BlueMatt> i wonder if anyone upstream has any more clever ideas
09:51 < BlueMatt> it seems like something that upstream could use, too, cause bitcoin core may find it useful
09:52 < andytoshi> yeah, we had a brief discussion on #secp256k1 a few weeks ago but didn't get very far
09:52 < andytoshi> you're welcome to restart it. agree that Core's fuzzing could make use of it
09:55 < andytoshi> we could do stuff like "instead of using {xG : x in secretkeys} as our pubkey group we could use {2^x G : x in secretkeys} ... except replace 2 with some value that would give the resulting group order 149 say
09:56 < andytoshi> or 8 or 16 or 32 ... i dunno at what point it gets "too small"
09:56 < andytoshi> but if we use this strategy we have a pretty big choice of numbers
10:02 < BlueMatt> yea, i mean any single-byte value is definitely fine
10:02 < BlueMatt> two bytes probably too, but more than that isnt ok.
10:12 < BlueMatt> ok, i brought it up there
11:27 -!- belcher_ is now known as belcher
11:37 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
12:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:34 < dr-orlovsky> andytoshi: whishlist for 0.26.1 - #551, #521, #511. Also I'd like to ask your (n)ACK on https://github.com/rust-bitcoin/rust-bitcoin/pull/469#issuecomment-760251290
12:36 < dr-orlovsky> *concept (n)ACK
12:59 < andytoshi> dr-orlovsky: concept nack. i'll post on the issue since there seems to be some external support
13:12 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
13:36 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
13:56 < jeremyrubin> FYI https://github.com/bytecodealliance/wasmtime/issues/2587
13:57 < jeremyrubin> elichai2: ^
13:59 < jeremyrubin> BlueMatt: probably interesting for you too
14:01 < BlueMatt> jeremyrubin: huh. wtf lol. well, good to know........
14:01 < BlueMatt> wasm is still soooo early :(
14:02 < jeremyrubin> I think this issue is particularly surprising
14:02 < jeremyrubin> I figured the issues around *tooling* should be immature
14:02 < jeremyrubin> but an issue around *runtime* seems... scary
14:03 < jeremyrubin> Isn't wasmtime the same runtime used internally for firefox?
14:03 < BlueMatt> kinda? I mean thats basically a library load error cause thats at runtime? I dunno...
14:04 < BlueMatt> definitely not great, but better than, like, abi incompatibility lol
14:05 < jeremyrubin> I wonder if we should be pulling in wasmtime/wasmer or something to test that our libraries not just build but run
14:05 < jeremyrubin> what's CI doing now? Just build?
14:05 < BlueMatt> i thought it ran tests
14:05 < BlueMatt> in node with wasm_pack or some shit
14:06 < jeremyrubin> that would test wasm32-unknown-unknown tho right?
14:06 < BlueMatt> i believe so, yes.
14:07 < jeremyrubin> wasi CI would be good I guess... maybe I'll add that
14:58 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-kcpafitmewgluevi] has quit [Read error: Connection reset by peer]
14:58 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-mrtijxnbhfqxcrfs] has joined #rust-bitcoin
15:01 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Remote host closed the connection]
15:20 -!- Netsplit *.net <-> *.split quits: wraithm
15:22 -!- Netsplit over, joins: wraithm
15:34 < BlueMatt> jeremyrubin: I dont believe rust prunes c-exported symbols when deciding, itself, what to export, so we'd indirectly be exporting that symbol..........
15:34 < BlueMatt> i assume there's some way to make rustc do that with lto
15:37 < jeremyrubin> yeah kinda interestin... tbh I couldnt even find a WASI spec online which mentions this
15:37 < BlueMatt> heh
15:42 -!- tibo [~tibo@2400:4050:2a83:7000:ed8b:9830:1058:4711] has joined #rust-bitcoin
15:46 -!- tibo [~tibo@2400:4050:2a83:7000:ed8b:9830:1058:4711] has quit [Ping timeout: 248 seconds]
16:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3a8e:d956:f43e:d9a3:9155] has joined #rust-bitcoin
16:54 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
16:57 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
19:02 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Remote host closed the connection]
20:13 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #rust-bitcoin
20:20 -!- andytoshi [~apoelstra@66.183.0.205] has joined #rust-bitcoin
20:20 -!- andytoshi [~apoelstra@66.183.0.205] has quit [Changing host]
20:20 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
21:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3a8e:d956:f43e:d9a3:9155] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:28 -!- titanbiscuit [~tbisk@104.200.131.173] has quit [Ping timeout: 256 seconds]
--- Log closed Sat Jan 16 00:00:17 2021