--- Log opened Thu Feb 11 00:00:26 2021 00:26 -!- jonatack [~jon@37.173.248.254] has quit [Ping timeout: 272 seconds] 00:30 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 00:30 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 01:30 -!- rich [~rich@shindig.notmandatory.org] has quit [Ping timeout: 256 seconds] 01:31 -!- rich [~rich@shindig.notmandatory.org] has joined #rust-bitcoin 01:32 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds] 02:32 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin 02:50 -!- fiatjaf2 [~fiatjaf@2804:7f2:2a8c:9df7:ea40:f2ff:fe85:d2dc] has quit [Quit: WeeChat 2.9] 03:18 -!- Marco55Kub [~Marco55Ku@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 04:51 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #rust-bitcoin 04:52 -!- notmandatory_ [~notmandat@shindig.notmandatory.org] has quit [Ping timeout: 264 seconds] 04:57 -!- jonatack [~jon@37.169.62.216] has joined #rust-bitcoin 05:04 -!- belcher_ is now known as belcher 05:30 -!- Marco55Kub [~Marco55Ku@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 05:40 -!- galderz [~user@185.197.2.85.dynamic.wline.res.cust.swisscom.ch] has joined #rust-bitcoin 05:56 -!- galderz` [~user@2a02:1205:502c:5b90:447c:99ae:a174:9395] has joined #rust-bitcoin 05:57 -!- galderz` [~user@2a02:1205:502c:5b90:447c:99ae:a174:9395] has quit [Read error: Connection reset by peer] 05:58 -!- galderz [~user@185.197.2.85.dynamic.wline.res.cust.swisscom.ch] has quit [Ping timeout: 265 seconds] 06:04 -!- jonatack [~jon@37.169.62.216] has quit [Ping timeout: 240 seconds] 06:13 -!- jonatack [~jon@37.169.62.216] has joined #rust-bitcoin 06:57 < darosior> Hi, has there been prior discussions to derive PartialEq on all error enums ? If not, are there drawbacks to do so and would a patch be welcome ? I find it useful to assert on variants in my tests downstream and currently hack around by using String variants for rust-bitcoin's errors. 06:57 < darosior> (wanted to PR it to Miniscript but it actually went up to rust-bitcoin) 07:24 < cloudhead> afaict one problem is that io::Error isn't PartialEq 07:25 < cloudhead> but I guess for some error types it should work 07:38 -!- Kiminuo [~Kiminuo@141.98.103.124] has quit [Ping timeout: 246 seconds] 09:11 -!- jonatack [~jon@37.169.62.216] has quit [Read error: Connection reset by peer] 09:21 -!- jonatack [~jon@37.169.62.216] has joined #rust-bitcoin 09:33 -!- Kiminuo [~Kiminuo@141.98.103.124] has joined #rust-bitcoin 09:34 -!- jonatack [~jon@37.169.62.216] has quit [Ping timeout: 256 seconds] 10:08 -!- jonatack [~jon@37.169.62.216] has joined #rust-bitcoin 10:40 -!- jonatack [~jon@37.169.62.216] has quit [Read error: Connection reset by peer] 10:41 -!- jonatack [~jon@37.169.62.216] has joined #rust-bitcoin 10:51 -!- jonatack [~jon@37.169.62.216] has quit [Ping timeout: 240 seconds] 10:52 -!- jonatack [~jon@37.169.62.216] has joined #rust-bitcoin 10:52 -!- jonatack [~jon@37.169.62.216] has quit [Read error: Connection reset by peer] 11:01 -!- jonatack [~jon@37.173.153.89] has joined #rust-bitcoin 12:13 < Thomas[m]1> `matches!` can be useful as an alternative although the assertion failure message is shit because it only returns a boolean 12:13 < darosior> Thanks Thomas[m]1 and cloudhead ! 12:14 < Thomas[m]1> There is also currently some work under way to add more std derives to types but it is not yet released I think 12:15 < Thomas[m]1> see here and the linked PRs / issues: https://github.com/rust-bitcoin/rust-bitcoin/issues/555 12:18 < darosior> Thanks 12:54 -!- jonatack [~jon@37.173.153.89] has quit [Read error: Connection reset by peer] 12:54 -!- jonatack_ [~jon@37.173.153.89] has joined #rust-bitcoin 13:04 -!- jonatack_ [~jon@37.173.153.89] has quit [Quit: jonatack_] 13:34 -!- jonatack [~jon@37.173.153.89] has joined #rust-bitcoin 14:24 -!- Kiminuo [~Kiminuo@141.98.103.124] has quit [Ping timeout: 256 seconds] 14:41 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-ihozpqrvbxpcilcr] has quit [Read error: Connection reset by peer] 14:41 -!- felixweis [sid154231@gateway/web/irccloud.com/x-ntdyaxjwaufomstj] has quit [Read error: Connection reset by peer] 14:41 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-fnnnbfkbileowsih] has quit [Read error: Connection reset by peer] 14:41 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-ruscvhxdkxnvfepw] has joined #rust-bitcoin 14:41 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-bnqmyrnstbxbslmf] has joined #rust-bitcoin 14:41 -!- felixweis [sid154231@gateway/web/irccloud.com/x-uxvkkvzinlkyxlvm] has joined #rust-bitcoin 15:19 < ariard> BlueMatt: do you agree with assumptions laid out here: https://github.com/rust-bitcoin/rust-lightning/pull/646#discussion_r574149899 ? 15:20 < ariard> to be clear a) feeding us an assumed-valid unbounded payment graph b) triggering a routing request toward some node of this malicious graph 15:21 < ariard> I'm concerned with memory Dos/infinite loops in `get_route` and tweaking test coverage to raise some 15:22 < ariard> but maybe that's too esoteric for now? 16:01 -!- tibo [~tibo@2400:4050:2a83:7000:3d04:db06:9c50:7339] has joined #rust-bitcoin 17:05 -!- jonatack [~jon@37.173.153.89] has quit [Ping timeout: 264 seconds] 17:56 < BlueMatt> ariard: hmmm, I'm definitely concerned about the same (the fuzzer found one that I pointed out!). I'm not concerned about infinite loops that are based on the fact that the graph is infinite - users either have to get from a trusted source or have some dos limits, we cant help them otherwise. 17:56 < BlueMatt> I'm not sure what else a malicious graph could look like? 17:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 18:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 18:09 < BlueMatt> andytoshi: would you kill me if I suggested a feature for rust-secp global context but without the rand dep/context randomization? 20:15 < andytoshi> BlueMatt: nah, i think i've been beaten down enough on this 20:15 < andytoshi> go for it :) 20:21 -!- tibo [~tibo@2400:4050:2a83:7000:3d04:db06:9c50:7339] has quit [] 20:23 -!- tibo [~tibo@2400:4050:2a83:7000:6990:d3ed:dacb:6518] has joined #rust-bitcoin 22:33 -!- Kiminuo [~Kiminuo@141.98.103.124] has joined #rust-bitcoin 22:45 -!- Kiminuo [~Kiminuo@141.98.103.124] has quit [Ping timeout: 272 seconds] --- Log closed Fri Feb 12 00:00:27 2021