--- Log opened Sun Feb 21 00:00:35 2021
02:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8871:e949:6c7d:3254:7bc2:5a9d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:26 < sgeisler> I'm going through our 0.26.1 milestone, any opposition to merging #414 andytoshi?
02:26 < sgeisler> https://github.com/rust-bitcoin/rust-bitcoin/pull/414
02:28 < sgeisler> #551 needs one more review (very simple, just some derives) https://github.com/rust-bitcoin/rust-bitcoin/pull/551
02:46 -!- th0th1 [~th0th@gateway/tor-sasl/th0th] has joined #rust-bitcoin
02:49 -!- th0th [~th0th@gateway/tor-sasl/th0th] has quit [Ping timeout: 268 seconds]
03:23 -!- Thomas73Hintz [~Thomas73H@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
04:14 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:ecd4:c92c:f02:3202] has joined #rust-bitcoin
06:13 < andytoshi> morning. lemme review it real quick
06:14 < andytoshi> oh yeah i concept ACKed this one a while ago
06:14 < andytoshi> sgeisler: want me to click "merge"? or you can
06:14 < andytoshi> (414 that is)
06:14 < sgeisler> done
06:14 < andytoshi> ok, i did 551
06:15 < andytoshi> sorry for being absent these last two weeks! will try to do a github notification burndown tonight or tomorrow
06:16 < sgeisler> another interesting one might be https://github.com/rust-bitcoin/rust-bitcoin/pull/573
06:17 < sgeisler> I'm mainly going through 0.26.1 stuff now (not as much notifications) since that's what we'll be able to merge and I don't like re-reviewing after rebases
06:20 < andytoshi> kk gimme 5 for 573
06:20 < andytoshi> reviewed the code, testing commits now
08:08 -!- Thomas73Hintz [~Thomas73H@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds]
08:12 -!- Kimi [~Kiminuo@109.183.7.106] has joined #rust-bitcoin
08:15 -!- Kiminuo [~Kiminuo@141.98.103.108] has quit [Ping timeout: 240 seconds]
08:49 -!- Kimi [~Kiminuo@109.183.7.106] has quit [Quit: Leaving]
08:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:ecd4:c92c:f02:3202] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:49 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin
10:55 -!- Kiminuo [~Kiminuo@141.98.103.196] has joined #rust-bitcoin
11:24 < dr_orlovsky> this is trivial: https://github.com/rust-bitcoin/rust-bitcoin/pull/558/files (CI fails since it needs cargo update; it runs well locally)
11:25 < andytoshi> i'm a bit suspicious of your "needs cargo update" theory
11:25 < andytoshi> shouldn't it be downloading fresh crates every time?
11:27 < dr_orlovsky> it should, but it does not due to an odd reason. This PR was relying on a new bitcoinconsensus release
11:28 < dr_orlovsky> locally after bitcoinconsensus version was changed it compiles on the same compuler version and error is gone - but not on a CI
11:30 < andytoshi> hmmm, i wonder if we just need to clear caches or something on CI
11:30 < andytoshi> but even then, you changing the dep version in Cargo.toml should've fixed it
11:30 < dr_orlovsky> ok, my bad. I need another version bump for bitcoinconsensus, that's a wrong release (and tested locally w/o bitcoinconsensus feature)
11:31 < andytoshi> ah :P
11:31 < andytoshi> cool, glad i was suspicious
11:33 < dr_orlovsky> yes, there were no new bitcoinconsensus release yet (after error derives merge), thus this PR is still pending :(
11:35 < andytoshi> ah. sucks
11:35 < andytoshi> i'm not sure who works on bitcoinconsensus and can push releases rn ... i have never touched it
11:35 < andytoshi> i have a cargo key, i am technically able to do releases
11:35 < andytoshi> but it's not my place
11:49 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 264 seconds]
12:20 -!- Kiminuo [~Kiminuo@141.98.103.196] has quit [Quit: Leaving]
12:51 -!- felixweis [sid154231@gateway/web/irccloud.com/x-uxvkkvzinlkyxlvm] has quit [Ping timeout: 264 seconds]
12:51 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-bnqmyrnstbxbslmf] has quit [Ping timeout: 272 seconds]
12:51 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-zogsylksfifauupl] has quit [Ping timeout: 260 seconds]
12:51 -!- felixweis [sid154231@gateway/web/irccloud.com/x-nbngwvfrzzhlxemt] has joined #rust-bitcoin
12:52 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-tjfonrkzdmtlgmhk] has joined #rust-bitcoin
12:53 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lopkrozptkoybihj] has joined #rust-bitcoin
13:53 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:25 -!- tibo [~tibo@2400:4050:2a83:7000:1493:269e:3153:2b4a] has joined #rust-bitcoin
16:10 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:ecd4:c92c:f02:3202] has joined #rust-bitcoin
17:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:ecd4:c92c:f02:3202] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@184.22.159.161] has joined #rust-bitcoin
18:08 -!- th0th1 is now known as th0th
18:27 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
18:29 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds]
19:27 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin
20:45 -!- da39a3ee5e6b4b0d [~da39a3ee5@184.22.159.161] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:30 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds]
21:33 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:9dfb:e531:1ee7:9134] has joined #rust-bitcoin
21:40 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 256 seconds]
23:07 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:9dfb:e531:1ee7:9134] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:b8ec:9dfb:e531:1ee7:9134] has joined #rust-bitcoin
--- Log closed Mon Feb 22 00:00:36 2021