--- Log opened Sat Apr 24 00:00:35 2021
00:00 -!- rodentrabies [rodentrabi@gateway/shell/matrix.org/x-wqcoysrcuetcvlmv] has quit [Ping timeout: 245 seconds]
00:03 -!- rodentrabies [rodentrabi@gateway/shell/matrix.org/x-uqiozvxghmghbpiu] has joined #rust-bitcoin
03:51 < darosior> Is it acceptable to bring libc as a dev-dependency in rust-jsonrpc?
04:50 < dr-orlovsky> stevenroose: can you pls review https://github.com/rust-bitcoin/rust-bitcoinconsensus/pull/27 and merge it if you ACK, such we will have a new bitcoinconsensus version published and unblock rust-bitcoin 0.26.1?
05:50 < darosior> (Well i didn't introduce it at the end and rather cleaned up leftover socket, it was for testing UDS support for rust-jsonrpc)
06:07 < darosior> Can a rust-jsonrpc maintainer (andytoshi maybe? I don't know who else is) activate Github Actions on the repo? I made a PR to migrate from failing Travis https://github.com/apoelstra/rust-jsonrpc/pull/43 but i think it won't run until a maintainer take action because of the recent issues they had
08:21 < andytoshi> sure
08:24 < andytoshi> merged ... i don't yet have a checkbox letting me enable it. will wait a couple hours then try poking at it
08:24 < darosior> Ok, hope i got the yaml right lol. looking in my repos where i use it if i can find a checkbox
08:26 < darosior> By the way, what do you conceptually think about https://github.com/apoelstra/rust-jsonrpc/pull/42 ?
08:26 < andytoshi> darosior: to find the checkbox you go into "Branches"
08:26 < andytoshi> and look at the master branch
08:27 < andytoshi> and look for the required CI checks area
08:27 < darosior> Also what do you think about yet another refactor to be able to derive Deserialize on Request, this would make it possible to use rust-jsonrpc on a server side without reinventing the wheel
08:27 < andytoshi> darosior: concept ack 42, though i'd like these to be individually feature gated if they're not
08:27 < darosior> They are
08:28 < darosior> And only the TcpStream is enabled by default
08:30 < darosior> Hmm there is also "settings => Actions => Allow actions", maybe they are disabled by default because of the outage last week
08:30 < darosior> (and i can't see the CI in the branch tab)
08:32 < andytoshi> do you know how to do such a refactor?
08:32 < andytoshi> i am in favor of being able to do this
08:32 < andytoshi> but steven and i ran into a ton of trouble with object safety when we last worked on this
08:33 < darosior> I don't, but it looked hard to do so i wanted a concept ACK first :)
08:33 < darosior> i'll give it a look then, as i can't bear the dozens of dependencies pulled by the other jsonrpc crate anymore
09:04 < darosior> Hmm i can't compile rust-jsonrpc master branch on 1.29 though, see https://github.com/apoelstra/rust-jsonrpc/pull/44
09:04 < jeremyrubin> darosior: if you want there's also the async friendly versions of these crates; i'm happy to take breaking changes on them
09:10 < andytoshi> darosior: good catch. i wonder when the byteorder thing started
09:11 < andytoshi> i wonder if we should just move rust-jsonrpc to 1.36 since mrustc and debian stable (though not old-stable) are there
09:11 < andytoshi> with rust-bitcoin/rust-secp there's an argument that we should be wary about changing because it'll break people
09:11 < andytoshi> but rust-jsonrpc is kinda a bastard stepchild, it's been broken for most of its life and it's not even in the rust-bitcoin org
09:14 < darosior> Ack, i think it would make the move to support server-side easier too
09:15 < jeremyrubin> andytoshi: there's also some missing RPC stuff too, it's kind of a scratch your own itch on some of the APIs/flags
09:15 < jeremyrubin> so for a lot of use cases darosior you might need to just vendor your own version till you can upstream whatever
09:15 < jeremyrubin> E.g., i found getblocktemplate missing the other day
09:16 < darosior> I'm not using the bitcoind wrapper, i use raw rust-jsonrpc
09:17 < jeremyrubin> darosior: ah ok
09:18 < darosior> But good point i wonder what their MSRV is
09:18 < darosior> Btw andytoshi it looks like Github Actions were not kicked :/
09:19 < andytoshi> :(
09:19 < andytoshi> oh iirc i need to push something to master
09:19 < andytoshi> it needs a commit that came from a repo owne
09:21 < andytoshi> hmmmmm nope
09:22 < darosior> Did you check the settings ?
09:22 < darosior> Settings > Actions > Allow actions
09:22 < andytoshi> ah
09:22 < andytoshi> darosior: there is a bug in the workflows file
09:23 < andytoshi> https://github.com/apoelstra/rust-jsonrpc/actions/runs/780875519
09:23 < darosior> Will PR a fix, expected to test on the PR if my syntax was correct :/
09:24 < darosior> Btw i got the master to compile by pining serde_json even lower
09:25 < andytoshi> thanks- i think you might get a test if you check the "actions" tab on the repo?
09:25 < andytoshi> i am never sure, github actions is so opaque
09:33 < darosior> Works! :D Tweaking the pin for the 1.29 job now
09:45 < darosior> andytoshi: yay ci is fixed :D I've put it as part of the doc PR to make it a "all small things" PR
10:03 < BlueMatt> darosior: another option is to take the http and rest clients from https://github.com/rust-bitcoin/rust-lightning/tree/main/lightning-block-sync/src and move those to a new crate and use those instead - they have fewer dependences and are optionally async (with tokio, but could easily be swapped out for ~whatever else).
10:04 < BlueMatt> oh, more importantly, sorry, they support "real" http
10:04 < BlueMatt> right now if you point the rust-bitcoincore-rpc stuff to eg nginx proxying bitcoin core rest it'll break because it will send chunked responses
10:04 < BlueMatt> which is kinda useful to be able to do
10:05 < darosior> Ok, thanks, to consider once/if i want to move to something more elaborated :)
10:08 < BlueMatt> well, something I hope to do eventually anyway.
10:08 < BlueMatt> but if I can find someone who wants to do it instead... :p
10:24 < jeremyrubin> BlueMatt: can that be linked to the existing RPCApi trait in the other crate?
10:24 < jeremyrubin> The other crate has some generic-y transport stuff
10:26 < jeremyrubin> anyways andytoshi i am comfortable with admitting the reason that i want deterministic policy is that i am not smart enough to figure out how to write bare miniscript :)
10:29 < BlueMatt> jeremyrubin: yes, we dont really have much to map serde_json objects into response structs, so ideally we'd just make bitcoincore-rpc use that new code as its backend and we could drop all our json parsing stuff
14:16 -!- Netsplit *.net <-> *.split quits: justinmoon, jeremyrubin, rodentrabies, belcher, midnight, simian_za02, darosior, sgeisler, cloudhead, moneyball,  (+33 more, use /NETSPLIT to show all of them)
14:17 -!- Netsplit over, joins: shesek, _0x0ff, kanzure, jonatack, jakesyl, kcalvinalvin, wallet42____, ariard, sanketcell, CubicEarth (+6 more)
14:18 -!- Netsplit over, joins: ghost43, th0th
14:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Max SendQ exceeded]
14:18 -!- Netsplit over, joins: robert_spigler, kiltzman, early, mycroft
14:19 -!- Netsplit over, joins: rodentrabies, Blackwolfsa4
14:19 -!- Netsplit over, joins: dr-orlovsky, belcher, willcl_ark_, sanket1729
14:19 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-xnxvcvtpceedkggt] has quit [Ping timeout: 269 seconds]
14:19 -!- Netsplit over, joins: midnight, awesome_doge, michaelfolkson, zkao, justinmoon, evalr
14:19 -!- fast1[m] [fast1priva@gateway/shell/matrix.org/x-jxaalweygynpiivh] has quit [Ping timeout: 245 seconds]
14:19 -!- rodentrabies [rodentrabi@gateway/shell/matrix.org/x-uqiozvxghmghbpiu] has quit [Ping timeout: 246 seconds]
14:19 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-klceovtmtfzbkrlc] has quit [Ping timeout: 258 seconds]
14:20 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-htofrhqjoikorhcq] has quit [Ping timeout: 250 seconds]
14:20 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-kdqesaisvohrrlje] has quit [Ping timeout: 248 seconds]
14:20 -!- Netsplit over, joins: schmidty, jamesob_, moneyball, fiatjaf, Galvas, sgeisler, Isthmus, cloudhead
14:20 -!- zkao [zkaomatrix@gateway/shell/matrix.org/x-gjllnujfskjimxhm] has quit [Ping timeout: 276 seconds]
14:20 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-sunxiabzmyfspkky] has quit [Ping timeout: 276 seconds]
14:20 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-agddwmhusnotufog] has joined #rust-bitcoin
14:21 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin
14:22 -!- fjahr [sid374480@gateway/web/irccloud.com/x-mmvomsklbhcubwkr] has quit [Ping timeout: 250 seconds]
14:22 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-mnmaeuwglvhufvtn] has quit [Ping timeout: 265 seconds]
14:22 -!- Galvas [sid459296@gateway/web/irccloud.com/x-gotbpyltugegievm] has quit [Ping timeout: 265 seconds]
14:22 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-uflnueqedawpmbec] has joined #rust-bitcoin
14:23 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-kheorctzcwqgctla] has quit [Ping timeout: 250 seconds]
14:23 -!- fjahr [sid374480@gateway/web/irccloud.com/x-cqausdqkccfuqwew] has joined #rust-bitcoin
14:25 -!- Galvas [sid459296@gateway/web/irccloud.com/x-dvfsivpxwcmsabwl] has joined #rust-bitcoin
14:25 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-dphufthkcdwpcjah] has joined #rust-bitcoin
14:27 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-hqjdugpwahmzgaoe] has joined #rust-bitcoin
14:50 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-tusdyyngpkygpbiy] has joined #rust-bitcoin
15:18 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-bfdgxtvcnzbdjfck] has joined #rust-bitcoin
15:18 -!- rodentrabies [rodentrabi@gateway/shell/matrix.org/x-snlrtilgznnhfwmy] has joined #rust-bitcoin
15:18 -!- fast1[m] [fast1priva@gateway/shell/matrix.org/x-mivftinsvbbbznba] has joined #rust-bitcoin
15:18 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-skoxfvjrvkkolcfy] has joined #rust-bitcoin
15:18 -!- zkao [zkaomatrix@gateway/shell/matrix.org/x-dyaumdpbezxubjwj] has joined #rust-bitcoin
15:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
16:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
16:41 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
16:41 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
16:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
16:57 -!- fiatjaf [~fiatjaf@2804:7f2:2a8e:fd73:ea40:f2ff:fe85:d2dc] has quit [Quit: WeeChat 3.1]
17:01 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
17:03 -!- fiatjaf [~fiatjaf@2804:7f2:2a8e:fd73:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
17:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
17:07 -!- th0th1 [~th0th@gateway/tor-sasl/th0th] has joined #rust-bitcoin
17:08 -!- th0th [~th0th@gateway/tor-sasl/th0th] has quit [Ping timeout: 240 seconds]
17:11 -!- belcher_ is now known as belcher
17:20 -!- fiatjaf [~fiatjaf@2804:7f2:2a8e:fd73:ea40:f2ff:fe85:d2dc] has left #rust-bitcoin []
19:18 -!- Blackwolfsa4 [~Blackwolf@195.159.29.126] has quit [Write error: Connection reset by peer]
19:18 -!- stanimal7 [~stanimal@195.159.29.126] has quit [Remote host closed the connection]
19:18 -!- simian_za02 [~simian_za@195.159.29.126] has quit [Remote host closed the connection]
19:18 -!- CjS77 [~caylemeis@195.159.29.126] has quit [Remote host closed the connection]
--- Log closed Sun Apr 25 00:00:36 2021