--- Log opened Mon Apr 26 00:00:37 2021 01:24 -!- felixweis [sid154231@gateway/web/irccloud.com/x-rjfaljpefwtmhbry] has quit [Read error: Connection reset by peer] 01:24 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-agddwmhusnotufog] has quit [Ping timeout: 246 seconds] 01:24 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-guxdlozlodzaccek] has quit [Read error: Connection reset by peer] 01:24 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-uflnueqedawpmbec] has quit [Read error: Connection reset by peer] 01:29 -!- felixweis [sid154231@gateway/web/irccloud.com/x-hrgkjieufsancvyx] has joined #rust-bitcoin 01:30 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-pmfzsdugzopkxzat] has joined #rust-bitcoin 01:30 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-ctdbnypmeoivqbxx] has joined #rust-bitcoin 01:30 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-ncppgzjybbotbvgu] has joined #rust-bitcoin 01:59 -!- b10c [~b10c@2a01:4f8:200:1036::1] has joined #rust-bitcoin 03:21 -!- Edison65Lakin [~Edison65L@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 03:23 < darosior> andytoshi, stevenroose: what was the rationale for using RawValue in rust-jsonrpc instead of serde_json::Value ? I can't find any in the git history and the JSONRPC2 specs don't restrict the "params" and "result" fields to any particular value either (as it currently is to an array in Request for example). I was also able to have Deserialize for 03:23 < darosior> Request for 1.29 this way with a 10-lines patch so i must be missing something. 03:25 -!- Edison65Lakin [~Edison65L@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 252 seconds] 04:43 -!- th0th1 [~th0th@gateway/tor-sasl/th0th] has joined #rust-bitcoin 04:47 -!- th0th [~th0th@gateway/tor-sasl/th0th] has quit [Ping timeout: 240 seconds] 05:28 -!- tibo [~tibo@p3002252-ipngn18401marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:28 -!- tibo [~tibo@2400:4050:2a83:7000:b87f:dff4:5139:ffde] has joined #rust-bitcoin 05:32 -!- tibo [~tibo@2400:4050:2a83:7000:b87f:dff4:5139:ffde] has quit [Ping timeout: 245 seconds] 06:07 -!- tibo [~tibo@2400:4050:2a83:7000:b87f:dff4:5139:ffde] has joined #rust-bitcoin 06:11 -!- tibo [~tibo@2400:4050:2a83:7000:b87f:dff4:5139:ffde] has quit [Ping timeout: 250 seconds] 06:46 -!- dr_orlovsky [~dr-orlovs@31.14.40.19] has joined #rust-bitcoin 06:46 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 265 seconds] 07:23 < andytoshi> darosior: efficiency 07:24 < andytoshi> RawValue avoids allocations in the case that the json values are strings 07:24 < andytoshi> there was definitely a conversation about it, possibly here? where i argued with stevenroose about the API complexity and he eventually convinced me 07:24 < andytoshi> but i could be convinced again :P 07:25 < andytoshi> 17:26 < jeremyrubin> i am not smart enough to figure out how to write bare miniscript :) 07:25 < andytoshi> sure me neither :) but i'm ok with asking the compiler once to give me a miniscript 07:25 < andytoshi> and then copy/pasting that forever 07:27 < stevenroose> dariosior, yeah it's to avoid having to deserialize effectively twice. when using value, the result is parsed into a BTreeMap and then lateron it's usually parsed into a struct, which allocates a lot of data twice. just keeping the raw JSON reduces that to only the latter allocation 07:28 < stevenroose> dariosior, what is the practical problem you have with RawValue? you can use `.get()` on it to get a `&str` to use with `serde_json::from_str` 08:03 < BlueMatt> ariard: are you ready for review on the packagetemplate refactor? 08:19 < elichai2> ideas for an easy way to get a full utxo set in rust? (right now I think about modifying bitcoin core to encode and dump the utxo set into a file and then use Encodable to deserialize it in rust) 08:33 < darosior> stevenroose: it's for server support for rust-jsonrpc, in order to derive Deserialize for Request. See https://github.com/apoelstra/rust-jsonrpc/pull/46 08:35 < darosior> andytoshi: yeah, isn't the cost very marginal? Will check the logs. Btw the CI stuff and the additional transports implementation PRs are ready for review, we tested the UDS transport with the GUI on Revault 08:38 < stevenroose> dariosor to be fair, the jsonrpc pieces that you need for a server impl are just those 2 struct definitions. You can easily just redo them 08:39 < stevenroose> the jsonrpc crate isn't all that magical, it has the struct definitions and then some ID-incrementing logic, but that's about it 08:39 < stevenroose> darosior: sorry mistyped your username ^ 08:42 < darosior> Yeah, i know. Just wanted to upstream it to not reinvent the wheel everywhere but hey maybe it's not worth it (though i need to read the logs to know what it really costs us to drop RawValue..) 08:55 < darosior> Also, accepting an object as params is kinda nice :/ 09:17 < stevenroose> andytoshi: released rust-bitcoinconsensus bump, btw 10:33 < BlueMatt> fucking cc I swear to god 10:33 < BlueMatt> updated to 2018 in a minor bump 10:33 < BlueMatt> cc is the most obnoxious fucking rust project 10:35 < BlueMatt> oh, wait, huh, why did our ci just start failing 2018 builds on 1.30 when it wasnt previously?! 10:45 < ariard> BlueMatt: yeah i've added a bunch of comments, let me push my branch before/after meeting 10:46 < BlueMatt> ariard: unless you have objections, I think I'm just gonna bump the MSRV to 1.36 - see https://github.com/rust-bitcoin/rust-bitcoin/issues/510 and also note that CI is currently failing because of....who knows why it suddenly decided to start failing to compile CC 10:48 < jeremyrubin> BlueMatt: \o/ 10:48 < BlueMatt> jeremyrubin: heh, I meant on rust-lightning, but, yea, see that issue, seems like there's some agreement to move to 1.36 everywhere over the summer. 11:31 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 245 seconds] 11:32 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin 11:40 < dr_orlovsky> andytoshi, stevenroos: thanks for releasing rust-bitcoinconsensus. It seems now we also have to release secp256k1 minor version to unblock https://github.com/rust-bitcoin/rust-bitcoin/pull/559 and open way for more standard derives in 0.26.1 11:40 < dr_orlovsky> * stevenroose 11:41 < dr_orlovsky> the same applies to bitcoin_hashes, due to https://github.com/rust-bitcoin/bitcoin_hashes/pull/110 12:56 < ariard> BlueMatt: yep you can take it, just acked it! 12:57 < BlueMatt> ariard: ok, thanks. 12:59 < ariard> BlueMatt: #894, good to me, cargo doc is okay locally 12:59 < BlueMatt> ariard: thank! 14:26 < ariard> BlueMatt: pushing update to packagetemplate in the coming ~30min! 14:26 < BlueMatt> thanks. may take a bit for me to get to it, but in a day or two I promise :) 14:26 < ariard> sweeeet! 15:07 -!- th0th [~th0th@gateway/tor-sasl/th0th] has joined #rust-bitcoin 15:10 -!- th0th1 [~th0th@gateway/tor-sasl/th0th] has quit [Ping timeout: 240 seconds] 15:24 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 265 seconds] 15:25 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin 15:38 -!- tibo [~tibo@p3002252-ipngn18401marunouchi.tokyo.ocn.ne.jp] has joined #rust-bitcoin 16:11 -!- th0th1 [~th0th@gateway/tor-sasl/th0th] has joined #rust-bitcoin 16:13 -!- th0th [~th0th@gateway/tor-sasl/th0th] has quit [Remote host closed the connection] 16:28 -!- th0th1 [~th0th@gateway/tor-sasl/th0th] has quit [Quit: Leaving] 16:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 16:42 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin 16:42 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 16:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 17:02 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 17:04 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 17:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 17:12 -!- belcher_ is now known as belcher 17:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 18:04 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 18:06 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 18:54 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 18:55 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 19:04 < BlueMatt> ariard: oh, can you update https://github.com/rust-bitcoin/rust-lightning/pull/845 ? 19:04 < BlueMatt> it got acks but has some comments on comments/error messages/etc 19:05 < BlueMatt> ariard: would be good to land it, i want to cut a release basically as soon as 893 and 895 land 19:37 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:37 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 19:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 20:36 -!- stevenroose [~steven@irc.roose.io] has quit [Quit: ZNC 1.7.4 - https://znc.in] 20:37 -!- stevenroose [~steven@irc.roose.io] has joined #rust-bitcoin 22:50 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 22:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 22:59 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 23:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 23:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 23:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] --- Log closed Tue Apr 27 00:00:38 2021