--- Log opened Tue Apr 27 00:00:38 2021
03:20 -!- Ashtyn86Schuster [~Ashtyn86S@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
05:31 -!- tibo [~tibo@p3002252-ipngn18401marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]
05:31 -!- tibo [~tibo@2400:4050:2a83:7000:b18d:e4d2:a2b8:e453] has joined #rust-bitcoin
05:31 -!- tibo [~tibo@2400:4050:2a83:7000:b18d:e4d2:a2b8:e453] has quit [Remote host closed the connection]
05:32 -!- tibo [~tibo@2400:4050:2a83:7000:b18d:e4d2:a2b8:e453] has joined #rust-bitcoin
05:36 -!- tibo [~tibo@2400:4050:2a83:7000:b18d:e4d2:a2b8:e453] has quit [Ping timeout: 250 seconds]
06:00 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
06:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:20 -!- michaelfolkson2 [~michaelfo@2a03:b0c0:1:e0::23d:d001] has joined #rust-bitcoin
11:23 -!- justinmoon_ [~quassel@157.245.122.126] has joined #rust-bitcoin
11:28 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-bfdgxtvcnzbdjfck] has quit [Ping timeout: 276 seconds]
11:28 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 276 seconds]
11:28 -!- michaelfolkson [~michaelfo@2a03:b0c0:1:e0::23d:d001] has quit [Ping timeout: 276 seconds]
11:28 -!- justinmoon [~quassel@157.245.122.126] has quit [Ping timeout: 276 seconds]
11:28 -!- evalr [~evalr@malta1854.startdedicated.net] has quit [Ping timeout: 276 seconds]
11:28 -!- evalr [~evalr@malta1854.startdedicated.net] has joined #rust-bitcoin
11:30 < ariard> BlueMatt: yeap will fix 845 today, good will try to review at least one of 893/895
11:31 < BlueMatt> thanks!
11:31 < ariard> added a bunch of unit tests in packagetemplate, still want to add moar
11:31 < BlueMatt> :100:
11:31 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-zljpxidnvrneehli] has joined #rust-bitcoin
11:31 < BlueMatt> thanks for sticking with that one!
11:31 < BlueMatt> so much nicer internal api
11:32 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin
11:33 -!- Ashtyn86Schuster [~Ashtyn86S@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
11:33 < ariard> BlueMatt: yes getting me in a mood to pursue further #619 :)
11:33 < ariard> actually i think i can start on it as soon as #642 is landed
11:34 < ariard> rest of anchor output won't conflict with generic channels
11:34 < BlueMatt> oooooooo
11:34 < BlueMatt> very noice
11:34 < BlueMatt> man I wish I had time to do fun things anymore lol
11:35 < ariard> i feel the same, i've not written big stuff in RL for a while
11:36 < ariard> once i'm done with anchor i'll try to allocate more time on review, might free up time to scratch code again :)
11:41 < BlueMatt> heh, yea, there's just also a huge backlog of things that need done for potential users, but lots and lots is bindings stuff or otherwise tons of api cleanup that is great, but not exactly exciting :)
12:07 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 245 seconds]
12:08 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #rust-bitcoin
13:26 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Quit: jonatack]
13:48 < BlueMatt> ariard: if you get a chance before bed, I'd ideally love to land https://github.com/rust-bitcoin/rust-lightning/pull/893 today or early tomorrow.
14:08 -!- michaelfolkson2 is now known as michaelfolkson
15:00 < andytoshi> darosior: i'm having a lot of trouble accepting rust-jsonrpc PRs that have a ton of rustfmt stuff in them
15:00 < andytoshi> i don't like rustfmt at the best of times, but this is the worst ratio of bad changes to tolerable changse i've ever seen
15:01 < andytoshi> dr_orlovsky: to be clear, you need a new bitcoin_hashes release and also a new rust-secp release?
15:06 < andytoshi> dr_orlovsky: we can't do a new minor bitcoin_hashes release because we removed schemars since the last one, which is a breaking change
15:18 < andytoshi> minor secp release https://github.com/rust-bitcoin/rust-secp256k1/pull/297
15:19 < andytoshi> idk what to do about bitcoin_hashes :( probably we should just do a minor release and say that removing schemars was a bugfix
15:19 < andytoshi> because it's been 4 months since it was removed and somehow nobody has managed to re-insert it in a way that passes CI
15:24 < andytoshi> also can I have a second reviewer for #589
15:36 < ariard> BlueMatt: hmmmmm full_stack is failing on master (36570f4) ?
15:37 < ariard> thouhgt it was #845 but apparently not, got a Bad MAC error
15:37 < ariard> though #845 *might* break it also but that sounds separate
15:38 < ariard> BlueMatt: lmk what you think about it, will review 893 meanwhile
15:40 < BlueMatt> ariard: you mean locally? try the two full_stack_target commits from https://github.com/rust-bitcoin/rust-lightning/pull/892
15:40 < BlueMatt> oh bad mac, hmmm, thats strange, can you send the failing test case if 892 doesnt fix it?
15:40 < ariard> BlueMatt: yep locally
15:41 < ariard> looking 892
15:41 < BlueMatt> oh i see its in ci, let me take a look
15:41 < BlueMatt> oh, wait, no, thats test_no_existing_breakage, thats not a fuzz failure?
15:42 < ariard> yeah exactly test_no_existing_breakage in full_stack
15:42 < BlueMatt> hmmm, that doesnt fail on current main/master?
15:43 < ariard> hmmm 892 is failing locally
15:45 < BlueMatt> oh? which fuzz/test?
15:46 < ariard> yeah fuzz/test is this expected
15:47 < BlueMatt> hmmm, no, didnt in ci, let me look
15:47 < BlueMatt> did you rebase it or anything?
15:47 < BlueMatt> did you forget RUSTFLAGS="--cfg=fuzzing" ?
15:49 < ariard> ah... we need RUSTFLAGS="--cfg=fuzzing" since when ?
15:49 < BlueMatt> since a whilte, but not that long
15:49 < BlueMatt> like maybe a few weeks?
15:49 < BlueMatt> also libsecp did it first, sooooo
15:49 < BlueMatt> i blame andrew
15:49 < ariard> yeah have run fuzzing in that time
15:49 < ariard> loool
15:49 < ariard> *have not
15:52 < ariard> BlueMatt: you're lucky it fixed it :p
15:52 < BlueMatt> lol, phew
15:52 < ariard> will leave a review on 893 before bed and fix in consequence 845 tmrw
15:53 < BlueMatt> ok, thanks lol
15:53 < BlueMatt> get some sleep, too, yo
16:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
16:42 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
16:42 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
16:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
17:02 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
17:04 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
17:07 -!- belcher_ is now known as belcher
17:14 < ariard> BlueMatt: see already comments, i'll finish tmrw
17:15 < ariard> main grief so far, maybe we should bound last_node_announcement_serial with some expecations on block interval
17:23 < BlueMatt> thanks!
17:23 < BlueMatt> yea...i mean we just assume its not called more than once a second, right?
17:23 < BlueMatt> like, its just the max time we've seen, which cant be more than 2 hours in the future per bitcoin consensus rules
17:23 < BlueMatt> so as long as users arent incrementing it like crazy, should be no issue, no?
17:39 -!- tibo [~tibo@2400:4050:2a83:7000:d059:b863:2da7:b9f9] has joined #rust-bitcoin
19:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
--- Log closed Wed Apr 28 00:00:39 2021