--- Log opened Wed Apr 28 00:00:39 2021
00:31 < darosior> andytoshi: re rustfmt: yeah i don't like its formatting either, though i like its consistency. The only reason i added its linter in the CI is that we previously had it (with the addition of a rustfmt.toml) but it was not respected. Will drop the CI linter check and rustfmtification commit, i couldn't care less :)
00:51 -!- rich is now known as paultroon
00:52 -!- paultroon [rich@2600:3c00::f03c:92ff:fe8e:dce6] has left #rust-bitcoin ["Leaving..."]
00:52 -!- paultroon [rich@2600:3c00::f03c:92ff:fe8e:dce6] has joined #rust-bitcoin
01:19 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #rust-bitcoin
01:41 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-tusdyyngpkygpbiy] has quit [Quit: Bridge terminating on SIGTERM]
01:41 -!- rodentrabies [rodentrabi@gateway/shell/matrix.org/x-snlrtilgznnhfwmy] has quit [Quit: Bridge terminating on SIGTERM]
01:41 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-blxwwhnewjrneslj] has quit [Quit: Bridge terminating on SIGTERM]
01:41 -!- zkao [zkaomatrix@gateway/shell/matrix.org/x-wqmscdseqgocpdnh] has quit [Quit: Bridge terminating on SIGTERM]
01:41 -!- fast1[m] [fast1priva@gateway/shell/matrix.org/x-mivftinsvbbbznba] has quit [Quit: Bridge terminating on SIGTERM]
01:41 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-zljpxidnvrneehli] has quit [Quit: Bridge terminating on SIGTERM]
01:52 -!- fast1[m] [fast1priva@gateway/shell/matrix.org/x-frptzlxjthnaaomf] has joined #rust-bitcoin
02:17 -!- rodentrabies [rodentrabi@gateway/shell/matrix.org/x-bkqbmzhvkmsswxix] has joined #rust-bitcoin
02:17 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-ffhuimjqrifccnpa] has joined #rust-bitcoin
02:17 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-sgdrymxrtfyrvqyv] has joined #rust-bitcoin
02:17 -!- Thomas[m]4 [thomaseizi@gateway/shell/matrix.org/x-hxsnytpylsvpqrsh] has joined #rust-bitcoin
02:17 -!- zkao [zkaomatrix@gateway/shell/matrix.org/x-bkkuwhqeqorofpsw] has joined #rust-bitcoin
02:23 -!- stevenroose [~steven@irc.roose.io] has quit [Ping timeout: 252 seconds]
02:24 -!- stevenroose [~steven@irc.roose.io] has joined #rust-bitcoin
03:03 < stevenroose> darosior: yeah I struggle with rustfmt as well. I really dislike it's choices and I feel that Rust is just generally a quote complex language which makes formatting choices really helpful to make code more readable.
03:04 < stevenroose> When I used Go, I always used gofmt because Go is so simple and the gofmt format would just always be optimal
03:04 < stevenroose> But I disagree with preaches of consistency over readability generally.
03:23 -!- Rahul63Bernier [~Rahul63Be@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
05:12 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
05:17 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
05:34 -!- tibo [~tibo@2400:4050:2a83:7000:d059:b863:2da7:b9f9] has quit [Remote host closed the connection]
05:35 -!- tibo [~tibo@2400:4050:2a83:7000:d059:b863:2da7:b9f9] has joined #rust-bitcoin
05:40 -!- tibo [~tibo@2400:4050:2a83:7000:d059:b863:2da7:b9f9] has quit [Ping timeout: 276 seconds]
05:54 < dr_orlovsky> andytoshi: > to be clear, you need a new bitcoin_hashes release and also a new rust-secp release?
05:54 < dr_orlovsky> correct
05:56 < dr_orlovsky> ACKed on minor Secp256k1 release
05:57 -!- Rahul63Bernier [~Rahul63Be@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
05:58 < dr_orlovsky> elichai, stevenroose, sgeisler: any of you, can pls review https://github.com/rust-bitcoin/rust-bitcoin/pull/589 to get it into 0.26.1 and do a small step towards taproot :) ?
05:59 < dr_orlovsky> andytoshi: from what I see jeremyrubin updated his PR to introduce schemars and make it pass CI: https://github.com/rust-bitcoin/bitcoin_hashes/pull/117
05:59 < dr_orlovsky> so I assume we can do a non-API breaking minor bitcoin_hashes release once we get his PR merged?
06:51 < stevenroose> dr_orlovsky: acked. let's wait for a third ack since it's a significant API change
06:53 < andytoshi> sure, +1 on waiting for a third ack
08:19 < jeremyrubin> thanks :)
08:23 < BlueMatt> ariard: lmk if you have any further comments on https://github.com/rust-bitcoin/rust-lightning/pull/893, I'd love to get it merged today and ship a new java bin to folks waiting on it :)
09:54 < ariard> BlueMatt: my concern was about increments triggerable by a counterparty
09:55 < ariard> yeah will do a review the essentials today, if PR have more shortcoming we can address them in follow-ups :) ?
10:46 < BlueMatt> ariard: right, fair enough. I added a new variable to track the highest time, so its no longer incrementable
10:46 < BlueMatt> ariard: and, yea, can always do a followup, just as long as its not broken :)
11:01 < dr_orlovsky> andytoshi: schnorr keys now have 3 acks in https://github.com/rust-bitcoin/rust-bitcoin/pull/589, so ready to be merged
11:18 < dr_orlovsky> stevenroose: if you can update your PR with CI fixes from my suggestion, you may get it to 0.26.1: https://github.com/rust-bitcoin/rust-bitcoin/pull/509
11:36 < stevenroose> dr_orlovsky: rebased that and fixed the 1.29 errors
11:48 < dr_orlovsky> stevenroose: thank you!
14:16 < ariard> BlueMatt: lol already merged #893? anyway finishing review on it
14:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
16:33 < ariard> BlueMatt: only new comment i would be glad to get your opinion : https://github.com/rust-bitcoin/rust-lightning/pull/893#discussion_r622623726, otherwise post-merge acked it :)
16:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
16:43 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
16:43 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
16:43 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
17:02 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
17:02 < ariard> yep as expected #845 is introducing a new full_stack_target failure, differing from #902, fixing this
17:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
17:06 -!- belcher_ is now known as belcher
17:14 < BlueMatt> ariard: well, two acks and I'll merge. but I'm always more than happy to do followups :)
17:22 < ariard> BlueMatt: right i've still in mind the crash introduced by #838 we missed to see at first :)
17:22 < ariard> just acked a bunch of small prs, if you want to take them
17:22 < BlueMatt> heh, right...luckily the fuzzer found it almost immediately
17:22 < ariard> MOAR fuzzing
17:22 < BlueMatt> :+1:
17:24 < BlueMatt> ariard: thanks, just got back from dinner, will merge a few things
17:24 < ariard> oky, bed, back tmrw with #845 as target
17:24 < ariard> BlueMatt: #642 still wait review ;)
17:24 < BlueMatt> thanks!
17:25 < BlueMatt> oh, right, somehow I'd confused myself on your last comment, anyway, i didnt have time today anyway. tomorrow should be a bit quieter depending on how quickly I can finish up binindgs for invoice which is priority 1
21:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
22:01 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
22:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
22:14 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
--- Log closed Thu Apr 29 00:00:40 2021