--- Log opened Mon May 10 00:00:51 2021
01:12 -!- belcher_ is now known as belcher
01:33 -!- fiatjaf [~fiatjaf@2804:7f2:298d:1e20:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 250 seconds]
01:35 -!- fiatjaf [~fiatjaf@2804:7f2:2a8f:67a2:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
03:18 -!- Sanford83Koch [~Sanford83@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
04:03 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 260 seconds]
04:23 -!- darosior [~darosior@194.36.189.246] has joined #rust-bitcoin
05:02 -!- tibo_ [~tibo@2400:4050:2a83:7000:8447:630:c6ec:3423] has joined #rust-bitcoin
05:05 -!- tibo [~tibo@2400:4050:2a83:7000:b47d:4149:fe87:6752] has quit [Ping timeout: 245 seconds]
05:38 -!- tibo_ [~tibo@2400:4050:2a83:7000:8447:630:c6ec:3423] has quit [Remote host closed the connection]
07:51 -!- Sanford83Koch [~Sanford83@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 252 seconds]
08:24 < BlueMatt> andytoshi: what is your take on https://github.com/rust-bitcoin/bitcoin_hashes/pull/127 ?
08:28 < BlueMatt> specifically, also, is there a *better* place to put the Read/Write traits added there to bitcoin_hashes.
08:28 < BlueMatt> maybe sgeisler has an opinion
08:36 < elichai2> I'm mostly sad this isn't fixed by the standard library yet
08:36  * elichai2 sigh
08:36 < BlueMatt> yea, no shit
08:36 < BlueMatt> its getting to the point of being embarassing
08:37 < elichai2> maybe we can have our own Read/Write traits, and cfg on std also implement the official ones?
08:37 < sgeisler> BlueMatt: without creating another crate/dependency? I don't think so. When it comes to 126 vs. 127 I don't have an educated opinion yet, just a slight preference for 126 as it avoids the associated type which might become ugly for generic code (yet another type parameter). One way to fix the custom error problem in 126 would be adding a `Custom(Box<dyn Any>)` variant.
08:37 < BlueMatt> elichai2: yea, that's basically what bitcoin_hashes 127 is
08:37 < BlueMatt> sgeisler: hmmm, custom box any kinda sucks, tho
08:38 < BlueMatt> sgeisler: yea, I'm trying to figure out exactly how all this looks in rust-bitcoin. in bitcoin_hashes itself it seems 127 is nice enough, but i need more examples to really grok it
08:38 < sgeisler> sure, would only be a cop-out
08:39 < BlueMatt> 127 feels closer to "its just the std write trait"
08:39 < sgeisler> idk where exactly we'd want custom errors given that we currently don't have them with std
08:39 < BlueMatt> right
08:39 < sgeisler> that's true, or "what std::io::Write should have been"
08:39 < elichai2> BlueMatt: does it give the "real" Read/Write when std is available?
08:40 < sgeisler> but for our use case the more limited version might be preferable, idk
08:40 < sgeisler> yeah, blanket impl afaik
08:40 < BlueMatt> elichai2: yes, it implements the custom trait for real std
08:40 < BlueMatt> lol i cant even build core2 on my local rustc
08:40 < BlueMatt> what garbage
08:50 < BlueMatt> ugh, I wish there were a way in cargo.toml to say "if core2 && std -> require core2/std"
08:53 < BlueMatt> ah, i dont think this blanket impl is the right "direction" anyway
11:14 -!- valwal [~valwal@96.224.58.144] has joined #rust-bitcoin
12:37 -!- zkao is now known as _zkao
13:16 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 240 seconds]
14:12 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #rust-bitcoin
16:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
16:41 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
16:41 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
16:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
17:01 < Thomas[m]4> Before I embarrass myself by commenting on the PR, why do we need our own switch between std and core2 at all? core2 already has a `std` feature that does a pass-through to `std::io`: https://github.com/bbqsrc/core2/blob/4072d2a09ba0d656571b1cd2ef6d95aa575c4a69/src/io/mod.rs#L16-L19
17:01 < Thomas[m]4> Can we not use that?
17:07 -!- tibo [~tibo@2400:4050:2a83:7000:5128:d9d1:982c:43a2] has joined #rust-bitcoin
20:38 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
20:41 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
22:16 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection]
22:17 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #rust-bitcoin
22:27 -!- junderw [sid43070@gateway/web/irccloud.com/x-dospwhfotlegwzaz] has quit [Read error: Connection reset by peer]
22:27 -!- junderw [sid43070@gateway/web/irccloud.com/x-fytwzaqcolbavnbm] has joined #rust-bitcoin
22:27 -!- justinmoon_ [~quassel@157.245.122.126] has quit [Quit: No Ping reply in 180 seconds.]
22:28 -!- evalr [~evalr@malta1854.startdedicated.net] has quit [Remote host closed the connection]
22:28 -!- evalr [~evalr@malta1854.startdedicated.net] has joined #rust-bitcoin
22:29 -!- justinmoon [~quassel@157.245.122.126] has joined #rust-bitcoin
--- Log closed Tue May 11 00:00:51 2021