--- Log opened Fri May 14 00:00:54 2021
00:11 -!- rich is now known as paultroon
01:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
01:32 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
01:37 -!- Thomas[m]4 [thomaseizi@gateway/shell/matrix.org/x-xppbdcblfqtgukuu] has quit [Ping timeout: 245 seconds]
01:38 -!- h4sh3d[m] [h4sh3dmatr@gateway/shell/matrix.org/x-nobgmzafrrohffdq] has quit [Ping timeout: 245 seconds]
01:38 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-viqzixvzipkwvstl] has quit [Ping timeout: 245 seconds]
01:41 -!- h4sh3d[m] [h4sh3dmatr@gateway/shell/matrix.org/x-rofjzvzlxvwejrge] has joined #rust-bitcoin
01:47 -!- Thomas[m]4 [thomaseizi@gateway/shell/matrix.org/x-alqwpfttthsveuhr] has joined #rust-bitcoin
01:48 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-gksanplnrelnxsbu] has joined #rust-bitcoin
02:24 -!- justinmoon [~quassel@157.245.122.126] has quit [Quit: No Ping reply in 180 seconds.]
02:25 -!- justinmoon [~quassel@157.245.122.126] has joined #rust-bitcoin
02:54 < dr-orlovsky> andytoshi: I am really sorry for bothering you, but are there any chances of processing with 0.26.1 in a foreseeable future?
03:18 -!- Christa17Larson [~Christa17@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
05:47 -!- tibo [~tibo@2400:4050:2a83:7000:297e:1d46:2f20:5bd9] has quit []
06:01 -!- otoburb [~otoburb@unaffiliated/otoburb] has quit [Quit: leaving]
06:01 -!- otoburb [~otoburb@unaffiliated/otoburb] has joined #rust-bitcoin
06:03 -!- otoburb [~otoburb@unaffiliated/otoburb] has quit [Client Quit]
06:05 -!- otoburb [~otoburb@unaffiliated/otoburb] has joined #rust-bitcoin
06:15 -!- otoburb [~otoburb@unaffiliated/otoburb] has quit [Quit: leaving]
06:16 -!- otoburb [~otoburb@unaffiliated/otoburb] has joined #rust-bitcoin
08:19 < BlueMatt> ariard: hey, whats your status on 642? I'd like to do transaction broadcast-at-locktime-expire on top of it, but if we want to land both by the end of the month we're running out of time. I could do it not on top of 642, but that would probably conflict pretty heavily which I dont want to do either...
08:19 < BlueMatt> also just generally landing 642 by end of the month is gonna require some rapid turnaround on review
09:55 < ariard> BlueMatt: yep just finish an overall parse on #851, fixing back #642 comments in the crowd
09:56 < ariard> I know, I know gonna pin #642 on top of my todo :)
09:56 < BlueMatt> ariard: alright, thanks a ton. sorry about the rush here.
09:58 -!- Christa17Larson [~Christa17@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 268 seconds]
10:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:17 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
13:28 -!- willcl_ark [~quassel@unaffiliated/willcl-ark/x-8282106] has quit [Quit: Quit]
13:30 -!- willcl_ark [~quassel@unaffiliated/willcl-ark/x-8282106] has joined #rust-bitcoin
16:28 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Quit: Changing server]
16:29 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #rust-bitcoin
16:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
16:42 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
16:42 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
16:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
17:45 < ariard> BlueMatt: addressed all your comments except this one https://github.com/rust-bitcoin/rust-lightning/pull/642#discussion_r631343922, i'm leaning more towards a new RevokedHTLCOutput
17:45 < ariard> instead of yet-another one level of enum
17:45 < ariard> though weight detection can embedded in constructor to remove layer violation ofc
17:52 < BlueMatt> ariard: can we at least add different constructors for RevokedOutput so that the if (is of type X) { VALUE_X } blocks go away?
17:52 < BlueMatt> it just feels like such a layer violation
18:02 < ariard> BlueMatt: you mean CounterpartyHTLCOutput to dissociate between timeout/preimage witness weight? well i can add a new enum there too
18:03 < ariard> we have output-level constructors, one per enum and *a* package-level constructor
18:04 < BlueMatt> ariard: hmm? no, like you call RevokedOutput::build in several places, all one constructor, with different arguments based on the type of output. can you instead split build into three or four different functions, which accept different arguments based on the type of output
18:04 < BlueMatt> that way the internals of RevokedOutput dont matter to ChannelMonitor at all
18:04 < BlueMatt> and then you dont have to pass in the weight amount at all, and can drop the Option<HTLC> in some cases
18:06 < ariard> BlueMatt: right in channlemonitor there is only one RevokedOutput for now, i can split it as RevokedOutput/RevokedOfferedOutput/RevokedAcceptedOutput?
18:07 < ariard> it's just a bit of code duplication in onchain_utils for struct which are almost similar, but should achieve to avoid passing the weight, and removing Option<HTLC>
18:07 < BlueMatt> right, RevokeOutput::build_from_to_remote, RevokedOutput::build_from_offered_htlc, RevokedOutput::build_from_received_htlc
18:07 < BlueMatt> instead of RevokedOutput::build
18:07 < ariard> yep i'm good with it
18:07 < BlueMatt> yea, i mean its not ideal on the other end, but I just *hate* exposing the WEIGHT_REVOKED... constants and using them in channelmonitor
18:07 < BlueMatt> feels so gross
18:08 < ariard> yeah but at second look InputDescriptors were gross too and that's the still what we have on current master
18:08 < BlueMatt> yea, but if we're cleaning it up, lets clean it up :)
18:09 < ariard> but better to remove any output attribute export in channelmonitors :)
18:19 -!- fiatjaf [~fiatjaf@2804:7f2:2a8f:67a2:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
18:21 -!- fiatjaf [~fiatjaf@2804:7f2:2a8f:67a2:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
18:22 < BlueMatt> ariard: can you go ahead and squash the fixups?
18:22 < BlueMatt> ariard: then with new constructors I'll take a look over the weekend
18:22 < BlueMatt> (fwiw, fixup commits at the end instead of right beside the commit they fix up make it pretty hard to review imo)
19:30 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
19:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
--- Log closed Sat May 15 00:00:55 2021