--- Day changed Tue Apr 18 2017 05:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 05:47 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #secp256k1 05:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #secp256k1 05:56 < Chris_Stewart_5> Does some one mind reviewing the Java api enhancements I made to secp256k1? 05:56 < Chris_Stewart_5> https://github.com/bitcoin-core/secp256k1/pull/443 08:27 -!- jtimon [~quassel@9.31.134.37.dynamic.jazztel.es] has joined #secp256k1 12:29 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 12:29 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #secp256k1 16:45 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 16:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #secp256k1 17:56 -!- jtimon [~quassel@9.31.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 22:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 22:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #secp256k1 22:31 < gmaxwell> https://bitcointalk.org/index.php?topic=1875417.0 I wonder if there is a tidy way we can set things up so people can't #include the .c file then call all the internal functions? 22:32 < gmaxwell> (without calling some I know what I'm doing define.) 22:38 < indutny> gmaxwell: just add `#define SECP256K1_INTERAL` in header 22:39 < indutny> or better NO_INTERNAL 22:39 < indutny> regardless 22:39 < indutny> you can add a define 22:39 < indutny> and error if it is present not-present 22:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 22:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #secp256k1 22:54 < gmaxwell> the header reates the prototypes for the rest, so we don't want to make the header a trap. I suppose the .c could just require that SECP256K1_BUILD be defined and have the build system do it. "#error "this is a library, you link it."" 22:54 < indutny> yeah, this is what I meant 22:55 < indutny> sorry, it is pretty late and I'm tired 22:56 < indutny> it would be fun if .c file without defines would result in all functions being no-ops 22:56 < indutny> this will totally screw the benchmarks :D