--- Log opened Sat May 25 00:00:22 2019 00:56 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Ping timeout: 258 seconds] 00:58 -!- real_or_random [~real_or_r@173.249.7.254] has joined #secp256k1 02:05 < gmaxwell> real_or_random: I'm going to merge #596 after I finish testing and another review cycle. But I think in the long run we'll want to cut the options down to three or four window sizes-- I'm realizing that this is a real testing burden. :) 02:05 < gmaxwell> In theory if the code works on two sizes its probably fine on all of them, but thats generally a lower standard of testing than we normally have. 02:06 < gmaxwell> I think having more options is good right now, since it'll be useful in tuning other things though. 02:07 < gmaxwell> but running the test 240 times for all the sensible relevant compile configs takes a long time, even on a fast tr2 host. It's unreasonable to test all the configs on smaller systems like arm or riscv. 04:30 < real_or_random> makes sense, yes 04:44 < gmaxwell> I think I want to get #566 merged next unless there are objections. 04:47 < real_or_random> yes, it just needs a small rebase now (#596 introduced an overflow check for the number of bytes we allocate) 04:48 < real_or_random> gmaxwell: is it fine that I force-push to squash and rebase in one step (or does this create more reviewing work for you)? 04:50 < gmaxwell> thats fine. 04:56 < gmaxwell> and good, the issues / PRs forces are once again balanced. 05:02 < real_or_random> and again 42, I noticed that too 05:27 < gmaxwell> real_or_random: thanks for the rebase, I'll finish my final review in a after I wake up in 7 or so hours then hopefully get it merged 05:27 < real_or_random> k thanks 05:46 < gmaxwell> sipa: Please review/merge my trivial PR#627 when you get a chance. 06:34 -!- afk11- [~afk11@79.97.107.223] has joined #secp256k1 06:34 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Quit: Leaving] 06:34 -!- afk11- [~afk11@79.97.107.223] has quit [Remote host closed the connection] 06:34 -!- afk11 [~afk11@79.97.107.223] has joined #secp256k1 06:35 -!- afk11 [~afk11@79.97.107.223] has quit [Client Quit] 06:35 -!- afk11 [~afk11@79.97.107.223] has joined #secp256k1 06:35 -!- afk11 [~afk11@79.97.107.223] has quit [Changing host] 06:35 -!- afk11 [~afk11@unaffiliated/afk11] has joined #secp256k1 06:37 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Client Quit] 06:37 -!- afk11 [~afk11@unaffiliated/afk11] has joined #secp256k1 06:38 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Client Quit] 06:39 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #secp256k1 07:20 < andytoshi> rebased, resolved all conversations and removed checkpoints from https://github.com/bitcoin-core/secp256k1/pull/600 07:50 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Quit: Leaving] 08:06 -!- afk11 [twitch@unaffiliated/afk11] has joined #secp256k1 08:15 -!- afk11 [twitch@unaffiliated/afk11] has quit [Quit: WeeChat 2.4] 08:16 -!- afk11 [twitch@unaffiliated/afk11] has joined #secp256k1 08:40 -!- afk11 [twitch@unaffiliated/afk11] has quit [Quit: afk11] 08:43 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #secp256k1 08:44 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Client Quit] 08:45 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #secp256k1 10:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 248 seconds] 11:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1 12:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 13:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1 14:15 < gmaxwell> nickler: thanks for figuring out that the magic trigger was BE. 14:16 < sipa> is our LE32 macro broken? 14:17 < gmaxwell> or just missing someplace? 14:54 < gmaxwell> real_or_random: merged now, and balance restored post merge. 15:45 < gmaxwell> andytoshi: I'd like to get #600 merged next, potentially after #595 (which I think is good to go except for a rebase, a final post rebase review, and me testing on arm.) 15:52 < andytoshi> hiya, kkk, will rebase and fix nits now 15:53 < andytoshi> lol s/kkk/kk/ 15:53 < gmaxwell> man, I've seen people angry about rebasing, but the buring cross thing is something new. 15:54 < gmaxwell> uh oh, we're unbalanced, only 41 PRs. 15:54 < andytoshi> lolol 15:55 < gmaxwell> I found an issue to close, so all is good. 15:58 < andytoshi> ok. i'll have a rebase pushed in a couple minutes 15:59 < andytoshi> turns out threading an error callback into 4 different functions causes a lot of conflicts :) 16:04 < andytoshi> ok pushed. running my own tests now (`git rebase master -x 'make && ./tests 1' then running the test binaries under valgrind..) 16:43 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 248 seconds] 17:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 17:54 < gmaxwell> andytoshi: your tests leak memory 17:55 < gmaxwell> ==24942== 1,032 bytes in 1 blocks are definitely lost in loss record 1 of 1 17:55 < gmaxwell> ==24942== at 0x4C2CDCB: malloc (vg_replace_malloc.c:299) 17:55 < gmaxwell> ==24942== by 0x41A03E: checked_malloc (util.h:72) 17:55 < gmaxwell> ==24942== by 0x41A03E: secp256k1_scratch_create (scratch_impl.h:15) 17:55 < gmaxwell> ==24942== by 0x41A03E: secp256k1_scratch_space_create (secp256k1.c:199) 17:55 < gmaxwell> ==24942== by 0x41A03E: run_scratch_tests (tests.c:349) 17:55 < gmaxwell> ==24942== by 0x401487: main (tests.c:5207) 17:55 < andytoshi> really? not in my run 17:56 < andytoshi> what's your config line? 17:56 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #secp256k1 17:58 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 18:03 < andytoshi> oh, yeah, i see the leak. weird that i don't detect it 18:05 < andytoshi> fixed 18:05 < andytoshi> oh, i see, i'm just misreading the valgrind output, there's a leak 18:06 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #secp256k1 19:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1 19:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds] 21:45 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #secp256k1 21:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds] 22:46 < sipa> andytoshi: are you using libtool mode execute? --- Log closed Sun May 26 00:00:23 2019