--- Log opened Tue Jul 02 00:00:58 2019 02:54 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 05:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-wtugnzhiuhwionzc] has joined #secp256k1 07:05 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #secp256k1 09:18 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:45 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #secp256k1 10:14 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:30 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 260 seconds] 11:32 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #secp256k1 12:59 -!- hugohn [~textual@12.246.51.142] has joined #secp256k1 13:03 -!- hugohn [~textual@12.246.51.142] has quit [Client Quit] 13:20 -!- hugohn [~textual@12.246.51.142] has joined #secp256k1 13:22 -!- hugohn [~textual@12.246.51.142] has quit [Client Quit] 14:20 < elichai2> The default type of integer constants is signed int, right? 14:21 < sipa> https://en.cppreference.com/w/c/language/integer_constant 14:26 < elichai2> So if I understand correctly this might be Implementation defined(or even UB)? https://github.com/bitcoin-core/secp256k1/blob/master/src/scalar_low_impl.h#L41 (I know this is used only for exhaustive tests) 14:27 < sipa> i think we require int being at least 32 bits 14:31 < elichai2> so that mean that `1` should be at least 32 bits making it a defined shift. ok, thanks for the clarification :) 14:39 -!- instagibbs [~instagibb@pool-100-15-136-188.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds] 15:03 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 260 seconds] 15:08 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #secp256k1 16:08 -!- roconnor [~roconnor@host-184-164-26-154.dyn.295.ca] has joined #secp256k1 16:09 < roconnor> sipa: if the literal '1' is a signed integer and you shift it by 31 bits, doesn't it overflow and invoke UB? 16:14 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #secp256k1 16:15 < sipa> roconnor: i believe you may be right 16:17 < roconnor> Though I'm skeptical that bit get anywhere close to 31 in practice. 16:18 < roconnor> it is probably worth adding a 'u' to be safe. 18:44 -!- roconnor [~roconnor@host-184-164-26-154.dyn.295.ca] has quit [Ping timeout: 245 seconds] 20:10 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-wtugnzhiuhwionzc] has quit [Quit: Connection closed for inactivity] 21:37 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-lrbkpgqxdmbgzwgw] has joined #secp256k1 23:50 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-lrbkpgqxdmbgzwgw] has quit [Quit: Connection closed for inactivity] --- Log closed Wed Jul 03 00:01:00 2019