--- Log opened Thu May 13 00:00:53 2021
00:22 -!- jesseposner [~jesseposn@2601:645:200:162f:bcd4:42d8:7d4a:791f] has quit [Ping timeout: 245 seconds]
02:43 -!- belcher_ is now known as belcher
07:18 < roconnor> If we made all our VERIFY_CHECKs into “real assertions” in release builds, ie. assertions that invoke unreachable() if failed, would our performance improve?
07:26 < roconnor> I guess it isn't quite so easy since some VERIFY_CHECKs operate on fields that don't exist in release.
07:56 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/1e78c18d5b80552d15aa2e2e58348fc1b89b1e3b/src/group_impl.h#L264
07:56 < roconnor> The documentation for secp256k1_fe_equal_var suggest both inputs have to have magnitude 1; however only the first input needs to have magnitude 1.
07:57 < roconnor> thus this call to fe_normalize_weak could be eliminated.
07:57 < roconnor> But it is so very not critical, I'm not sure it is even worth PRing.
13:09 -!- Netsplit *.net <-> *.split quits: wallet42____
13:09 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-gvzybjnynswwkzyn] has joined #secp256k1
15:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
15:41 -!- belcher [~belcher@unaffiliated/belcher] has joined #secp256k1
16:05 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds]
16:19 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #secp256k1
16:32 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #secp256k1
16:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]
16:36 -!- lukedashjr is now known as luke-jr
21:19 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds]
21:21 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #secp256k1
--- Log closed Fri May 14 00:00:54 2021