--- Log opened Fri Jun 11 00:00:35 2021
02:02 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #secp256k1
02:40 -!- belcher_ is now known as belcher
06:08 < real_or_random> hm, I'm not entirely convinced. I think the entire scalar and group arithmetic can already be emulated using our API.
06:09 < real_or_random> pubkey_create,  pubkey_tweak_mul, seckey_tweak_mul, seckey_tweak_add and pubkey_combine should be enough
06:11 < real_or_random> something else: when looking into https://github.com/bitcoin-core/secp256k1/issues/776 (valgrind and memcpy) I found a way to fix this without replacing any assignment
06:13 < real_or_random> it's possible to add some code that talks to valgrind and allows us to modify how valgrind is performing the overlap check (essentially by wrapping memcpy when running on valgrind)
06:13 < real_or_random> this would allow us to still get full overlap checking for memcpy(dst, src, n) but just exclude the case dst == src 
06:15 < real_or_random> the only drawbacks are that it looks a little bit odd and that it requires the valgrind headers to be there at compile time (like for VG_CHECK for example). 
06:18 < real_or_random> this looks nicer to me than replacing every potentially bad struct assignment and keeping that exhaustive
06:19 < real_or_random> related to that question: I wonder if it would be fine to include their headers in our code base... valgrind is GPLed but they distribute the headers under a BSD-style license to encourage people to ship the headers
06:19 < real_or_random> (which would help us beyond that strange issue)
06:19 < real_or_random> https://sourceware.org/git/?p=valgrind.git;a=blob;f=memcheck/memcheck.h
06:21 < real_or_random> I don't think it's a big deal. It wouldn't be the only non-MIT file in our repo https://github.com/bitcoin-core/secp256k1/blob/master/build-aux/m4/ax_prog_cc_for_build.m4#L28 and similarly core has some GPLed m4 files (and maybe others?)
09:23 -!- meshcoll- [meshcollid@jujube.ircnow.org] has joined #secp256k1
09:26 -!- andytosh1 [~apoelstra@s66-183-0-205.bc.hsia.telus.net] has joined #secp256k1
09:31 -!- Netsplit *.net <-> *.split quits: meshcollider, andytoshi
10:14 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 244 seconds]
10:15 -!- luke-jr [~luke-jr@user/luke-jr] has joined #secp256k1
16:09 -!- jesseposner [~jesse@2601:647:0:89:a033:d06b:c178:5c11] has joined #secp256k1
21:33 -!- belcher_ [~belcher@user/belcher] has joined #secp256k1
21:36 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 244 seconds]
--- Log closed Sat Jun 12 00:00:35 2021