--- Log opened Fri Jan 07 00:00:23 2022
05:37 < elichai2> Any chance that mingw32-w64 doesn't define `_WIN32`? https://github.com/bitcoin-core/secp256k1/pull/748/checks?check_run_id=4739023346 
05:43 < sipa> you may need to check for both _WIN32 and WIN32
05:54 < elichai2> Hmm i'll try that after trying this https://sourceforge.net/p/mingw-w64/bugs/903/
05:56 < sipa> That suggests #include'ing <windows.h> before <bcrypt.h> ?
05:57 < elichai2> yeah
05:58 < sipa> That seems like the more likely solution.
06:06 < elichai2> is it a windows thing to use types from a different header without including that header?
06:06 < sipa> no, it's a bug in mingw-w64 i think
06:06 < sipa> which is why someone opened a bug report for it
06:09 < elichai2> Asked because this fixed 1 error but another one poped up for the same reason 😅 https://cirrus-ci.com/task/5381748275019776?logs=test#L140 (now I need to also include `ntstatus.h`)
06:10 < sipa> great
06:13 < elichai2> How are things in NY?
06:13 < sipa> Snowy.
06:15 < elichai2> ohh that sounds fun
06:19 < elichai2> damn it, now it can't find `BCryptGenRandom` at all, now I need to figure out how to conditionally link to libcrypt on windows only in automake :)
06:20 < sipa> But that's a link time failure?
06:20 < sipa> So it got further than before
06:20 < elichai2> yeah
06:21 < elichai2> I guess on the old CI it worked fine because it was metal windows and not mingw-w64
06:22 < fanquake> AC_CHECK_LIB([crypt], [some_func_in_crypt], [],  [AC_MSG_ERROR([crypt missing])])
06:22 < fanquake> something like that'll probably work in a configure script
06:34 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #secp256k1
06:35 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
06:35 -!- lukedashjr is now known as luke-jr
07:09 < elichai2> fanquake: Thanks! that actually works great but I can't use it because it links everything with libbcrypt and not just the needed binaries, anyway made it work with automake (mostly spent time making mingw building work on my machine so I'll stop testing in the CI lol)
09:13 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #secp256k1
09:14 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds]
09:15 -!- lukedashjr is now known as luke-jr
09:33 -!- dr_orlovsky [~dr-orlovs@31.14.40.18] has quit [Ping timeout: 268 seconds]
10:01 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #secp256k1
10:02 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds]
10:03 -!- lukedashjr is now known as luke-jr
23:53 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has quit [Ping timeout: 240 seconds]
23:54 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has joined #secp256k1
--- Log closed Sat Jan 08 00:00:24 2022