--- Log opened Wed Mar 16 00:00:27 2022 00:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:31 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 01:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 01:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 02:04 -!- halosghost [~halosghos@user/halosghost] has quit [Ping timeout: 250 seconds] 02:16 -!- halosghost [~halosghos@user/halosghost] has joined #secp256k1 03:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 04:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 04:42 -!- keymeta [~hidden@cpc97890-walt21-2-0-cust505.13-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 05:14 -!- roconnor [~roconnor@coq/roconnor] has joined #secp256k1 05:56 -!- hg [~halosghos@user/halosghost] has joined #secp256k1 06:02 -!- halosghost [~halosghos@user/halosghost] has quit [Ping timeout: 245 seconds] 06:03 -!- hg [~halosghos@user/halosghost] has quit [Ping timeout: 252 seconds] 06:05 -!- hg [~halosghos@user/halosghost] has joined #secp256k1 06:18 -!- halosghost [~halosghos@user/halosghost] has joined #secp256k1 06:37 < real_or_random> https://github.com/bitcoin-core/secp256k1/pull/1088 ok to merge? 06:47 < roconnor> still says: 06:47 < roconnor> CCLD libsecp256k1_precomputed.la 06:47 < roconnor> ar: `u' modifier ignored since `D' is the default (see `U') 06:47 < roconnor> but it builds for me. 07:01 < real_or_random> ok yeah that will disappear over time 07:01 < real_or_random> https://github.com/bitcoin/bitcoin/commit/b4d03be3cac04da8b5d5fa17e29c5220b75d970b fixed this in core and so far I was too lazy to port it 07:01 < real_or_random> newer libtool versions have better defaults 07:03 < roconnor> one bad thing is the following 07:03 < roconnor> checking whether make supports nested variables... (cached) yes 07:03 < roconnor> ./configure: line 3362: PKG_PROG_PKG_CONFIG: command not found 07:03 < roconnor> checking for gcc... gcc 07:03 < roconnor> which appears to be new in the ar branch. 07:04 < roconnor> oh wait nevermine 07:04 < roconnor> it was in the old build too, just in a different place. 07:06 < real_or_random> did you run ./autogen.sh after switching branches? 07:06 < roconnor> I just run nix-build 07:07 < roconnor> this error is probably due to my build system. 07:07 < real_or_random> lol apparently the other warning has been fixed in 2016 in libtool but they never did a release 07:08 < real_or_random> I mean, not that we're in a position to complain about this... 07:09 < real_or_random> if it builds for you (without new error message), you could leave an ACK saying this 07:14 < real_or_random> the PKG_PROG_PKG_CONFIG thing could be solved by installing pkg-config... maybe nix doesn't do this 07:14 < roconnor> I can add pkg-config 07:15 < roconnor> okay now it says 07:16 < roconnor> checking pkg-config is at least version 0.9.0... yes 07:16 < roconnor> but do you really use pkg-config? 07:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 07:30 < real_or_random> I think we use it to provide a pkg-config file for secp256k1 07:30 < real_or_random> but we don't rely on it for checking other package versions... it's a good question. maybe we used it in the past to discover openssl or gmp versions 07:31 < roconnor> Not sure. I've been building without pkg-config for years. 07:31 < real_or_random> and maybe the code here is just a relict that can be removed. I know ~0 about pkg-config, so I can't tell. It's probably easy to figure out 07:31 < roconnor> Anyhow, I'm not necessarily suggesting you change anything. 07:37 < real_or_random> Yeah but I think you're right. We don't need pkg-config to provide the file. shrug 08:33 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.4.1] 08:36 -!- hg [~halosghos@user/halosghost] has joined #secp256k1 08:40 -!- b10c [~quassel@user/b10c] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 08:43 -!- b10c [~quassel@user/b10c] has joined #secp256k1 08:46 < real_or_random> roconnor: https://github.com/bitcoin-core/secp256k1/pull/1090 08:52 < roconnor> :thumbsup: 08:52 < roconnor> I guess I don't need jdk in the build env either. 08:55 < real_or_random> hehe yeah 09:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:38 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Quit: Good day old chaps] 10:40 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #secp256k1 12:42 -!- fanquake [sid369002@user/fanquake] has quit [Ping timeout: 268 seconds] 12:45 -!- fanquake [sid369002@user/fanquake] has joined #secp256k1 14:59 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Quit: Good day old chaps] 15:00 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #secp256k1 15:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 15:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:30 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving] 16:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:53 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.4.1] 17:01 < cfields_> just saw the PKG_CONFIG discussion 17:02 < cfields_> IIRC it was used to find openssl, which isn't needed anymore 17:02 < cfields_> so unless I'm missing something, the PKG_PROG_PKG_CONFIG macro can be removed now. 17:02 < roconnor> makes sense. There is a good chance I was explicitly passing in the openssl location when I was building before. 17:04 < cfields_> I'll verify that and PR a removal tomorrow if true. 17:05 < cfields_> Oh, just saw 1090. 17:06 < cfields_> strike that. I'll verify and ACK #1090 tomorrow if true :) 18:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 19:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 23:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 --- Log closed Thu Mar 17 00:00:28 2022