--- Log opened Thu Mar 17 00:00:28 2022 01:17 < fanquake> Also nice if that leads to pruning more cruft in Core 01:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 01:28 -!- b10c [~quassel@user/b10c] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 01:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 01:32 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has joined #secp256k1 01:32 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has quit [Changing host] 01:32 -!- b10c [~quassel@user/b10c] has joined #secp256k1 03:45 < real_or_random> I was also used for gmp, not only openssl 03:48 < real_or_random> Do people have strong opinions on building with a C++ compiler? We currently have a C++ -fpermissive test on CI and that test needs a hack to circumvent a ./configure check. 03:49 < real_or_random> Now my MSVC PR removes this for better MSVC support (https://github.com/bitcoin-core/secp256k1/pull/1084). I wasn't really aware that also serves as a sanity check for C vs C++ compilers... 03:50 < real_or_random> I tend to replace this check with #ifdef __cplusplus #error (or #warn?). This will also make the circumvention in the CI less hackish 03:52 < real_or_random> Currently we pass CC=gcc to configure but CC=g++ to make, which creates all sorts of strange issues. With the #ifdef, we could just set CC=g++ normally. 03:53 < real_or_random> And either accept the #warning (we anyway we'll have tons of warning with C++), or pass -U__cplusplus to circumvent the #error 03:54 < sipa> -U__cplusplus sounds pretty horrible 03:55 < real_or_random> I wouldn't mind to make it an #error... The code is not really tested with C++ compilers. 03:55 < real_or_random> But some people apparently #include the library in their C++ code and we have semi-supported this in the past, so maybe #warning is more appropriate 03:56 < real_or_random> sipa: Yeah I was surprised that it works lol. But as I said, I think it's less horrible than the current CI hack 03:56 < real_or_random> which is "MAKEFLAGS: -j4 CC=g++ CFLAGS=-fpermissive\ -g" (Note the 03:57 < real_or_random> Note the \ for .yml quoting -.- 03:58 < real_or_random> The real problem I ran into was that I tried to run make distcheck for every CI job and then the MAKEFLAGS hack apparently isn't applied, so this fails. 03:59 < real_or_random> I mean we could just disable distcheck for C++ but that's another form of special casing then, just less ugly. 04:00 < real_or_random> Maybe #warning is the simplest. It won't make people that really want to use C++ compilers unhappy , and it will have the cleanest CI code. 04:02 < fanquake> Optimising for cleanest CI code, and users doing the "wrong" thing, as opposed to doing what you'd like doesn't seem that ideal. 04:02 < fanquake> Do you know who is apparently doing it? If it was never really supported, maybe now is a good time to tell them that it's going to break. 04:03 < fanquake> I ask because if it's only "apparently", maybe these users don't/no-longer exist. 04:04 < real_or_random> ok, yes, the only case that I'm aware of and where someone mentioned this is from 2015 ... https://github.com/bitcoin-core/secp256k1/pull/258 04:06 < real_or_random> And in general, I agree with this assessment. It's a C library and you should just compile it with C compiler. If you don't you're on your own, and the #error would emphasize this 04:06 < real_or_random> (And then if someone is using a C++ compiler, so they will complain. At least we know then... ^^) 04:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 04:33 < real_or_random> okay yeah -U__cplusplus actually won't work, that was a stupid idea. ^^ 04:51 < real_or_random> I'll probably introduce a TEST_OVERRIDE define, as we have it for WIDEMUL detection 05:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 05:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 06:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 06:20 -!- hg [~halosghos@user/halosghost] has joined #secp256k1 06:46 < sipa> right 07:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 07:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:07 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 08:13 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 08:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 09:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 09:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 11:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 11:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 12:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 12:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 13:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 13:51 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 14:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 14:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 15:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:17 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.4.1] 17:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 18:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 18:33 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:36 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 19:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 19:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 22:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 22:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 23:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 23:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 23:39 -!- Netsplit *.net <-> *.split quits: cfields_ 23:44 -!- Netsplit over, joins: cfields_ --- Log closed Fri Mar 18 00:00:29 2022