--- Log opened Fri Mar 25 00:00:36 2022 00:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 01:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 01:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 02:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:12 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 02:19 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 02:53 < real_or_random> :) 02:54 < real_or_random> robot-dreams: are you willing to open a tiny PR with the README change? (see my comment there) 02:58 < fanquake> 🚀 03:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 03:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:31 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 04:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 04:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 04:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 05:03 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 05:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 05:56 -!- halosghost [~halosghos@user/halosghost] has joined #secp256k1 06:21 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 06:30 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #secp256k1 06:33 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 272 seconds] 06:33 -!- lukedashjr is now known as luke-jr 06:53 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:54 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 07:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 07:16 < robot-dreams> real-or-random: Sure! See #1094 07:16 < sipa> real_or_random: I believe nanotube runs gribble. 07:18 < robot-dreams> (dash vs. underscore fail) 07:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 08:01 < real_or_random> robot-dreams: reviewed 08:04 < sipa> real_or_random: I found an easier-to-optimize write_be32(x), namely { uint8_t bytes[4] = {x>>24,x>>16,x>>8,x}; *(uint32_t*)out = *(uint32_t*)bytes; }. The downsides: (a) it's C99 (b) it's UB. 08:05 < roconnor> what does easier-to-optimize mean? 08:05 < sipa> The compiler realizing it can just issue a bswap instruction on platforms where that is available. 08:05 < sipa> Rather than computing every byte individually. 08:06 < roconnor> what is the alternative write_be32? 08:07 < sipa> https://github.com/bitcoin-core/secp256k1/pull/1093/files#diff-40ab92941994ec9418dbb76ae46d5aef0e4cb8b034f2be2b31562bb9aca8070fR325 08:10 < roconnor> sipa: your write_be32 has quite a bit different interface. 08:11 < sipa> let me godbolt it 08:11 < roconnor> oh wait nevermind 08:11 < roconnor> your out is a unsigned char pointer. 08:12 < roconnor> for which we pray to the alignment gods. 08:13 < real_or_random> lol I wanted to avoid the bikeshedding 08:13 < roconnor> I'm pretty sure sipa isn't being serious. 08:13 < sipa> Don't worry, I'll ACK as-is. I just wanted to explore if there weren't any strictly better ways available. 08:14 < sipa> There may be, but this isn't one of them. 08:14 < real_or_random> fwiw, it had this first https://gcc.godbolt.org/z/1soa3zWsz may make a good tweet :P 08:14 < real_or_random> can you find the bug? 08:14 < real_or_random> sipa: do you think I should add tests for the read and write functions? 08:16 < sipa> real_or_random: I'd hope there is no obviously-wrong way of writing these functions that is actually wrong. 08:16 < sipa> (where obviously-wrong would include cases like "if (x == 1337) { ... }") 08:17 < real_or_random> well I mean there's ways that work only on BE or LE machines 08:18 < roconnor> real_or_random: I'm pretty sure that if I trying to prove that buggy version correct in VST would fail. 08:19 < roconnor> ..if I were to try to prove that buggy version correct with VST it wouldn't let me... 08:19 < real_or_random> sure but what's the point? ^^ 08:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 08:20 < roconnor> oh the point is that VST proofs are actually fairly limited and will fail to catch many forms of UB. 08:21 < roconnor> Unfortunately the only guarentees VST makes is that the code will work correctly when compiled with CompCert. And CompCert defines all sorts of behaviour. 08:21 < real_or_random> ah I see 08:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 08:26 < real_or_random> and roconnor spotted the bug immediately (in dm), anyone else? :P 09:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 09:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 11:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 11:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 12:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 12:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 12:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 13:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 13:03 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 14:04 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.4.1] 14:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 14:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 15:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 15:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 16:34 -!- halosghost [~halosghos@user/halosghost] has joined #secp256k1 17:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 18:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 18:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 19:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 19:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:45 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.4.1] 21:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 22:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 22:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 23:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 --- Log closed Sat Mar 26 00:00:38 2022