--- Log opened Tue Jan 31 00:00:30 2023
00:21 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
01:02 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
02:10 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 260 seconds]
02:11 -!- midnight [~midnight@user/midnight] has joined #secp256k1
02:25 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
05:36 -!- roze_paul [~quassel@132.216.191.43] has joined #secp256k1
06:29 < hebasto> What are reasons to define the `SECP256K1_INLINE` macro in user's `include/secp256k1.h` header, while it is used internally only?
06:32 < hebasto> I mean, any other (or a new dedicated) header in `src`looks more appropriate, no?
06:35 < sipa> I think it may just predate any "utility" internal headers.
06:36 < hebasto> yes, the code is 8+ years old :)
06:42 < sipa> I think it makes sense to move it to util.h
06:42 < hebasto> agree
07:04 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/e1817a6f54faa20bc7f40d5a9a98a815bd6b6f57/src/modinv64_impl.h#L602
07:06 < roconnor> Putting a side effect in a macro parameter.  I also like to live dangerously.
07:10 < real_or_random> oh
07:11 < real_or_random> roconnor: maybe see https://github.com/bitcoin-core/secp256k1/pull/904 ...  
07:14 < roconnor> when is VERIFY defined?
07:16 < fanquake> -DVERIFY
07:16 < roconnor> like what configurations.
07:17 < roconnor> basically I'm confused by the ++i because it is a syntax error when the int i line doesn't exist.
07:20 < fanquake> Looks like only 1 CI:
07:20 < fanquake> env: {CTIMETESTS: no,    RECOVERY: yes, ECDH: yes, SCHNORRSIG: yes, CPPFLAGS: -DVERIFY}
07:21 < roconnor> it also appears in Makefile.am
07:21 < fanquake> Yea, seems whenever !ENABLE_COVERAGE
07:22 < sipa> roconnor: -DVERIFY is set for the tests and exhaustive_tests binaries always
07:22 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/8ebe5c520508aa789271a0185eae9358de0fd026/src/util.h#L92-L98
07:22 < sipa> recently there is noverify_tests which is the same code as tests, but without -DVERIFY
07:22 < sipa> and then there is the CI instance you mention which sets -DVERIFY even for the library code itself
07:22 < roconnor> suggests VERIFY_CHECK is only operational when VERIFY is defined.
07:24 < roconnor> wait no.
07:25 < roconnor> If VERIFY isn't defined then `#define VERIFY_CHECK(cond) do { (void)(cond); } while(0)`
07:25 < roconnor> I don't understand how this even compiles.
07:25 < sipa> there is an #ifdef VERIFY around the VERIFY_CHECK(++i < 12)
07:26 < roconnor> Ah.
07:27 < roconnor> because the checks are so expensive.
07:27 < roconnor> maybe..
07:28 < roconnor> I'm not sure what the creiterion is for wrapping the VERIFY_CHECKS inside VERIFY is.
07:28 < sipa> the idea is that you can write VERIFY_CHECK, and they'll be emitted even without -DVERIFY, to make sure they compile, but they should only be used for things that can obviously be optimized out
07:28 < sipa> when there are non-trivial function calls involved we wrap with #ifdef VERIFY, because we can't be sure 
07:28 < roconnor> I guess that dividing line is fuzzy.
07:29 < sipa> it is
07:29 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/e1817a6f54faa20bc7f40d5a9a98a815bd6b6f57/src/modinv64_impl.h#L146-L150
07:29 < roconnor> for example could be outside VERIFY, but meh.
07:29 < sipa> indeed
07:36 -!- roze_paul [~quassel@132.216.191.43] has quit [Ping timeout: 252 seconds]
07:36 -!- roze_paul [~quassel@132.216.191.43] has joined #secp256k1
07:37 -!- halosghost [~halosghos@user/halosghost] has joined #secp256k1
07:38 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
08:00 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
09:32 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:28 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
12:39 -!- roze_paul [~quassel@132.216.191.43] has quit [Remote host closed the connection]
12:57 -!- halosghost [~halosghos@user/halosghost] has quit [Read error: Connection reset by peer]
12:59 -!- halosghost [~halosghos@user/halosghost] has joined #secp256k1
14:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving]
14:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
15:04 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
15:57 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8]
17:37 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
17:45 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
23:59 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
--- Log closed Wed Feb 01 00:00:31 2023