--- Log opened Thu Mar 02 00:00:58 2023 00:01 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 00:09 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 04:01 -!- scg [~scg@200.68.161.199] has joined #secp256k1 04:28 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 04:53 -!- scg [~scg@200.68.161.199] has quit [Quit: Client closed] 05:06 -!- scg [~scg@200.68.161.199] has joined #secp256k1 05:18 -!- scg [~scg@200.68.161.199] has quit [Ping timeout: 260 seconds] 05:23 -!- scg [~scg@200.68.161.199] has joined #secp256k1 05:44 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 06:44 -!- scg [~scg@200.68.161.199] has quit [Quit: Client closed] 06:53 -!- scg [~scg@200.68.161.199] has joined #secp256k1 06:54 -!- scg [~scg@200.68.161.199] has quit [Client Quit] 06:55 -!- scg [~scg@187.252.193.153] has joined #secp256k1 07:55 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 08:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 08:06 -!- hg [~halosghos@user/halosghost] has joined #secp256k1 08:06 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 08:27 -!- scg [~scg@187.252.193.153] has quit [Quit: Client closed] 09:29 -!- scg [~scg@187.130.73.126] has joined #secp256k1 09:35 -!- scg [~scg@187.130.73.126] has quit [Quit: Client closed] 10:30 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 10:40 -!- scg [~scg@187.130.73.126] has joined #secp256k1 11:09 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 12:17 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.8] 12:39 -!- scg [~scg@187.130.73.126] has quit [Quit: Client closed] 12:51 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1 14:03 -!- pakaro [~quassel@142.243.254.224] has joined #secp256k1 14:10 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 14:16 < real_or_random> sipa: https://github.com/bitcoin-core/secp256k1/pull/943#discussion_r729889981 14:16 < real_or_random> remembering now 14:17 < sipa> Ahaaa! 14:19 < real_or_random> which is a bit arbitrary... we could have taken uint32_t, which is the smallest limb type 14:19 < real_or_random> but yeah, whatever 14:20 < sipa> uint8_t would also work 14:20 < sipa> but int suffices 14:20 < real_or_random> who will ever need numbers greater than 0x7FFF ? 14:20 < sipa> Yeah let's switch to secp15k1 14:20 < real_or_random> certainly not cryptographic implementations 14:21 < real_or_random> much faster for sure 14:21 < sipa> i mean it might be like 17 times less secure because it's smaller 14:21 < sipa> but just run it 17 times 14:22 < real_or_random> lol 14:22 < real_or_random> I wasn't sure how to articulate what confused me about https://github.com/bitcoin-core/secp256k1/pull/1118#discussion_r1122015946 14:22 < real_or_random> but I think I know now: the notation is somewhat non-standard 14:23 < sipa> I get that it's confusing, because those +- before the square roots ultimately don't matter. 14:23 < real_or_random> when I see multiple +-, I think they are synchronized 14:23 < sipa> Ah, I see. 14:23 < real_or_random> like +-5 * +-6 = 30 14:23 < real_or_random> and +-5 * -+6 = -30 14:24 < sipa> Would it be better to just drop them from the formulas, and add a footnote/comment that other signs work too. 14:24 < real_or_random> plus of course the fact that usual arithmetic rules for sqrts don't apply 14:25 < real_or_random> hmm, yeah, or just consider |y| instead of y 14:25 < real_or_random> oh no, that means we need to define |.| 14:25 < sipa> Actually, I think that the sqrt function (defined as sqrt(x) = x^((p-1)/4), is fully multiplicative. 14:26 < sipa> Though such a fully-multiplicative sqrt may not exist for every field, nor is it actually essential for the argument here that our sqrt happens to have that property. 14:27 < sipa> "function is fully multiplicative" meaning f(x)f(y) = f(xy) 14:27 < real_or_random> ok you're right 14:27 < sipa> Based on that, I think I'll just drop the +- and add a short comment. 14:27 < real_or_random> I guess you could also just write +- (y * sqrt(d^3*g^3)) and that will be less confusing already 14:27 < real_or_random> but I guess a comment is more explicit 14:28 < real_or_random> by the way, it took me at least 3 reviews of this PR to figure out why you choose n and d as variable names 14:32 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 14:39 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8] 14:51 -!- pakaro [~quassel@142.243.254.224] has quit [Ping timeout: 268 seconds] 14:54 < sipa> I made a few changes to the PR. 14:54 < sipa> (well, the comments) 15:56 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 16:01 -!- p2plife [~p2plife@vps-46773dd2.vps.ovh.net] has quit [Quit: quit] 16:03 -!- p2plife_ [~p2plife@vps-46773dd2.vps.ovh.net] has joined #secp256k1 17:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving] 17:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 20:11 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1 20:14 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 22:55 -!- Netsplit *.net <-> *.split quits: ajonas, ariard, jeremyrubin 22:56 -!- Netsplit over, joins: ajonas, jeremyrubin, ariard 23:44 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 --- Log closed Fri Mar 03 00:00:59 2023