--- Log opened Thu Apr 20 00:00:38 2023 01:40 < real_or_random> I think https://github.com/bitcoin-core/secp256k1/pull/1231 just needs a quick second review to get it off the desk 04:23 -!- jonatack1 [~jonatack@user/jonatack] has joined #secp256k1 04:25 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 04:40 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1 05:19 -!- jonatack2 [~jonatack@user/jonatack] has joined #secp256k1 05:21 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 06:03 -!- jonatack3 [~jonatack@user/jonatack] has joined #secp256k1 06:06 -!- jonatack2 [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 08:48 < real_or_random> hebasto: you've used if(CMAKE_VERSION VERSION_GREATER 3.14) to check for 3.15+ ... shouldn't that be VERSION_GREATER_EQUAL 3.15 ? 08:49 < real_or_random> intuitively I'd expect VERSION_GREATER 3.14 to match also for example 3.14.1 ... but I haven't tested this 08:55 < hebasto> real_or_random: you are right; `VERSION_GREATER_EQUAL` was just unavailable for 3.1 08:56 < hebasto> I'll add this improvement to https://github.com/bitcoin-core/secp256k1/pull/1239 08:57 < real_or_random> ok, nice 09:02 < real_or_random> we should try to get that one merged next week, it will tick a lot of boxes in the meta issue 09:06 < hebasto> it will :D 09:09 < real_or_random> maybe you could even add the followup to the just merged optional installation thing 09:09 < hebasto> already in it 09:37 < real_or_random> I meant https://github.com/bitcoin-core/secp256k1/pull/1263#issuecomment-1516564300 09:52 < hebasto> I meant the same :D 10:05 < real_or_random> sorry, I don't see it ^^ 11:59 -!- jonatack3 [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.8] 12:00 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1 14:56 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 14:56 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1 15:36 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8] 15:54 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1 15:54 -!- preimage is now known as hg 16:50 -!- waxwing_ [~waxwing@193.29.57.116] has quit [Quit: ZNC 1.7.4+deb0+bionic0 - https://znc.in] 16:50 -!- waxwing [~waxwing@193.29.57.116] has joined #secp256k1 19:51 -!- pakaro [~quassel@2001-1ae9-297-1f00-14f4-9600-a12f-4c70.ip6.tmcz.cz] has joined #secp256k1 19:52 -!- pakaro [~quassel@2001-1ae9-297-1f00-14f4-9600-a12f-4c70.ip6.tmcz.cz] has quit [Client Quit] 21:12 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1 21:14 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 21:19 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8] 23:31 -!- jonatack1 [~jonatack@user/jonatack] has joined #secp256k1 23:31 -!- jon_atack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] --- Log closed Fri Apr 21 00:00:38 2023