--- Log opened Wed May 03 00:00:50 2023 03:20 < real_or_random> I'm a bit confused... what's the magnitude limit? Is it: "The VERIFY_CHECKs say 32 but in practice we insist on 8"? 03:23 < sipa> @real_or_random IIRC it's 8 for the 10x26 field and higher for the 5x52 field 03:23 < sipa> My PR about abstracting the field interface normalizes it to 8 everywhere. 03:25 < real_or_random> hm ok, currently 10x26 enforces just 32 https://github.com/bitcoin-core/secp256k1/blob/master/src/field_10x26_impl.h#L39 03:25 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 03:27 < real_or_random> oh, I think <= 8 is just the precondition for sqr and mul 03:28 < sipa> Oh indeed. 03:28 -!- darosior [~darosior@194.36.189.246] has joined #secp256k1 03:29 < real_or_random> though random_field_element_magnitude sets at most 8 03:36 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 240 seconds] 03:39 < real_or_random> okay but the tests seem to pass when I change the VERIFY_CHECK to <= 8 (in 5x52 because that's what I'm running) 03:49 < real_or_random> sipa: I suggest to move the pseudocode / formula comments in the ellswift PR a bit to the right, so they all start in the same text column... I expect that this improves readability a lot. I have some local changes, happy to produce proper fixup commits if you're willing to accept them 05:02 -!- darosior [~darosior@194.36.189.246] has joined #secp256k1 06:24 -!- jonatack1 [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.8] 06:27 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1 06:29 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1 07:23 < real_or_random> sorry, I was wrong. changing the VERIFY_CHECK to <= 8 does not work. we run into in this assertion then (and not only in the tests for fe_half which sets maximum allowed magnitude explicitly for testing purposes). and your PR https://github.com/sipa/secp256k1/blob/202201_uniform_fe_rules/src/field_impl.h#L155 keeps it at 32 07:24 < real_or_random> it just unifies the bound into a single value 32 (across all impls) 09:00 -!- realtbast[m] [~realtbast@2001:470:69fc:105::1:69a9] has quit [Quit: You have been kicked for being idle] 09:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 09:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1 10:01 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #secp256k1 10:05 -!- Netsplit *.net <-> *.split quits: andytoshi, jnewbery, lightningbot, harding 10:05 -!- harding_ [quassel@newmail.dtrt.org] has joined #secp256k1 10:05 -!- jnewbery_ [~john@user/jnewbery] has joined #secp256k1 10:05 -!- andytosh1 [~apoelstra@user/andytoshi] has joined #secp256k1 10:10 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #secp256k1 13:50 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Remote host closed the connection] 14:16 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8] 15:58 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 18:43 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 19:26 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1 23:36 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1 --- Log closed Thu May 04 00:00:51 2023