--- Log opened Mon May 06 00:00:47 2024
00:33 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
01:35 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
01:47 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
03:45 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Read error: Connection reset by peer]
05:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
06:28 -!- jamesob [~jamesob@108.44.248.162] has joined #secp256k1
07:09 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
08:00 < real_or_random> meeting :)
08:00 < nickler> hi
08:01 < sipa> hi
08:03 < real_or_random> topics?
08:03 < real_or_random> we could talk about the release
08:03 < sipa> yeah, release
08:04 < real_or_random> the sorting PR has three ACKS, I guess we can merge it
08:05 < nickler> release captain is real_or_random this time around
08:06 < real_or_random> I think then the only things to do double check if we haven't missed anything notable in the changelog (but I don't think so) 
08:06 < real_or_random> yeah, I can do it this time, but let's talk about the timing
08:07 < real_or_random> when can we meet? will friday work? or thursday?
08:08 < nickler> or now/today?
08:08 < sipa> all of those work for me
08:09 < real_or_random> ah yes, we could also do it now :)
08:09 < nickler> thursday, friday wouldn't work well for me
08:10 < real_or_random> ok, then now
08:11 < sipa> ok
08:11 < sipa> 0.4.2 or 0.5.0 ?
08:12 < real_or_random> can one of you merge the PR? I have some issues signing the merge commit due to python update... (gpg wrapper) 
08:12 < sipa> will do
08:14 < sipa> hmm, copyright banner for 2021
08:14 < sipa> is that correct?
08:14 < real_or_random> lol
08:15 < real_or_random> I try to avoid copyright notices in new files, but I'm not going to care... I mean this code was initially taken from -zkp with the 2021 notice
08:16 < sipa> alright
08:17 < nickler> yeah it was created and merged in 2021
08:17 < real_or_random> so it's certainly okay to merge it like this. jonas could update it as author of the more recent changes , but he doesn't have to. 
08:18 < sipa> merged
08:18 < bitcoin-git> [secp256k1] sipa pushed 2 commits to master: https://github.com/bitcoin-core/secp256k1/compare/da515074e3eb...bb528cfb0876
08:18 < bitcoin-git> secp256k1/master 7d2591c Jonas Nick: Add secp256k1_pubkey_sort
08:18 < bitcoin-git> secp256k1/master bb528cf Pieter Wuille: Merge bitcoin-core/secp256k1#1518: Add secp256k1_pubkey_sort
08:18 < bitcoin-git> [secp256k1] sipa merged pull request #1518: Add secp256k1_pubkey_sort (master...pubkey-sort) https://github.com/bitcoin-core/secp256k1/pull/1518
08:19 < nickler> ok, going through the sanity checks now
08:20 < real_or_random> me too
08:22 < real_or_random> I guess it could be a 0.4.2
08:22 < real_or_random> (if the API checks pass)
08:23 < real_or_random> the only breakage I can think of is in installation/packaging scripts due to the changed build system options, and even this is unlikely (it only affects people with nonstandard flags)
08:23 < real_or_random> pinging hebasto in case you happen to be online and want to help testing :)
08:25 < real_or_random> nickler: btw, we're supposed to run the sanity checks on the release PR ^^ I'll work on one in a minute
08:26 < nickler> oh, right
08:26 < nickler> why not 0.5.0? We changed the API in a backward-compatible way
08:26 < real_or_random> did we?
08:26 < real_or_random> ah you said "compatible"
08:27 < real_or_random> yes... idk. I think this boils to whether there are special rules for 0.y.z in semantic versioning
08:28 < sipa> because this is 0.x.y, there are no real rules
08:28 < sipa> 0.5.0 would make more sense, as there was an API addition
08:28 < nickler> there are no real rules, but why not follow the rules as best as possible?
08:29 < real_or_random> nickler: how to follow the rules if there are none? :P
08:29 < real_or_random> no I agree, 0.5.0 is cosnistent with what we did in the past
08:29 < real_or_random> I misrembered
08:29 < sipa> well you can apply the 1.x.y rules, even if this isn't 1.x.y
08:29 < sipa> in which case this is 0.5.0
08:30 < real_or_random> let's just do 1.0.0
08:30 < real_or_random> jk, next time
08:30 < sipa> halfway there!
08:30 < sipa> clearly 0.5.0 = 1.0.0 / 2
08:30 < real_or_random> lol
08:31 < real_or_random> we can just release 0.5.0 twice
08:32 < real_or_random> commits: https://github.com/bitcoin-core/secp256k1/compare/v0.4.1...HEAD looks good to me, nothing more necessary for the changelog
08:34 < nickler> same
08:34 < sipa> agreed
08:38 < real_or_random> "The ABI is backward compatible with versions 0.4.x and 0.3.x." ... should be, right?
08:40 < sipa> Sounds right to me.
08:42 < nickler> yeah
08:42 < real_or_random> https://github.com/bitcoin-core/secp256k1/pull/1522
08:42 < bitcoin-git> [secp256k1] real-or-random opened pull request #1522: release: prepare for 0.5.0 (master...202405-0.5.0) https://github.com/bitcoin-core/secp256k1/pull/1522
08:43 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1
08:44 < real_or_random> I haven't tested the PR so far. running sanity checks now 
08:49 < real_or_random> hm the ABI checker is not happy
08:50 < real_or_random> ah but it gets the public API wrong...
08:53 < real_or_random> it reports:
08:53 < real_or_random> 1) secp256k1_ec_pubkey_sort as added symbol (that should be fine)
08:53 < real_or_random> 2)  secp256k1_ecmult_gen_context  has been changed (but that shouldn't be a problem?!)
08:54 < real_or_random> I believe it wrongly concludes that  ecmult_gen.h is a public header
08:59 < sipa> hmm
09:00 < nickler> yeah that's what it looks like, because it puts ecmult_gen.h in the header files list
09:00 < nickler> that is already the case when running the abi checker on 0.4.1
09:01 < real_or_random> or is this indirectly visible through secp256k1_context ?
09:02 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
09:09 < real_or_random> no, I don't think so
09:09 < nickler> If you explicitly set the header files via in the check-abi shell script via `abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2"  -public-headers ../include/`,
09:09 < nickler> the header files shown in the html are correct and it doesn't report a change in the context.
09:09 < real_or_random> ah nice, I wasn't aware that this is possible
09:13 < real_or_random> libsecp256k1.so.2.1.2 -> libsecp256k1.so.2.2.0 also looks correct
09:17 < real_or_random> I'd say letwait for CI?
09:17 < nickler> ACK'd, sipa did too, ready to merge real_or_random?
09:18 < real_or_random> let's wait for CI and then merge
09:19 < real_or_random> oh its still busy with the master commit
09:20 < real_or_random> ok, but some tasks are running ... https://github.com/bitcoin-core/secp256k1/pull/1522/checks wdyt? I think it's good practice to wait 
09:20 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
09:22 < nickler> yeah, let's wait
09:23 < sipa> seems reasonable to wait as a final sanity check
09:24 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
09:27 < bitcoin-git> [secp256k1] real-or-random opened pull request #1523: release cleanup: bump version after 0.5.0 (master...202405-post-0.5.0) https://github.com/bitcoin-core/secp256k1/pull/1523
09:31 < bitcoin-git> [secp256k1] jonasnick opened pull request #1524: check-abi: explicitly provide public headers (master...abi-checker-headers) https://github.com/bitcoin-core/secp256k1/pull/1524
09:36 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
09:38 < real_or_random> draft release summary/email: 
09:38 < real_or_random> This release includes algorithmic improvements which increase the speed of key generation and signing. At the same time, the binary size has been reduced significantly, which we expect to benefit embedded users in particular. Moreover, a new function to sort public keys has been added.
09:38 < real_or_random>  
09:38 < real_or_random> For a list of changes, see the CHANGELOG.md.
09:42 < sipa> looks great
09:53 < nickler> CI passed, I'm merging
09:53 < real_or_random> nice
09:56 < bitcoin-git> [secp256k1] jonasnick pushed 2 commits to master: https://github.com/bitcoin-core/secp256k1/compare/bb528cfb0876...e3a885d42a78
09:56 < nickler> done
09:56 < bitcoin-git> secp256k1/master c0e4ec3 Tim Ruffing: release: prepare for 0.5.0
09:56 < bitcoin-git> secp256k1/master e3a885d Jonas Nick: Merge bitcoin-core/secp256k1#1522: release: prepare for 0.5.0
09:56 < bitcoin-git> [secp256k1] jonasnick merged pull request #1522: release: prepare for 0.5.0 (master...202405-0.5.0) https://github.com/bitcoin-core/secp256k1/pull/1522
09:57 < real_or_random> cleanup PR: https://github.com/bitcoin-core/secp256k1/pull/1523
10:07 < bitcoin-git> [secp256k1] real-or-random pushed tag v0.5.0: https://github.com/bitcoin-core/secp256k1/compare/v0.5.0
10:09 < sipa> \o/
10:13 < bitcoin-git> [secp256k1] jonasnick pushed 2 commits to master: https://github.com/bitcoin-core/secp256k1/compare/e3a885d42a78...d7f6613dbbd2
10:13 < bitcoin-git> secp256k1/master 2f05e2d Tim Ruffing: release cleanup: bump version after 0.5.0
10:13 < bitcoin-git> secp256k1/master d7f6613 Jonas Nick: Merge bitcoin-core/secp256k1#1523: release cleanup: bump version after 0.5...
10:13 < bitcoin-git> [secp256k1] jonasnick merged pull request #1523: release cleanup: bump version after 0.5.0 (master...202405-post-0.5.0) https://github.com/bitcoin-core/secp256k1/pull/1523
10:18 < real_or_random> lol I got the year wrong in the changelog
10:21 < bitcoin-git> [secp256k1] real-or-random opened pull request #1525: changelog: Correct 0.5.0 release date (master...202405-release-year) https://github.com/bitcoin-core/secp256k1/pull/1525
10:25 < sipa> looks like we will, in fact, be releasing 0.5.0 twice then!
10:28 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
10:30 < bitcoin-git> [secp256k1] real-or-random pushed 2 commits to master: https://github.com/bitcoin-core/secp256k1/compare/d7f6613dbbd2...7d0bc0870f8b
10:30 < bitcoin-git> secp256k1/master d45d9b7 Tim Ruffing: changelog: Correct 0.5.0 release date
10:30 < bitcoin-git> secp256k1/master 7d0bc08 Tim Ruffing: Merge bitcoin-core/secp256k1#1525: changelog: Correct 0.5.0 release date
10:30 < bitcoin-git> [secp256k1] real-or-random merged pull request #1525: changelog: Correct 0.5.0 release date (master...202405-release-year) https://github.com/bitcoin-core/secp256k1/pull/1525
10:32 < real_or_random> lol, but we'll need to wait a year for 1.0.0 then
10:33 < real_or_random> 0.5.1 patch release with the corrected date? :D
10:51 < sipa> yes, but with other improvements too, and not today
11:41 < real_or_random> sure, I was just kidding
13:00 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:02 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
13:34 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:38 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
13:43 -!- cold [~cold@user/cold] has joined #secp256k1
14:17 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
14:34 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.2.2]
14:37 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
15:27 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
15:32 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
16:00 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
16:05 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
16:59 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
17:18 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
20:42 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
20:45 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
20:48 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
22:17 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
22:19 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
23:25 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
23:26 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
23:32 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
--- Log closed Tue May 07 00:00:48 2024