--- Log opened Mon Jul 29 00:00:07 2024
00:19 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
00:30 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
00:40 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
02:14 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
02:49 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
04:37 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
06:26 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
07:22 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
07:27 -!- sipa [~pw@user/sipa] has quit [Ping timeout: 258 seconds]
07:27 -!- sipa [~pw@user/sipa] has joined #secp256k1
07:44 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
07:55 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
08:01 < nickler> hi
08:01 < sipa> hi
08:01 < nickler> topic: state of the musig2 module
08:01 < nickler> ^ topic suggestion
08:02 < sipa> i'd be interested in hearing about that
08:04 < nickler> I think it's getting valuable review right now. The current state is that theStack josie and stratospher[m] reviewed the PR in detail, but didn't provide their final review yet.
08:04 < sipa> Alright, I do plan to look at it in the near future.
08:04 < nickler> real_or_random reviewed the -zkp version and some of the diffs in libsecp, but he's out for the next 1.5 months
08:04 < sipa> Right.
08:05 < sipa> topic suggestion: next release?
08:05 < nickler> the musig2 module is the top priority on my list right now, after that silent payments I think
08:06 < nickler> when is that? We should definitely do it this time... to fix building without extrakeys
08:07 < sipa> Feature freeze for Bitcoin Core is in 2 weeks.
08:07 < sipa> Though I think the subtree was updated to a non-released version perhaps?
08:09 < nickler> yes, shortly after the last release, May 16th
08:09 < sipa> Indeed, so for Bitcoin Core I don't think having a release is that urgent, but other users may appreciate it.
08:10 < sipa> We could do 0.5.1 in the next few days?
08:10 < sipa> I don't think I'll be available next monday.
08:11 < nickler> this Thursday? same time as this meeting?
08:11 < sipa> WFM
08:11 < nickler> hebasto: do you have time to take a look at https://github.com/bitcoin-core/secp256k1/pull/1574 ?
08:12 < nickler> great
08:13 < nickler> any other topics?
08:13 < sipa> None from me.
08:14 < nickler> end of meeting then I guess
08:36 -!- preimage [~halosghos@user/halosghost] has joined #secp256k1
09:00 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
09:01 < hebasto> nickler: on it
10:37 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:53 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Read error: Connection reset by peer]
10:54 -!- Nebraskka_ [~Nebraskka@user/nebraskka] has joined #secp256k1
11:00 -!- Nebraskka_ is now known as Nebraskka
12:04 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
12:30 < bitcoin-git> [secp256k1] jonasnick pushed 3 commits to master: https://github.com/bitcoin-core/secp256k1/compare/0055b86780f2...fded437c4cec
12:30 < bitcoin-git> secp256k1/master af551ab Jonas Nick: tests: do not use functions from extrakeys module
12:30 < bitcoin-git> secp256k1/master 763d938 Jonas Nick: ci: only enable extrakeys module when schnorrsig is enabled
12:30 < bitcoin-git> secp256k1/master fded437 Jonas Nick: Merge bitcoin-core/secp256k1#1574: Fix compilation when extrakeys module i...
12:30 < bitcoin-git> [secp256k1] jonasnick merged pull request #1574: Fix compilation when extrakeys module isn't enabled (master...fix-extrakeys) https://github.com/bitcoin-core/secp256k1/pull/1574
13:04 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:20 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
14:11 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
14:39 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/fded437c4cec1a29921c90be325d62ba866f44ce/src/modinv64_impl.h#L690-L693
14:40 < roconnor> these checks are likely redundent because if you hit them you will necessarily go through the loop again, where the checks are repeated without len, f, or g being modified.
14:45 < sipa> Sure, but literally every (correct) assertion in the codebase is redundant if you reason far enough.
15:10 < roconnor> I don't know that duplicating the same assertion multiple times is helpful.
15:57 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.3.5]
21:40 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
21:41 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #secp256k1
23:22 -!- tromp [~textual@92-110-219-57.cable.dynamic.v4.ziggo.nl] has joined #secp256k1
--- Log closed Tue Jul 30 00:00:08 2024