--- Log opened Mon Sep 08 00:00:34 2025
00:34 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
01:44 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
03:20 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
04:43 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
04:54 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
06:00 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
06:17 -!- jerryf_ [~jerryf@user/jerryf] has joined #secp256k1
06:19 -!- jerryf [~jerryf@user/jerryf] has quit [Ping timeout: 272 seconds]
06:23 -!- jerryf [~jerryf@user/jerryf] has joined #secp256k1
06:24 -!- jerryf_ [~jerryf@user/jerryf] has quit [Ping timeout: 272 seconds]
07:15 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
07:16 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
07:26 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
07:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
07:28 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
07:31 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
07:45 < bitcoin-git> [secp256k1] real-or-random pushed 2 commits to master: https://github.com/bitcoin-core/secp256k1/compare/03fb60ad2e38...4985ac0f8927
07:45 < bitcoin-git> secp256k1/master 806de38 Sebastian Falbesoner: doc: mention ctx requirement for `_ellswift_create` (not secp256k1_context...
07:45 < bitcoin-git> secp256k1/master 4985ac0 merge-script: Merge bitcoin-core/secp256k1#1737: doc: mention ctx requirement for `_ells...
07:45 < bitcoin-git> [secp256k1] real-or-random merged pull request #1737: doc: mention ctx requirement for `_ellswift_create` (not secp256k1_context_static) (master...doc-ctx-requirement-for-ellswift_create) https://github.com/bitcoin-core/secp256k1/pull/1737
07:47 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
07:48 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 250 seconds]
08:00 < real_or_random> meeeeting
08:02 < sipa> hi
08:03 < nickler> hi
08:03 < real_or_random> hi
08:03 < real_or_random> topics?
08:03 < fjahr> hi
08:03 < nickler> priorities after SP
08:06 < real_or_random> I'd be interested to get people's thoughts on https://github.com/bitcoin-core/secp256k1/issues/1736
08:07 < real_or_random> which is about whether we should initialize output arguments if the illegal_callback fires...  but I have nothing more to say here, this is just a request for comments
08:07 < sipa> will read
08:08 < real_or_random> but otherwise, priorities after SP is a good topic
08:09 < real_or_random> let's talk about this ^^
08:10 < real_or_random> I think there's not much on PR'd when it comes to added feature. One thing is the DLEQ proof, which would be a nice addition to SP once that has been merged, if stratospher[m] wants to pick it up again 
08:11 < sipa> there does seem to be some interest in cleanups, like benchmarks and tests
08:11 < sipa> based on recent PRs
08:11 < real_or_random> apart from that, if you ask me, progress on batch validation will be nice (which I count not as "feature" here)
08:11 < real_or_random> indeed yes.
08:11 < nickler> As for features, I think batch verification would be interesting to look at. This has been in the queue for a long time.
08:12 < sipa> yeah, i think batch validation is a good candidate - i'd consider it a feature?
08:12 < real_or_random> yes, let's call it a feature
08:13 < real_or_random> it's "just" an efficiency improvement  but with a new API, so it's pretty much like a feature
08:13 < nickler> Next release is scheduled for Oct 17th, maybe it's possible to get SP in.
08:13 < sipa> real_or_random: right, it's API-exposed
08:14 < real_or_random> It would also be nice to address "Clarify API doc of ecdsa_recover return value" until the release. This is the probably the "biggest" known defect and it's easy to address
08:14 < real_or_random> (even though it's just a bug in the docs)
08:14 < nickler> Batch verification also doesn't have the most straightforward API (in terms of implementation, I think it'll be nice to use).
08:15 < nickler> real_or_random: yeah, let's put it on the milestone
08:17 < nickler> also added SP to the milestone :)
08:17 < real_or_random> I think the test/benchmark stuff can be worked on in parallel. That's easier from a reviewing bandwidth  point of view 
08:17 < sipa> Yeah.
08:18 < real_or_random> which translates to "I don't mind merging if it had *some* eyeballs on it"
08:21 < real_or_random> other things to discuss?
08:23 < real_or_random> end of meeting then, I guess
08:24 < sipa> ok!
08:24 < nickler> No other things to discuss from my side
08:25 < josie> late to the party, but glad to see batch validation getting a mention! thats going to be a priority for me after SP
08:26 < fjahr> I will be spending time on the batch validation PR as well :)
08:33 < furszy> +1
08:35 -!- siv2r [~siv2r@2401:4900:1cc9:ce0d:804a:bc65:af63:5da1] has joined #secp256k1
08:39 -!- siv2r [~siv2r@2401:4900:1cc9:ce0d:804a:bc65:af63:5da1] has quit [Ping timeout: 250 seconds]
09:05 -!- siv2r [~siv2r@2401:4900:1cc9:ce0d:4879:3fb9:9d8e:39fd] has joined #secp256k1
09:20 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
09:23 -!- siv2r [~siv2r@2401:4900:1cc9:ce0d:4879:3fb9:9d8e:39fd] has quit [Quit: Client closed]
09:27 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
09:43 < beulah> Hi, Im running the secp256k1-zkp tests with clang's MemorySanitizer. 
09:43 < beulah> Valgrind is clean, but with MSan I get warning about use-of-uninitialized-value in secp256k1_pubkey_sort_cmp
09:43 < beulah>   src/modules/extrakeys/main_impl.h:293
09:43 < beulah> called from test_sort
09:43 < beulah>   src/modules/extrakeys/tests_impl.h:608
09:43 < beulah> I can verify that arrays `pk` and `pk_ptr` are initialised correctly, CTX is globally initialised for all tests.
09:43 < beulah> Could this be a case of false positives with msan?
09:47 < sipa> beulah: what happens if you disable asm optimizations?
09:48 < sipa> i don't know the status of -zkp
09:51 < beulah> this test code only exists in zkp
09:51 < beulah> asm was disables in the tests I ran
09:52 < beulah> CC=clang \ CFLAGS="-O1 -g -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins" \ LDFLAGS="-fsanitize=memory -fsanitize-memory-track-origins" \ ./configure \ --enable-experimental=yes \ --with-test-override-wide-multiply=auto \ --with-asm=no \ --with-ecmult-window=2 \ --with-ecmult-gen-precision=2 \ --enable-module-ecdh=yes \ --enable-module-recovery=yes \ --enable-module-ellswift=yes \ --enable-module-ecdsa-s2c=yes \ 
09:52 < beulah> --enable-module-bppp=yes \ --enable-module-rangeproof=yes \ --enable-module-whitelist=yes \ --enable-module-generator=yes \ --enable-module-schnorrsig=yes \ --enable-module-musig=yes \ --enable-module-ecdsa-adaptor=yes \ --enable-module-schnorrsig-halfagg=yes \ --enable-examples=yes \ --enable-ctime-tests=yes \ --with-valgrind=no
09:52 < beulah> This is the config flags I used
10:00 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:05 < beulah> https://github.com/BEULAHEVANJALIN/secp256k1-zkp/actions/runs/17544000911
10:45 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
10:54 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
10:55 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
11:58 < andytoshi> src/checkmem.h:47:14: fatal error: 'sanitizer/msan_interface.h' file not found
11:59 < andytoshi> beulah: do you know offhand what i need to install to build with these flags?
12:01 < nickler> ape
12:01 < nickler> export C_INCLUDE_PATH=$(nix eval --raw nixpkgs#valgrind.dev)/include:$(nix eval --raw nixpkgs#llvmPackages.compiler-rt.dev)/include
12:02 < nickler> ^
12:02 < nickler> I meant to type anditoshi, LOL
12:03 < nickler> andytoshi
12:04 < nickler> I'm looking and I can reproduce the error locally with the default config flags, clang and msan
12:05 < nickler> andytoshi: I also have export MSAN_OPTIONS=use_sigaltstack=false and I need nixpkgs\#llvmPackages.bintools for human-readable stack traces
12:07 < nickler> libsecp-zkp was last synced to libsecp in Jan 2024
12:08 < andytoshi> thanks!
12:14 < andytoshi> for some reason your C_INCLUDE_PATH thing didn't workfor me, but this did:
12:14 < andytoshi> nix-shell -p '(import <nixpkgs> {}).valgrind.dev' -p '(import <nixpkgs> {}).llvmPackages.compiler-rt.dev'
12:14 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
12:16 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
12:17 < nickler> Ok, I have a fix. This doesn't apply to libsecp, because the ec_pubkey_sort_cmp function has a different function signature
12:19 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
12:19  * andytoshi still running the tests
12:19 < andytoshi> lol you're way ahead of me
12:22 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
12:23 < nickler> I started earlier. https://github.com/BlockstreamResearch/secp256k1-zkp/pull/302
12:32 < andytoshi> nickler: kinda looks like the function expects a pointer-to-pointer-to-context and we were passing a pointer-to-context before
12:33 < andytoshi> oh, lol, but the context isn't ever actually used
12:33 < andytoshi> so this 'worked' only by accident
12:38 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
12:39 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 250 seconds]
12:42 < nickler> andytoshi: yeah and in libsecp there's no cmp_data, the cmp function expects a pointer to context directly.
12:44 < andytoshi> gotcha
12:44 < andytoshi> ok, i will ack this PR as soon as CI passes and I get my local CI running on it (haven't touched this project in many months and don't have many C projects to crib from..)
12:46 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
12:48 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
12:55 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
12:57 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
13:06 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
13:06 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
13:12 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
13:13 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
13:27 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:31 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
13:41 -!- Guest30 [~Guest30@ns557207.ip-54-39-16.net] has joined #secp256k1
13:42 -!- Guest30 [~Guest30@ns557207.ip-54-39-16.net] has quit [Client Quit]
13:49 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:54 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
13:55 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
13:55 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has joined #secp256k1
14:01 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
14:02 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 250 seconds]
14:18 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
14:18 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
15:29 -!- tromp [~textual@2001:1c00:3487:1b00:298e:6063:53dd:ee4e] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
15:41 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
15:43 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
16:26 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
16:27 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
16:45 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
16:47 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
17:06 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
17:08 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 245 seconds]
17:32 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
17:34 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
18:58 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
19:00 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
19:20 -!- jon_atack [~jonatack@user/jonatack] has joined #secp256k1
19:21 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
19:36 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
19:54 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
19:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
20:16 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
20:21 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
20:29 -!- jonatack [~jonatack@user/jonatack] has joined #secp256k1
20:34 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds]
20:48 -!- jerryf [~jerryf@user/jerryf] has quit [Remote host closed the connection]
21:18 -!- jerryf [~jerryf@user/jerryf] has joined #secp256k1
21:30 -!- corebot [~limnoria@user/core-meetbot] has quit [Remote host closed the connection]
21:31 -!- corebot [~limnoria@user/core-meetbot] has joined #secp256k1
22:03 < bitcoin-git> [secp256k1] l0rinc opened pull request #1740: doc: update release notes version to latest v0.7.0 (master...l0rinc/update-doc-version) https://github.com/bitcoin-core/secp256k1/pull/1740
23:58 < bitcoin-git> [secp256k1] real-or-random pushed 2 commits to master: https://github.com/bitcoin-core/secp256k1/compare/4985ac0f8927...36e76952cbf1
23:58 < bitcoin-git> secp256k1/master 7ebaa13 Sebastian Falbesoner: check-abi: remove support for obsolete CMake library output location (src/...
23:58 < bitcoin-git> secp256k1/master 36e7695 merge-script: Merge bitcoin-core/secp256k1#1738: check-abi: remove support for obsolete ...
23:58 < bitcoin-git> [secp256k1] real-or-random merged pull request #1738: check-abi: remove support for obsolete CMake library output location (src/libsecp256k1.so) (master...check-abi-remove_temporary_cmake_out_detection) https://github.com/bitcoin-core/secp256k1/pull/1738
--- Log closed Tue Sep 09 00:00:34 2025