--- Log opened Thu Feb 09 00:00:40 2023
01:29 < josie> w0xlt: I did a very rough branch here which makes the index optional for using silent payments: https://github.com/bitcoin/bitcoin/compare/master...josibake:bitcoin:silent-payments-no-index
01:32 < josie> the code is pretty rough but let me know what you think. I'm also fairly certain we could make `scantxoutset` use `-txindex` when scanning for an SP descriptor, but haven't tried yet
01:36 < josie> a few thoughts on the index: for the POC implementation, I don't think we need it. Also, if a user does need to import a descriptor or rescan, I think they would do less work without an index in most cases considering they will likely be scanning from a certain block height or from a wallet birthday, whereas creating the index will process all blocks since taproot activation
01:38 < josie> we will definitely need an index for light clients, and I also think having an SP index for a full node makes sense if the user wants multiple SP wallets per node. I'd suggest we keep the code for the index but in a separate PR for now to make the POC simpler to review
01:42 < josie> w0xlt: I can also leave feedback on the PR, but I wanted to get your initial thoughts first 
03:37 -!- Murch1 [~murch@user/murch] has quit [Quit: Bridge terminating on SIGTERM]
03:37 -!- sipa [~sipa@user/sipa] has quit [Quit: Bridge terminating on SIGTERM]
03:41 -!- Murch [~murch@user/murch] has joined #silentpayments
04:00 -!- sipa [~sipa@user/sipa] has joined #silentpayments
04:14 -!- sipa [~sipa@user/sipa] has quit [Ping timeout: 246 seconds]
04:14 -!- Murch [~murch@user/murch] has quit [Ping timeout: 248 seconds]
04:46 -!- Murch [~murch@user/murch] has joined #silentpayments
04:48 -!- sipa [~sipa@user/sipa] has joined #silentpayments
21:31 < w0xlt> josie: I agree with this approach. If the Silent Payments scheme is to advance in Bitcoin Core, the PR will need to be split into several parts and starting by isolating the index seems like a good idea.
21:31 < w0xlt> I was going to make a version that works without the index, but you were faster.
21:31 < w0xlt> As for the code, I took a quick look at it and it looks good to me. I wonder if there is a way to make `GetSilentPaymentKeysPerBlock` wallet independent so the logic can be reused by the index.
21:31 < w0xlt> I will review the patch soon and incorporate it into the PR.
--- Log closed Fri Feb 10 00:00:40 2023